public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <bonzini@gnu.org>
To: "Ismail Dönmez" <ismail@pardus.org.tr>
Cc: "Andreas Schwab" <schwab@suse.de>,
	"Gabriel Dos Reis" <gdr@cs.tamu.edu>,
	gcc@gcc.gnu.org, "Manuel López-Ibáñez" <lopezibanez@gmail.com>
Subject: Re: Changes in C++ FE regarding pedwarns to be errors are harmful
Date: Mon, 14 Jan 2008 11:03:00 -0000	[thread overview]
Message-ID: <478B3A9B.7000104@gnu.org> (raw)
In-Reply-To: <200801131810.30493.ismail@pardus.org.tr>

Ismail Dönmez wrote:
> Sunday 13 January 2008 18:03:20 tarihinde Andreas Schwab şunları yazmıştı:
>> Ismail Dönmez <ismail@pardus.org.tr> writes:
>>> That was just an example, real life testcase shows that problem stems
>>> from autoconf and its config.h. Projects end up defining things like
>>> HAVE_STDLIB_H twice which is not harmful at all but now causes an error
>>> if g++ is used.
>> Redefinitions with the same replacement list are not an error.
> 
> Ok but that still doesn't cover the general use of
> 
> #define PACKAGE_NAME foobar

We had to fix it ourselves for libffi as part of switching to autoconf 
2.50+.  The point is that installing config.h headers is broken by 
design -- and this is not something that the GCC community states.  See 
for example

http://www.cygwin.com/ml/automake/2000-10/msg00116.html

"Unfortunately, people are being lulled into a false sense of security,
because installing config.h appears to work while it is an uncommon
practice.  Things will go downhill fast if this becomes common
practice -- imagine the chaos that we would have if gtk.h indirectly
#included a raw (i.e. with rewriting prior to installation) config.h,
which set up a whole bunch of HAVE_foo macros and VERSION's that you
don't want to cope with when you use libgtk.  Even worse what if the
gnome headers installed another conig.h with overlapping and
contradicting macros...."

which warned about this already 8 years ago.  Sweet.

Why not fixing the handful of packages with a /^#define PACKAGE/d, 
instead of adding -fpermissive to the 50 users of those broken packages?
Paolo

  parent reply	other threads:[~2008-01-14 10:34 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-08 21:27 Ismail Dönmez
2008-01-08 21:34 ` Joe Buck
2008-01-08 21:43   ` Richard Guenther
2008-01-08 21:44   ` Ismail Dönmez
2008-01-08 22:13     ` Andrew Pinski
2008-01-08 22:29     ` Manuel López-Ibáñez
2008-01-08 22:36       ` Ismail Dönmez
2008-01-08 22:45         ` Andrew Pinski
2008-01-09 14:10           ` Paolo Bonzini
2008-01-09 15:38             ` Manuel López-Ibáñez
2008-01-09 15:57               ` Paolo Bonzini
2008-01-08 22:51         ` Manuel López-Ibáñez
2008-01-08 23:02           ` Ismail Dönmez
2008-01-09  1:23       ` Ismail Dönmez
2008-01-09  2:25         ` Manuel López-Ibáñez
2008-01-09 16:47           ` Ian Lance Taylor
2008-01-09 18:11             ` Benjamin Kosnik
2008-01-09 18:18               ` Andrew Pinski
2008-01-09 18:21                 ` Paolo Carlini
2008-01-09 19:42             ` Mark Mitchell
2008-01-11 17:06               ` Jason Merrill
2008-01-11 17:12                 ` Joe Buck
2008-01-11 17:55                   ` Mark Mitchell
2008-01-12 19:07                     ` Jonathan Wakely
2008-01-12 19:50                       ` Manuel López-Ibáñez
2008-01-13  3:28                         ` Jonathan Wakely
2008-01-13 15:30                           ` Manuel López-Ibáñez
2008-01-13 22:56                             ` Jonathan Wakely
2008-01-14  2:04                               ` Jonathan Wakely
2008-01-14  2:19                                 ` Manuel López-Ibáñez
2008-01-13 15:33         ` Gabriel Dos Reis
2008-01-13 15:36           ` Ismail Dönmez
2008-01-13 16:09             ` Andreas Schwab
2008-01-13 16:10               ` Ismail Dönmez
2008-01-13 16:13                 ` Richard Guenther
2008-01-13 16:41                   ` Ismail Dönmez
2008-01-13 23:08                     ` Manuel López-Ibáñez
2008-01-14 11:03                 ` Paolo Bonzini [this message]
2008-01-14 16:23                   ` Ismail Dönmez
2008-01-13 16:43             ` Gabriel Dos Reis
2008-01-13 16:45               ` Ismail Dönmez
2008-01-13 19:17                 ` Gabriel Dos Reis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=478B3A9B.7000104@gnu.org \
    --to=bonzini@gnu.org \
    --cc=gcc@gcc.gnu.org \
    --cc=gdr@cs.tamu.edu \
    --cc=ismail@pardus.org.tr \
    --cc=lopezibanez@gmail.com \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).