From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-return-201104-listarch-gcc=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 69681 invoked by alias); 19 Dec 2019 15:48:42 -0000
Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc/>
List-Post: <mailto:gcc@gcc.gnu.org>
List-Help: <http://gcc.gnu.org/ml/>
Sender: gcc-owner@gcc.gnu.org
Received: (qmail 69491 invoked by uid 89); 19 Dec 2019 15:48:32 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: foss.arm.com
Received: from foss.arm.com (HELO foss.arm.com) (217.140.110.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Dec 2019 15:48:16 +0000
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 543E21FB;	Thu, 19 Dec 2019 07:48:15 -0800 (PST)
Received: from e120077-lin.cambridge.arm.com (e120077-lin.cambridge.arm.com [10.2.78.81])	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6B32C3F718;	Thu, 19 Dec 2019 07:48:14 -0800 (PST)
Subject: Re: Commit messages and the move to git
To: Jonathan Wakely <jwakely.gcc@gmail.com>
Cc: Joseph Myers <joseph@codesourcery.com>, Segher Boessenkool <segher@kernel.crashing.org>, Eric Raymond <esr@thyrsus.com>, Jeff Law <law@redhat.com>, GCC Development <gcc@gcc.gnu.org>
References: <f54f97d0-ed07-bfd6-ce1d-1f5e498f9697@arm.com> <e6f9205c-1f9c-2d50-67b7-611f45bf6a25@redhat.com> <20191107142727.GA72444@thyrsus.com> <a5e2428c-60d5-3157-6b5f-662cfa76767b@arm.com> <20191109060151.GA82270@thyrsus.com> <78a57894-74f2-94d5-65a1-3ce2bd934f32@arm.com> <20191118155549.GH16031@gate.crashing.org> <fb6aa5da-9bc7-1fb5-4dee-efdcdf849a46@arm.com> <20191118171115.GI16031@gate.crashing.org> <ac635c47-884c-3832-193b-d45ce9336bca@arm.com> <alpine.DEB.2.21.1912182337150.12074@digraph.polyomino.org.uk> <alpine.DEB.2.21.1912182359470.12074@digraph.polyomino.org.uk> <CAH6eHdT+g6k-zEDzX6OGz-7xT7OjHNbvGPOPBi8XW+xjoOoF6A@mail.gmail.com> <6e226ca8-f0f1-f4a2-80dc-f19e5dec327d@arm.com> <alpine.DEB.2.21.1912191427170.20376@digraph.polyomino.org.uk> <CAH6eHdQckNwrwYXkLiHj9f_8FwLwSGTzkWp21j+iD5NjhGX2iw@mail.gmail.com> <7cbbef4f-23a4-6ea4-9071-07821e21a2d5@arm.com> <CAH6eHdSPUAPuXQQ-0jrTFttTiqDp3G5yHqas1Af3WuC7sdgA2g@mail.gmail.com>
From: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>
Message-ID: <48a2ffdb-2a04-c642-1d77-0719d1a42951@arm.com>
Date: Thu, 19 Dec 2019 15:48:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <CAH6eHdSPUAPuXQQ-0jrTFttTiqDp3G5yHqas1Af3WuC7sdgA2g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-12/txt/msg00322.txt.bz2

On 19/12/2019 15:44, Jonathan Wakely wrote:
> These scraped "INVALID" as the component from the changelog, because
> it said "libgfortran/24685":
> 
> revert: re PR libfortran/24685 (real(16) formatted input is broken for
> huge values (gfortran.dg/default_format_2.f90) [checkme: INVALID SVN
> r142840])
> revert: re PR libfortran/24685 (real(16) formatted input is broken for
> huge values (gfortran.dg/default_format_2.f90) [checkme: INVALID SVN
> r142841])
> 
> Shouldn't that be handled by the "compalias" dict?
> 
> Why are these invalid? The changelogs look OK:
> re PR c++/46134 (constexpr vs. defaulted ctor [checkme: INVALID SVN r166171])
> re PR c/11586 (after call sigaction, system() return wrong status
> [checkme: INVALID SVN r187542])
> re PR target/86677 (popcount builtin detection is breaking some kernel
> build [checkme: INVALID SVN r266039])
> 

INVALID means the PR was closed as invalid, which seems an suspect 
closure state for a PR that has had a patch installed.  In some cases 
the bug really was invalid and the commit is just some doc or other type 
cleanup, but it's often hard to be sure in the automated code, so it's 
flagged up for manual checking.

R.