From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from antelope.elm.relay.mailchannels.net (antelope.elm.relay.mailchannels.net [23.83.212.4]) by sourceware.org (Postfix) with ESMTPS id 2F3713858C31 for ; Tue, 21 Feb 2023 01:35:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2F3713858C31 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=eagercon.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eagercon.com X-Sender-Id: dreamhost|x-authsender|eager@eagerm.com Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id D9D03760A54; Tue, 21 Feb 2023 01:35:57 +0000 (UTC) Received: from pdx1-sub0-mail-a283.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 6B3E9760ABC; Tue, 21 Feb 2023 01:35:57 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1676943357; a=rsa-sha256; cv=none; b=TrmOQeYHbFSIBCM2mqXDOgoR+rDzbz/UhuAF9cn9jM3T+98ZxYY9/QeK2cWgM2Vbk1Npoc q2hzDTcEB2wo5WCIDtdiC00/1nKGtafBkVrJWInfWXXq4GkWkOyJgnk/EBBWgC0u8CZYrO HEFeCUk8qL1vEAh55GoVnX4JfWY5BJqD82qOmA3Np+jxb2/bToAKui/2Mfuolale1W9ePt ENVz8BzClGTre0vVi7gw5MYLIODCv1ifewcAg3H0s4Y0FNuu0WY2qSkV/9VDnLoX+i1uQ3 QFvEZ6Ubi9/dk5wovobknf5tR/xC8tlvt6CdzytMyBp6LXUfC9swEiQIczNECw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1676943357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UMMT3LtUAkMkrYd507sS8cT8IegGi90H+J+/ak+Wabc=; b=FzY5vWbL4jgaeQYzPgxds6ZVXedBAjV2I1481G10jR4bgD1aUDzrTcCX4nK0yGuzHzb1oh 8hNcLiwVdV/GeJbnxgvAfvKMKYp/rOAL+AHrfJW9fYIlB1dn+1K4L+9tSdtpSusIxj6avJ RRuNXhryB+ByNLbzcSJGY9lY+xdhoRwh2BRC/r1ZAVfuNyxY2VQdtUbdNZLgS8Q9VXMDrJ SueBEvzKAhi+aw5qOt/O3XW4su0RylkX+Ykh7pWXkZhqUxW6zG+urTobt5c2zLySnL3U01 7iddmCkyOswtiHFU8mF6YKpBQNO80g7OWhzGVhheKApT8i0aqx2fXd7/MD1dqw== ARC-Authentication-Results: i=1; rspamd-5db48964c-bfmd2; auth=pass smtp.auth=dreamhost smtp.mailfrom=eager@eagercon.com X-Sender-Id: dreamhost|x-authsender|eager@eagerm.com X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|eager@eagerm.com X-MailChannels-Auth-Id: dreamhost X-Chemical-Fumbling: 3534e51735bca4b5_1676943357670_3040189886 X-MC-Loop-Signature: 1676943357670:3365711935 X-MC-Ingress-Time: 1676943357670 Received: from pdx1-sub0-mail-a283.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.126.30.49 (trex/6.7.1); Tue, 21 Feb 2023 01:35:57 +0000 Received: from [192.168.20.12] (c-24-5-55-152.hsd1.ca.comcast.net [24.5.55.152]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by pdx1-sub0-mail-a283.dreamhost.com (Postfix) with ESMTPSA id 4PLMLj0VCGz34; Mon, 20 Feb 2023 17:35:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eagercon.com; s=dreamhost; t=1676943357; bh=UMMT3LtUAkMkrYd507sS8cT8IegGi90H+J+/ak+Wabc=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=reCaAP7aUb7zzEn1G4rZ7Gw2dJojZvShESrJT0ev6qcBcSOZ6VnOcsZIGrpfHIFsd 5HovZtubDW+Zi5bfty1p9cXvw7ZEanO3xDb5e+b6WsZxIyhZFkcGzUadafemn/ce9u K3iizqTwCkvHurR/GzinKdvkg9+gFpo/Wmx0JXgn3bqW0y3ajtMy5RsOVv9Sw+WgSn OW1e0pbPx/DKU8gatGhJTI7FnS3nVM6/QsGqK+ATul4gED37zlZSUmP6IHbZcenr1q 13d4kFiWWEmRHRn99vkerHQTzBL1vrPVgiUKhdxeE0kFIUMdFdo1SAZdLuaShVNnEs tXIyXa3EUGkyw== Message-ID: <498d23ca-06ce-65c5-a9ca-8ebd0240c597@eagercon.com> Date: Mon, 20 Feb 2023 17:35:55 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: MicroBlaze symver attribute support Content-Language: en-US To: joel@rtems.org, Vincent Fazio Cc: gcc@gcc.gnu.org References: From: Michael Eager In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/20/23 06:54, Joel Sherrill wrote: > > > On Mon, Feb 20, 2023 at 7:56 AM Vincent Fazio via Gcc > wrote: > > Michael, all, > > Regarding: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101766 > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102110 > > > If I understand correctly, since the GCC MicroBlaze targets generate ELF > images, it would seem there's no technical reason why `__attribute__ > ((symver ...))` cannot be supported? > > The issue seems to be that the MicroBlaze targets in config.gcc do not > include elfos.h > https://github.com/gcc-mirror/gcc/blob/master/gcc/config.gcc#L2369 > > > Which defines `ASM_OUTPUT_SYMVER_DIRECTIVE` > https://github.com/gcc-mirror/gcc/blob/master/gcc/config/elfos.h#L259 > > Which is necessary for > https://github.com/gcc-mirror/gcc/blob/master/gcc/varasm.cc#L6260 > > > Changing the targets to include elfos.h leads to a number of > conflicts with > the target specific header (config/microblaze/microblaze.h). > > Should `ASM_OUTPUT_SYMVER_DIRECTIVE` be copied into > config/microblaze/microblaze.h or should the MicroBlaze targets and > header > be reworked to support elfos.h? > > > IMO reworked to include elfos.h. During the RTEMS port, we noticed that > some quirks on the microblaze gcc because it isn't using elfos.h. This > likely > will mean it will be updated as a side-effect of normal GCC maintenance > instead of being an odd singleton which doesn't share. > > > I'm asking because I've seen a number of projects run into this > issue (xz, > elfutils, libfuse, libkcapi, cryptsetup). > > > And RTEMS. > > --joel Joel -- do you have a patch to add elfos.h to MicroBlaze? -- Michael Eager