From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11511 invoked by alias); 9 Jun 2009 19:33:20 -0000 Received: (qmail 11396 invoked by uid 22791); 9 Jun 2009 19:33:19 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-ew0-f205.google.com (HELO mail-ew0-f205.google.com) (209.85.219.205) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 09 Jun 2009 19:33:14 +0000 Received: by ewy1 with SMTP id 1so272917ewy.8 for ; Tue, 09 Jun 2009 12:33:12 -0700 (PDT) Received: by 10.210.126.5 with SMTP id y5mr594283ebc.14.1244575992300; Tue, 09 Jun 2009 12:33:12 -0700 (PDT) Received: from ?132.207.221.200? ([132.207.221.200]) by mx.google.com with ESMTPS id 24sm156730eyx.43.2009.06.09.12.33.10 (version=SSLv3 cipher=RC4-MD5); Tue, 09 Jun 2009 12:33:11 -0700 (PDT) Message-ID: <4A2EB8F4.2080003@gmail.com> Date: Tue, 09 Jun 2009 19:33:00 -0000 From: Taras Glek User-Agent: Thunderbird 2.0.0.21 (X11/20090409) MIME-Version: 1.0 To: gcc@gcc.gnu.org Subject: plugin callbacks after compiler errors Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2009-06/txt/msg00199.txt.bz2 While developing my plugin I've noticed that many callbacks need to be guarded with "if (errorcount)" or the plugin will cause a gcc crash due to receiving less complete data than it expected. Should the plugin API guard callbacks in invoke_plugin_callbacks() to avoid 99% of plugins running into this issue? Taras