From: Paolo Bonzini <paolo.bonzini@gmail.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: Daniel Berlin <dberlin@dberlin.org>,
Ian Lance Taylor <iant@google.com>,
Basile STARYNKEVITCH <basile@starynkevitch.net>,
GCC Mailing List <gcc@gcc.gnu.org>
Subject: Re: increasing the number of GCC reviewers
Date: Wed, 10 Jun 2009 14:38:00 -0000 [thread overview]
Message-ID: <4A2FC533.7080800@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0906101056150.17312@digraph.polyomino.org.uk>
Joseph S. Myers wrote:
> On Tue, 9 Jun 2009, Daniel Berlin wrote:
>
>> be, most things support it, and there are some cool possibilities,
>> like gerrit (http://code.google.com/p/gerrit/). It is precisely built
>
> I think a critical feature of any fancy code review system (or of how it
> is configured for GCC) used for a significant amount of GCC review is that
> all the patches and reviews are automatically sent to gcc-patches in plain
> text so that they get archived in the static list archives and can
> continue to be referred to that way, grepped, etc., after the next N
> transitions. Email replies to patch submissions should also continue to
> work smoothly.
Yes, Daniel just mentioned a possibility. It is good to consider
possible developments even if for now you're just keeping the old workflow.
gerrit was developed at Google, but git's own development (and Linux's)
proceeds only on mailing lists, and for this reason git has a command like
git send-email --cc joseph@codesourcery.com master..HEAD
to submit a private branch all at once to gcc-patches@ and CC you. :-)
It is true however that currently we are not encouraging outsiders to
contribute, because old timers work on mostly large patches (or large
sequences of patches) that reviewers know about. For the same reason,
it is easier for small patches to fall through the cracks than large ones.
Paolo
next prev parent reply other threads:[~2009-06-10 14:38 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 15:52 Basile STARYNKEVITCH
2009-06-09 16:45 ` Andrew Haley
2009-06-09 17:17 ` Basile STARYNKEVITCH
2009-06-09 17:20 ` Basile STARYNKEVITCH
2009-06-09 17:31 ` Andrew Haley
2009-06-09 17:55 ` Adam Nemet
2009-06-09 18:01 ` Andrew Haley
2009-06-10 0:14 ` Ben Elliston
2009-06-10 2:05 ` Dave Korn
2009-06-09 19:19 ` Joe Buck
2009-06-09 18:10 ` Paolo Bonzini
2009-06-09 18:10 ` Basile STARYNKEVITCH
2009-06-09 18:21 ` Richard Guenther
2009-06-09 18:42 ` Andrew Haley
2009-06-09 19:13 ` Basile STARYNKEVITCH
2009-06-09 19:29 ` Andrew Haley
2009-06-10 7:45 ` Steven Bosscher
2009-06-10 12:15 ` Richard Kenner
2009-06-10 12:47 ` Joseph S. Myers
2009-06-10 18:12 ` Diego Novillo
2009-06-09 20:22 ` Diego Novillo
2009-06-09 21:10 ` Gabriel Dos Reis
2009-06-09 21:36 ` Tom Tromey
2009-06-10 0:45 ` Ben Elliston
2009-06-09 21:37 ` Ian Lance Taylor
2009-06-10 0:51 ` Joseph S. Myers
2009-06-10 1:04 ` Ian Lance Taylor
2009-06-10 1:36 ` Tom Tromey
2009-06-10 2:40 ` Daniel Berlin
2009-06-10 11:10 ` Joseph S. Myers
2009-06-10 14:38 ` Paolo Bonzini [this message]
2009-06-10 15:00 ` Joseph S. Myers
2009-06-10 14:35 ` Weddington, Eric
2009-06-10 14:52 ` Joseph S. Myers
2009-06-10 15:47 ` Weddington, Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A2FC533.7080800@gmail.com \
--to=paolo.bonzini@gmail.com \
--cc=basile@starynkevitch.net \
--cc=dberlin@dberlin.org \
--cc=gcc@gcc.gnu.org \
--cc=iant@google.com \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).