From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20082 invoked by alias); 10 Jun 2009 14:38:08 -0000 Received: (qmail 20072 invoked by uid 22791); 10 Jun 2009 14:38:08 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from yw-out-1718.google.com (HELO yw-out-1718.google.com) (74.125.46.157) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 10 Jun 2009 14:37:57 +0000 Received: by yw-out-1718.google.com with SMTP id 5so380149ywm.26 for ; Wed, 10 Jun 2009 07:37:55 -0700 (PDT) Received: by 10.90.115.13 with SMTP id n13mr1190425agc.16.1244644675631; Wed, 10 Jun 2009 07:37:55 -0700 (PDT) Received: from yakj.usersys.redhat.com (nat-pool-brq.redhat.com [62.40.79.66]) by mx.google.com with ESMTPS id 10sm1820agd.33.2009.06.10.07.37.53 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 10 Jun 2009 07:37:54 -0700 (PDT) Message-ID: <4A2FC533.7080800@gmail.com> Date: Wed, 10 Jun 2009 14:38:00 -0000 From: Paolo Bonzini User-Agent: Thunderbird 2.0.0.17 (X11/20081009) MIME-Version: 1.0 To: "Joseph S. Myers" CC: Daniel Berlin , Ian Lance Taylor , Basile STARYNKEVITCH , GCC Mailing List Subject: Re: increasing the number of GCC reviewers References: <4A2E8528.8090604@starynkevitch.net> <4aca3dc20906091940r63296e84s18256473d8a7ad95@mail.gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2009-06/txt/msg00241.txt.bz2 Joseph S. Myers wrote: > On Tue, 9 Jun 2009, Daniel Berlin wrote: > >> be, most things support it, and there are some cool possibilities, >> like gerrit (http://code.google.com/p/gerrit/). It is precisely built > > I think a critical feature of any fancy code review system (or of how it > is configured for GCC) used for a significant amount of GCC review is that > all the patches and reviews are automatically sent to gcc-patches in plain > text so that they get archived in the static list archives and can > continue to be referred to that way, grepped, etc., after the next N > transitions. Email replies to patch submissions should also continue to > work smoothly. Yes, Daniel just mentioned a possibility. It is good to consider possible developments even if for now you're just keeping the old workflow. gerrit was developed at Google, but git's own development (and Linux's) proceeds only on mailing lists, and for this reason git has a command like git send-email --cc joseph@codesourcery.com master..HEAD to submit a private branch all at once to gcc-patches@ and CC you. :-) It is true however that currently we are not encouraging outsiders to contribute, because old timers work on mostly large patches (or large sequences of patches) that reviewers know about. For the same reason, it is easier for small patches to fall through the cracks than large ones. Paolo