From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-return-155900-listarch-gcc=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 17993 invoked by alias); 12 Aug 2009 16:40:44 -0000
Received: (qmail 17962 invoked by uid 22791); 12 Aug 2009 16:40:43 -0000
X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 	tests=AWL,BAYES_00,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from ey-out-1920.google.com (HELO ey-out-1920.google.com) (74.125.78.145)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Aug 2009 16:40:37 +0000
Received: by ey-out-1920.google.com with SMTP id 5so65699eyb.8         for <gcc@gcc.gnu.org>; Wed, 12 Aug 2009 09:40:34 -0700 (PDT)
Received: by 10.210.142.10 with SMTP id p10mr2714650ebd.43.1250095232623;         Wed, 12 Aug 2009 09:40:32 -0700 (PDT)
Received: from yakj.usersys.redhat.com (nat-pool-brq.redhat.com [62.40.79.66])         by mx.google.com with ESMTPS id 10sm141592eyd.27.2009.08.12.09.40.30         (version=TLSv1/SSLv3 cipher=RC4-MD5);         Wed, 12 Aug 2009 09:40:31 -0700 (PDT)
Message-ID: <4A82F080.3030703@gnu.org>
Date: Wed, 12 Aug 2009 17:56:00 -0000
From: Paolo Bonzini <bonzini@gnu.org>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2
MIME-Version: 1.0
To: Paul Edwards <mutazilah@gmail.com>
CC: Ulrich Weigand <uweigand@de.ibm.com>, gcc@gcc.gnu.org
Subject: Re: i370 port
References: <200908121348.n7CDmrV1012019@d12av02.megacenter.de.ibm.com> <7F6F71C82A5F4C3DBBA620CCD0081FCD@Paullaptop>
In-Reply-To: <7F6F71C82A5F4C3DBBA620CCD0081FCD@Paullaptop>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc/>
List-Post: <mailto:gcc@gcc.gnu.org>
List-Help: <http://gcc.gnu.org/ml/>
Sender: gcc-owner@gcc.gnu.org
X-SW-Source: 2009-08/txt/msg00198.txt.bz2

> Ok, after a few false leads, I found something that produced a
> pleasing result. Fantastic I should say!
>
> With this mod:
>
> C:\devel\gcc\gcc>cvs diff debug.c
> Index: debug.c
> ===================================================================
> RCS file: c:\cvsroot/gcc/gcc/debug.c,v
> retrieving revision 1.1.1.1
> diff -r1.1.1.1 debug.c
> 20a21,31
>> #include "output.h"
>> #include "flags.h"
>>
>> void
>> fff (line, text)
>> unsigned int line ATTRIBUTE_UNUSED;
>> const char *text ATTRIBUTE_UNUSED;
>> {
>> if (flag_debug_asm)
>> fprintf(asm_out_file, "fff %d %s\n", line, text);
>> }

with s/fff/ASM_COMMENT_START/ and with a proper function name, this is 
actually an almost acceptable patch.  Only, you also have to do 
app_enable/app_disable (search for the other occurrences of 
flag_debug_asm in dwarf2out.c, they also explain why this is needed). 
These probably can be moved to common code in general.

> But let me guess - I'm not allowed to modify debug.c and have
> to decide whether MVS is an sdb, xcoff, dbx, dwarf 1/2, or vms?

No, that's fine.  -dA can actually be handled by common code.

Paolo