From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-return-156172-listarch-gcc=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 10288 invoked by alias); 26 Aug 2009 10:47:30 -0000
Received: (qmail 10262 invoked by uid 22791); 26 Aug 2009 10:47:29 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail-fx0-f207.google.com (HELO mail-fx0-f207.google.com) (209.85.220.207)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 Aug 2009 10:47:23 +0000
Received: by fxm3 with SMTP id 3so24459fxm.8         for <multiple recipients>; Wed, 26 Aug 2009 03:47:20 -0700 (PDT)
Received: by 10.204.154.203 with SMTP id p11mr2418546bkw.180.1251283640331;         Wed, 26 Aug 2009 03:47:20 -0700 (PDT)
Received: from yakj.usersys.redhat.com (nat-pool-str.redhat.com [66.187.229.200])         by mx.google.com with ESMTPS id y15sm8898476fkd.17.2009.08.26.03.47.18         (version=TLSv1/SSLv3 cipher=RC4-MD5);         Wed, 26 Aug 2009 03:47:19 -0700 (PDT)
Message-ID: <4A9512B5.50005@gnu.org>
Date: Wed, 26 Aug 2009 13:31:00 -0000
From: Paolo Bonzini <bonzini@gnu.org>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Lightning/1.0pre Thunderbird/3.0b3
MIME-Version: 1.0
To: Dave Korn <dave.korn.cygwin@googlemail.com>
CC: NightStrike <nightstrike@gmail.com>, gcc@gcc.gnu.org,   davek@gcc.gnu.org, Ralf Wildenhues <Ralf.Wildenhues@gmx.de>,   Mook - <mook.gcc@gmail.com>,  Kai Tietz <ktietz70@googlemail.com>
Subject: Re: r150960 changed ltmain.sh and broke the build
References: <b609cb3b0908260211q4ca347efw94f4e420d1ac5efc@mail.gmail.com> <4A950CFE.7060709@gmail.com> <4A950C2A.8040204@gnu.org> <4A9510BA.1030704@gmail.com> <4A9512E2.9010104@gmail.com>
In-Reply-To: <4A9512E2.9010104@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc/>
List-Post: <mailto:gcc@gcc.gnu.org>
List-Help: <http://gcc.gnu.org/ml/>
Sender: gcc-owner@gcc.gnu.org
X-SW-Source: 2009-08/txt/msg00470.txt.bz2

On 08/26/2009 12:48 PM, Dave Korn wrote:
> Dave Korn wrote:
>
>>> Also please single-quote the commands.
>>
>>    Ok, why?
>
>    BTW should I do that for all four of the patterns?  And what about $dirname
> and $basename, and the couple of dozen other locations in ltmain.sh that use
> quoted sed scripts?  (You didn't answer my question about "why" yet so I can't
> infer anything.)

I don't like very much backslash sequences in double-quoted variables. 
It's portable, but somewhat unintuitive.  But this is upstream code 
after all, so it's better to leave it alone.  Sorry for the false alarm.

Paolo