Re: LTO and the inlining of functions only called once.

[Toon Moene <toon@moene.org>]

Richard Guenther wrote:

> On Sat, Oct 10, 2009 at 1:46 PM, Richard Guenther
> <richard.guenther@gmail.com> wrote:
>> On Sat, Oct 10, 2009 at 1:34 PM, Toon Moene <toon@moene.org> wrote:

[ Inlining all functions called once ]

>>> I'd like to see some fireworks, too !
>> That's not the parameter you want to tweak ;)  You want
>>
>> --param large-function-growth=10000 --param large-function-insns=1000000
>> --param large-stack-frame-growth=10000 --param large-stack-frame=100000
> 
> Or rather for testing the effect of inlining all functions called once
> use the following
> patch:
> 
> Index: ipa-inline.c
> ===================================================================
> --- ipa-inline.c	(revision 152615)
> +++ ipa-inline.c	(working copy)
> @@ -1249,8 +1249,8 @@ cgraph_decide_inlining (void)
>  			   node->callers->caller->global.size);
>  		}
> 
> -	      if (cgraph_check_inline_limits (node->callers->caller, node,
> -					      NULL, false))
> +	      if (1 || cgraph_check_inline_limits (node->callers->caller, node,
> +						   NULL, false))
>  		{
>  		  cgraph_mark_inline (node->callers);
>  		  if (dump_file)

Going this route, thanks !

> tuning params will affect other inlining decisions as well.

Yep, I was afraid of that too, but think it is inconsequential for our code.

Thanks !

-- 
Toon Moene - e-mail: toon@moene.org - phone: +31 346 214290
Saturnushof 14, 3738 XG  Maartensdijk, The Netherlands
At home: http://moene.org/~toon/
Progress of GNU Fortran: http://gcc.gnu.org/gcc-4.5/changes.html