From: Jeff Law <law@redhat.com>
To: Ian Bolton <bolton@IceraSemi.com>
Cc: Vladimir Makarov <vmakarov@redhat.com>, gcc@gcc.gnu.org
Subject: Re: Understanding IRA
Date: Fri, 23 Oct 2009 07:33:00 -0000 [thread overview]
Message-ID: <4AE0D6F7.9040006@redhat.com> (raw)
In-Reply-To: <4D60B0700D1DB54A8C0C6E9BE69163700BE00A8B@EXCHANGEVS.IceraSemi.local>
On 10/19/09 12:30, Ian Bolton wrote:
> Hi Jeff and Vladimir.
>
> Jeff: I'd be interested in trying the patch if you can send it my way.
>
It's nothing special.
/* Return nonzero if REGNO is a particularly bad choice for reloading X. */
static int
ira_bad_reload_regno_1 (int regno, rtx x)
{
int x_regno;
ira_allocno_t a;
enum reg_class pref;
/* We only deal with pseudo regs. */
if (! x || GET_CODE (x) != REG)
return 0;
x_regno = REGNO (x);
if (x_regno < FIRST_PSEUDO_REGISTER)
return 0;
/* If the pseudo prefers REGNO explicitly, then do not consider
REGNO a bad spill choice. */
pref = reg_preferred_class (x_regno);
if (reg_class_size[pref] == 1
&& TEST_HARD_REG_BIT (reg_class_contents[pref], regno))
return 0;
/* If the pseudo conflicts with REGNO, then we consider REGNO a
poor choice for a reload regno. */
a = ira_regno_allocno_map[x_regno];
if (TEST_HARD_REG_BIT (ALLOCNO_TOTAL_CONFLICT_HARD_REGS (a), regno))
return 1;
return 0;
}
/* Return nonzero if REGNO is a particularly bad choice for reloading
IN or OUT. */
int
ira_bad_reload_regno (int regno, rtx in, rtx out)
{
return (ira_bad_reload_regno_1 (regno, in)
|| ira_bad_reload_regno_1 (regno, out));
}
Then change the loop in allocate_reload_reg to iterate 3 times intead of
2. And add this fragment
if (pass == 1
&& ira_bad_reload_regno (regnum, rld[r].in, rld[r].out))
continue;
To body of hte conditional starting with
if ((reload_reg_free_p ...
It's really just a hack. I don't want to spend much time on that code
as ultimately I want it all to go away.
Jeff
next prev parent reply other threads:[~2009-10-22 22:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-16 14:22 Ian Bolton
2009-10-16 15:23 ` Vladimir Makarov
2009-10-16 16:19 ` Jeff Law
2009-10-19 19:21 ` Ian Bolton
2009-10-19 21:09 ` Vladimir Makarov
2009-10-23 7:33 ` Jeff Law [this message]
2009-11-04 17:52 ` Ian Bolton
2009-11-04 19:49 ` Jeff Law
2009-10-16 15:45 ` Vladimir Makarov
2009-11-03 16:29 ` Ian Bolton
2009-11-03 23:02 ` Jeff Law
2009-11-04 17:13 ` Vladimir Makarov
2009-11-05 0:23 ` Jeff Law
2009-11-05 17:36 Ian Bolton
2009-11-05 18:05 ` Ian Bolton
2009-11-06 12:53 ` Dave Hudson
2009-11-09 14:13 ` Ian Bolton
2009-11-10 12:19 ` Dave Hudson
2009-11-10 17:21 ` Jeff Law
2009-11-10 17:38 ` Ian Bolton
2009-11-11 15:19 ` Ian Bolton
2009-11-11 16:12 ` Jeff Law
2009-11-11 17:04 ` Vladimir Makarov
2009-11-11 18:36 ` Ian Bolton
2009-11-11 20:09 ` Ian Bolton
2009-11-16 17:35 ` Ian Bolton
[not found] ` <4B01BB87.6020902@redhat.com>
2009-11-19 15:41 ` Ian Bolton
[not found] ` <4B1451C7.2010207@redhat.com>
2009-12-02 20:29 ` Ian Bolton
2009-12-03 19:16 ` Jeff Law
2009-12-07 13:30 ` Ian Bolton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE0D6F7.9040006@redhat.com \
--to=law@redhat.com \
--cc=bolton@IceraSemi.com \
--cc=gcc@gcc.gnu.org \
--cc=vmakarov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).