From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22329 invoked by alias); 6 Nov 2009 19:01:11 -0000 Received: (qmail 22170 invoked by uid 22791); 6 Nov 2009 19:01:08 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-119-friday.nerim.net (HELO maiev.nerim.net) (62.4.16.119) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 06 Nov 2009 19:01:03 +0000 Received: from hector.lesours (ours.starynkevitch.net [213.41.244.95]) by maiev.nerim.net (Postfix) with ESMTP id BDDF3B8883; Fri, 6 Nov 2009 20:01:00 +0100 (CET) Received: from [192.168.0.1] by hector.lesours with esmtp (Exim 4.69) (envelope-from ) id 1N6U3C-0000i2-7x; Fri, 06 Nov 2009 20:00:46 +0100 Message-ID: <4AF47257.8040307@starynkevitch.net> Date: Fri, 06 Nov 2009 19:01:00 -0000 From: Basile STARYNKEVITCH User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701) MIME-Version: 1.0 To: Diego Novillo CC: Richard Guenther , Rafael Espindola , gcc , Grigori Fursin , Joern Rennecke , Zbigniew Chamski Subject: new plugin events References: <4AE72A4F.8000303@starynkevitch.net> <4AF28075.7020808@starynkevitch.net> <4AF291A6.7000600@starynkevitch.net> <38a0d8450911050824l838fd92ya9f3a08205c80a85@mail.gmail.com> <4AF33453.7090200@starynkevitch.net> <38a0d8450911060724h3c6f9ddh3e84c2c763ac4de0@mail.gmail.com> <84fc9c000911060818s3462aff1r1ebfb298506b6939@mail.gmail.com> <4AF4634D.5050303@starynkevitch.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2009-11/txt/msg00163.txt.bz2 I am changing the subject to new plugin events. It used to be: PLUGIN_PRAGMAS event The discussion has nothing to do with pragma inside plugins anymore. Diego Novillo wrote: > On Fri, Nov 6, 2009 at 12:56, Basile STARYNKEVITCH > wrote: > >> What is the criteria for adding them or for rejecting them as theoretical? > > That you have a specific plugin making concrete use of them. A > theoretical event would be one that is only added just in case a > future plugin may have a use for it. > > I don't have an internal plugin branch. I am working off of a 4.4 > compiler with backported plugin support. The events I need to add are > all for dehydra's use. I need to add an event for when the parser > finishes recognizing a DECL (the PR I pointed to earlier) and also I > need some pre-processor events for allowing dehydra to expose things > like #define and #include to user javascript code. I fully agree and I probably will use myself these events within 2 or 3 years, but then the ICI effort seems to be exactly in the same position. [They have a branch somewhere demonstration all their needs - this is code, not theory] But there is a chichen & egg issue still here. So, to add a new event, people (outside of the first circle of GCC like Diego Novillo & Richard Guenther & perhaps Rafael Espindola, that is outside of the "reviewer" set) need to first code their plugin and patch their GCC trunk, and then submit a patch. I repeat that adding several plugin events (I mean extending the enum plugin_event in gcc-plugins.h) is very inocolous, provided the event is not appearing in some call to invoke_plugin_callbacks which is executed many times. I also am convinced that GCC need more plugins, it should not be afraid of them (GCC should be afraid of competitor compilers, not of plugins). Hence the GCC community should help the ICI community to make ICI a big plugin itself for the next gcc-4.5. And that help means accepting new events, if the ICI people need them. Of course, ICI should quickly define the set of events they need. But they should first push their new events into the GCC trunk, and then patch their existing ICI code to use them. I really insist that the position "events are only accepted if there exist a mature & running plugin needing them" is not sustainable. And I also insist that having 4.5 with a bigger set of plugins is important. I mean 4.5, not 4.6. The 4.5 compiler will still be used a lot in 2013! I don't understand why adding new plugin events is so difficult for people outside the first circle. The first circle should trust a bit more outsiders wanting to code plugins. If some ICI guy says I need this and this event, we should listen & discuss his patch! [Same goes for me] Regards. -- Basile STARYNKEVITCH http://starynkevitch.net/Basile/ email: basilestarynkevitchnet mobile: +33 6 8501 2359 8, rue de la Faiencerie, 92340 Bourg La Reine, France *** opinions {are only mines, sont seulement les miennes} ***