From: "H. Peter Anvin" <hpa@zytor.com>
To: Andrew Haley <aph@redhat.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H.J. Lu" <hjl.tools@gmail.com>,
rostedt@goodmis.org, Ingo Molnar <mingo@elte.hu>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
feng.tang@intel.com,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
David Daney <ddaney@caviumnetworks.com>,
Richard Guenther <richard.guenther@gmail.com>,
gcc <gcc@gcc.gnu.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH][GIT PULL][v2.6.32] tracing/x86: Add check to detect GCC messing with mcount prologue
Date: Tue, 24 Nov 2009 19:56:00 -0000 [thread overview]
Message-ID: <4B0C3A2F.20703@zytor.com> (raw)
In-Reply-To: <4B0C13F4.5090106@redhat.com>
On 11/24/2009 09:12 AM, Andrew Haley wrote:
>>
>> If we're changing gcc anyway, then let's add the option of intercepting
>> the function at the point where the machine state is well-defined by
>> ABI, which is before the function stack frame is set up.
>
> Hmm. On the x86 I suppose we could just inject a naked call instruction,
> but not all aeches allow us to call anything before we've saved the return
> address. Or are you talking x86 only?
>
For x86, we should use a naked call.
For architectures where that is not possible, we should use a minimal
sequence such that the ABI state at the invocation point is 100% derivable.
On MIPS, for example, we could use a sequence such as:
mov at, ra
jal __fentry__
It would be up to __fentry__ to save the value in at and to restore it
back into ra before resuming, meaning that __fentry__ has a nonstandard
calling convention.
-hpa
next prev parent reply other threads:[~2009-11-24 19:56 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LFD.2.00.0911181933540.24119@localhost.localdomain>
[not found] ` <tip-887a29f59b93cf54e21814869a4ab6e80b6fa623@git.kernel.org>
[not found] ` <20091119072040.GA23579@elte.hu>
[not found] ` <alpine.LFD.2.00.0911191053390.24119@localhost.localdomain>
[not found] ` <alpine.LFD.2.00.0911191423190.24119@localhost.localdomain>
2009-11-19 15:39 ` BUG: GCC-4.4.x changes the function frame on some functions Thomas Gleixner
2009-11-19 15:45 ` Andrew Haley
2009-11-19 15:55 ` H. Peter Anvin
2009-11-19 15:59 ` Richard Guenther
2009-11-19 16:03 ` Steven Rostedt
2009-11-19 16:13 ` H. Peter Anvin
2009-11-19 16:20 ` Frederic Weisbecker
2009-11-19 16:07 ` Thomas Gleixner
2009-11-19 16:19 ` Andrew Haley
2009-11-19 16:45 ` Thomas Gleixner
2009-11-19 16:13 ` Steven Rostedt
2009-11-19 15:46 ` H. Peter Anvin
2009-11-19 15:51 ` Richard Guenther
2009-11-19 15:53 ` Richard Guenther
2009-11-19 17:38 ` Andi Kleen
2009-11-19 17:41 ` Linus Torvalds
2009-11-19 17:52 ` Thomas Gleixner
2009-11-19 18:00 ` Steven Rostedt
2009-11-19 18:04 ` Richard Guenther
2009-11-19 18:23 ` Andrew Haley
2009-11-19 18:42 ` Linus Torvalds
2009-11-19 18:45 ` Linus Torvalds
2009-11-19 18:56 ` Linus Torvalds
2009-11-19 19:03 ` Thomas Gleixner
2009-11-23 9:17 ` Jakub Jelinek
2009-11-23 9:53 ` Thomas Gleixner
2009-11-19 19:12 ` David Daney
2009-11-19 19:29 ` Steven Rostedt
2009-11-19 19:47 ` Frederic Weisbecker
2009-11-19 19:55 ` Kai Tietz
2009-11-19 20:06 ` Frederic Weisbecker
2009-11-19 20:06 ` Steven Rostedt
2009-11-19 20:18 ` Steven Rostedt
2009-11-19 20:29 ` Frederic Weisbecker
2009-11-19 20:26 ` Frederic Weisbecker
2009-11-19 20:38 ` Linus Torvalds
2009-11-19 20:45 ` Steven Rostedt
2009-11-19 19:51 ` H. Peter Anvin
2009-11-19 20:08 ` Linus Torvalds
2009-11-19 21:13 ` Jeff Law
2009-11-19 20:11 ` Steven Rostedt
2009-11-19 21:07 ` Jeff Law
2009-11-19 18:34 ` Thomas Gleixner
2009-11-19 18:40 ` Linus Torvalds
2009-11-19 18:48 ` Ingo Molnar
2009-11-19 19:08 ` Steven Rostedt
2009-11-19 19:51 ` Ingo Molnar
2009-11-20 9:58 ` [PATCH] gcc mcount-nofp was " Andi Kleen
2009-11-20 12:35 ` Steven Rostedt
2009-11-20 19:08 ` H. Peter Anvin
2009-11-19 20:37 ` Thomas Gleixner
2009-11-19 18:22 ` Andrew Haley
2009-11-19 18:34 ` Steven Rostedt
2009-11-19 18:37 ` Andrew Pinski
2009-11-19 18:38 ` H. Peter Anvin
2009-11-19 18:38 ` Andrew Haley
2009-11-19 18:40 ` Thomas Gleixner
2009-11-20 5:24 ` [PATCH][GIT PULL][v2.6.32] tracing/x86: Add check to detect GCC messing with mcount prologue Steven Rostedt
2009-11-20 5:33 ` Steven Rostedt
2009-11-20 17:02 ` Steven Rostedt
2009-11-20 17:15 ` H. Peter Anvin
2009-11-20 19:36 ` Andrew Haley
2009-11-20 19:48 ` Steven Rostedt
2009-11-20 19:50 ` H. Peter Anvin
2009-11-22 9:39 ` H.J. Lu
2009-11-22 17:21 ` Andrew Haley
2009-11-22 23:31 ` H.J. Lu
2009-11-24 14:43 ` Andrew Haley
2009-11-24 14:56 ` Thomas Gleixner
2009-11-24 15:06 ` Jakub Jelinek
2009-11-24 15:32 ` Andrew Haley
2009-11-24 15:36 ` Jakub Jelinek
2009-11-24 15:48 ` Andrew Haley
2009-11-24 16:39 ` H. Peter Anvin
2009-11-24 17:12 ` Andrew Haley
2009-11-24 17:30 ` Steven Rostedt
2009-11-25 20:05 ` H. Peter Anvin
2009-11-24 19:56 ` H. Peter Anvin [this message]
2009-11-25 15:29 ` Thomas Gleixner
2009-11-25 15:45 ` Ingo Molnar
2009-11-25 15:53 ` Thomas Gleixner
2009-11-25 16:26 ` Ingo Molnar
2009-11-25 16:45 ` Jakub Jelinek
2009-11-25 20:13 ` H. Peter Anvin
2009-11-25 21:01 ` Andrew Haley
2009-11-22 9:06 ` Ingo Molnar
2009-11-24 17:05 Ross Ridge
2009-11-24 17:11 ` Andrew Haley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0C3A2F.20703@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=aph@redhat.com \
--cc=ddaney@caviumnetworks.com \
--cc=feng.tang@intel.com \
--cc=fweisbec@gmail.com \
--cc=gcc@gcc.gnu.org \
--cc=heiko.carstens@de.ibm.com \
--cc=hjl.tools@gmail.com \
--cc=jakub@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=richard.guenther@gmail.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).