From: Dave Korn <dave.korn.cygwin@googlemail.com>
To: Sean D'Epagnier <geckosenator@gmail.com>
Cc: Dave Korn <dave.korn.cygwin@googlemail.com>, gcc@gcc.gnu.org
Subject: Re: fixed-point support in c++
Date: Fri, 19 Mar 2010 13:04:00 -0000 [thread overview]
Message-ID: <4BA3793E.8030007@gmail.com> (raw)
In-Reply-To: <b9d4feda1003160215k21cafbbal63d58104adcb632b@mail.gmail.com>
On 16/03/2010 09:15, Sean D'Epagnier wrote:
> I went through the c++ parser and added support for fixed point there.
> Everything seems to be working, and I am able to use fixed-point
> numbers in c++.
>
> The c++ parser is kind of complex and it is possible I missed
> something. I would love to get feedback on this patch, and hopefully
> it can get committed to gcc.
Do you have a copyright assignment on file for GCC? For a non-trivial
contribution of this size, it's a requirement before the patch can be accepted.
Once that is established, your patch would need a changelog entry in the
standard format, and you need to have built the compiler both patched and
clean and run a full C and C++ testsuite on both to check for regressions.
Oh, and sending it to the -patches list is the best way to make clear that
it's ready for review, once we've got the rest sorted out.
cheers,
DaveK
next prev parent reply other threads:[~2010-03-19 12:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 1:28 Sean D'Epagnier
2010-03-16 1:32 ` Dave Korn
2010-03-16 10:12 ` Sean D'Epagnier
2010-03-19 13:04 ` Dave Korn [this message]
2010-04-13 15:34 ` Sean D'Epagnier
2010-04-13 16:33 ` Dave Korn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA3793E.8030007@gmail.com \
--to=dave.korn.cygwin@googlemail.com \
--cc=gcc@gcc.gnu.org \
--cc=geckosenator@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).