public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
* fixincl 'make check' regressions...
@ 2010-03-16  6:48 David Miller
  2010-03-16 14:50 ` Bruce Korb
  2010-03-19 11:55 ` David Miller
  0 siblings, 2 replies; 4+ messages in thread
From: David Miller @ 2010-03-16  6:48 UTC (permalink / raw)
  To: bkorb; +Cc: gcc


Ever since your changes installed on March 12th, I've been getting
fixincludes testsuite failures of the form below.

I also notice that none of these changes added ChangeLog entries, and
furthermore the SVN commit messages were extremely terse so it was
hard to diagnose the intent or reasoning behind your changes.

iso/math_c99.h /home/davem/src/GIT/GCC/gcc/fixincludes/tests/base/iso/math_c99.h differ: char 1366, line 52
*** iso/math_c99.h	Mon Mar 15 22:55:36 2010
--- /home/davem/src/GIT/GCC/gcc/fixincludes/tests/base/iso/math_c99.h	Thu Jan 21 04:06:11 2010
***************
*** 49,55 ****
  			   ? __builtin_signbitf(x) \
  			   : sizeof(x) == sizeof(long double) \
  			     ? __builtin_signbitl(x) \
! 			     : __builtin_signbit(x));
  #endif  /* SOLARIS_MATH_8_CHECK */
  
  
--- 49,55 ----
  			   ? __builtin_signbitf(x) \
  			   : sizeof(x) == sizeof(long double) \
  			     ? __builtin_signbitl(x) \
! 			     : __builtin_signbit(x))
  #endif  /* SOLARIS_MATH_8_CHECK */
  
  

There were fixinclude test FAILURES

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: fixincl 'make check' regressions...
  2010-03-16  6:48 fixincl 'make check' regressions David Miller
@ 2010-03-16 14:50 ` Bruce Korb
  2010-03-19 11:55 ` David Miller
  1 sibling, 0 replies; 4+ messages in thread
From: Bruce Korb @ 2010-03-16 14:50 UTC (permalink / raw)
  To: David Miller; +Cc: gcc

The intent was to clear up some stuff in the README.
When I noticed that I had affected other files, I had tried to put
everything back.  Obviously a glitch.  I'll fix it when I get home
tonight.

On Mon, Mar 15, 2010 at 11:00 PM, David Miller <davem@davemloft.net> wrote:
>
> Ever since your changes installed on March 12th, I've been getting
> fixincludes testsuite failures of the form below.
>
> I also notice that none of these changes added ChangeLog entries, and
> furthermore the SVN commit messages were extremely terse so it was
> hard to diagnose the intent or reasoning behind your changes.
>
> iso/math_c99.h /home/davem/src/GIT/GCC/gcc/fixincludes/tests/base/iso/math_c99.h differ: char 1366, line 52
> *** iso/math_c99.h      Mon Mar 15 22:55:36 2010
> --- /home/davem/src/GIT/GCC/gcc/fixincludes/tests/base/iso/math_c99.h   Thu Jan 21 04:06:11 2010
> ***************
> *** 49,55 ****
>                           ? __builtin_signbitf(x) \
>                           : sizeof(x) == sizeof(long double) \
>                             ? __builtin_signbitl(x) \
> !                            : __builtin_signbit(x));
>  #endif  /* SOLARIS_MATH_8_CHECK */
>
>
> --- 49,55 ----
>                           ? __builtin_signbitf(x) \
>                           : sizeof(x) == sizeof(long double) \
>                             ? __builtin_signbitl(x) \
> !                            : __builtin_signbit(x))
>  #endif  /* SOLARIS_MATH_8_CHECK */
>
>
>
> There were fixinclude test FAILURES
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: fixincl 'make check' regressions...
  2010-03-16  6:48 fixincl 'make check' regressions David Miller
  2010-03-16 14:50 ` Bruce Korb
@ 2010-03-19 11:55 ` David Miller
  2010-03-19 16:02   ` Bruce Korb
  1 sibling, 1 reply; 4+ messages in thread
From: David Miller @ 2010-03-19 11:55 UTC (permalink / raw)
  To: bkorb; +Cc: gcc


You said you would fix this several nights ago, but I still
haven't seen any changes to fixincludes since then.

When will you get around to fixing these regressions you
introduced?

Thank you.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: fixincl 'make check' regressions...
  2010-03-19 11:55 ` David Miller
@ 2010-03-19 16:02   ` Bruce Korb
  0 siblings, 0 replies; 4+ messages in thread
From: Bruce Korb @ 2010-03-19 16:02 UTC (permalink / raw)
  To: David Miller; +Cc: gcc

David Miller wrote:
> You said you would fix this several nights ago, but I still
> haven't seen any changes to fixincludes since then.
> 
> When will you get around to fixing these regressions you
> introduced?
> 
> Thank you.

Done.  Terribly sorry for the delay.  I became unemployed and
got a two week contract.  Little time at the moment.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-03-19 14:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-16  6:48 fixincl 'make check' regressions David Miller
2010-03-16 14:50 ` Bruce Korb
2010-03-19 11:55 ` David Miller
2010-03-19 16:02   ` Bruce Korb

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).