From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1355 invoked by alias); 6 Apr 2010 15:23:21 -0000 Received: (qmail 1243 invoked by uid 22791); 6 Apr 2010 15:23:18 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Apr 2010 15:23:14 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o36FNDOd008844 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 6 Apr 2010 11:23:13 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o36FNCKj008074; Tue, 6 Apr 2010 11:23:12 -0400 Received: from [172.17.64.15] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o36FNApH030858; Tue, 6 Apr 2010 11:23:11 -0400 Message-ID: <4BBB51DD.2000001@redhat.com> Date: Tue, 06 Apr 2010 15:23:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.8) Gecko/20100301 Fedora/3.0.3-1.fc12 Thunderbird/3.0.3 MIME-Version: 1.0 To: Jakub Jelinek CC: Alexandre Oliva , GCC Subject: Re: VTA/debugging vs reload-v2 References: <4BBA11BC.4060300@redhat.com> <4BBA6FCB.10302@redhat.com> <20100406063558.GL3601@sunsite.ms.mff.cuni.cz> In-Reply-To: <20100406063558.GL3601@sunsite.ms.mff.cuni.cz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2010-04/txt/msg00082.txt.bz2 On 04/06/10 00:35, Jakub Jelinek wrote: > On Mon, Apr 05, 2010 at 05:18:35PM -0600, Jeff Law wrote: > >>> 2. When renaming references from P to P' in a region, do take debug >>> insns in the region into account, renaming references in debug insns as >>> you would in any other insn. >>> >>> >> OK. So presumably the 2nd argument in a VAR_LOCATION can be any rtl >> expression? Meaning I have to parse it looking for things that need >> changing? Right? >> > The problematic stuff is mainly when some RTL > with non-VOIDmode (REG, MEM etc.) needs to be replaced with a VOIDmode > constant - in that case simplify_replace_{,fn_}rtx needs to be used to > change the invalid RTL into valid. These shouldn't be a problem. > But I guess for reload2 you'll be > changing just REGs and MEMs to other REGs and MEMs - in that case > just a replacement through say for_each_rtx is possible too. > Yea, we're going to have to walk down the expression with for_each_rtx searching for REGs, then see if the REG we found needs replacing. Handling narrowing SUBREGs makes this marginally more complex, but it's still manageable. I just wanted to be sure there that there weren't any assumptions I could make to simplify the code :-) jeff