* PING -- MicroBlaze target support patches
@ 2010-05-12 19:53 Michael Eager
2010-07-10 18:04 ` Gerald Pfeifer
0 siblings, 1 reply; 2+ messages in thread
From: Michael Eager @ 2010-05-12 19:53 UTC (permalink / raw)
To: gcc-patches, GCC
Could someone please review these patches?
Add support for Xilinx MicroBlaze processor:
http://gcc.gnu.org/ml/gcc-patches/2010-04/msg01903.html
http://gcc.gnu.org/ml/gcc-patches/2010-04/msg01905.html
http://gcc.gnu.org/ml/gcc-patches/2010-04/msg01908.html
http://gcc.gnu.org/ml/gcc-patches/2010-04/msg01907.html
http://gcc.gnu.org/ml/gcc-patches/2010-04/msg01906.html
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: PING -- MicroBlaze target support patches
2010-05-12 19:53 PING -- MicroBlaze target support patches Michael Eager
@ 2010-07-10 18:04 ` Gerald Pfeifer
0 siblings, 0 replies; 2+ messages in thread
From: Gerald Pfeifer @ 2010-07-10 18:04 UTC (permalink / raw)
To: Michael Eager; +Cc: gcc-patches, gcc
On Wed, 12 May 2010, Michael Eager wrote:
> Could someone please review these patches?
>
> Add support for Xilinx MicroBlaze processor:
>
> http://gcc.gnu.org/ml/gcc-patches/2010-04/msg01903.html
This is okay with three small changes.
Please use "Do not" instead of "Don't" in invoke.texi.
Use proper markup for -fno-zero-initialized-in-bss in the same.
Similarly, please use @var in
Supported values are in the format vX.YY.Z, where X is a major version,
YY is the minor version, and Z is compatiblity code.
in invoke.texi.
> http://gcc.gnu.org/ml/gcc-patches/2010-04/msg01905.html
> http://gcc.gnu.org/ml/gcc-patches/2010-04/msg01908.html
> http://gcc.gnu.org/ml/gcc-patches/2010-04/msg01907.html
These three I cannot review/approve, but the strike me as pretty
straightforward, not touching lots of core code? Where are we
regarding this? Is this stuck somewhere?
> http://gcc.gnu.org/ml/gcc-patches/2010-04/msg01906.html
This is fine, too. For the announcement on the main page, let's say
"processor" (lower case) and there is a closing </p> missing on the
changes.html page.
Good work!
Gerald
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-10 18:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-05-12 19:53 PING -- MicroBlaze target support patches Michael Eager
2010-07-10 18:04 ` Gerald Pfeifer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).