toplevel out of sync

toplevel out of sync

[Paolo Bonzini]

All,

the toplevel configury of gcc/gdb/binutils is very much out of sync.

If people agree, I would like to freeze commits to the toplevel 
configury until they are not diverging anymore.

Also, I would like to make a new policy that from now on patches to the 
toplevel cannot be committed by anyone who doesn't have write access to 
both gcc and src.  Is there any agreement on this?

Unfortunately I don't have much time to devote to bringing the trees 
back in shape, and not even to chase down committers of patches placed 
only on one side.  Can anybody help with this?  In particular, if DJ 
could provide with the last date when the tree was synchronized that 
would help.

Paolo

Re: toplevel out of sync

[Ralf Wildenhues]

* Paolo Bonzini wrote on Tue, May 25, 2010 at 06:06:16PM CEST:
> the toplevel configury of gcc/gdb/binutils is very much out of sync.

> Unfortunately I don't have much time to devote to bringing the trees
> back in shape, and not even to chase down committers of patches
> placed only on one side.  Can anybody help with this?

I can take a look.

> ... the last date when the tree was synchronized ...

It looked fairly good 3 months ago[1].

Do you prefer tracking down committers and letting them finish their
work, or should I just go ahead and sync sets of commits as I did last
time?

Thanks,
Ralf

[1]
$ L="git log --until=3.months.ago --pretty=format:%H"
$ diff <( cd gcc && git show $($L origin/trunk | head -n 1):configure.ac ) \
       <( cd src && git show $($L origin/master | head -n 1):configure.ac )

Re: toplevel out of sync

[Paolo Bonzini]

On 05/25/2010 07:09 PM, Ralf Wildenhues wrote:
> * Paolo Bonzini wrote on Tue, May 25, 2010 at 06:06:16PM CEST:
>> the toplevel configury of gcc/gdb/binutils is very much out of sync.
>
>> Unfortunately I don't have much time to devote to bringing the trees
>> back in shape, and not even to chase down committers of patches
>> placed only on one side.  Can anybody help with this?
>
> I can take a look.
>
>> ... the last date when the tree was synchronized ...
>
> It looked fairly good 3 months ago[1].
>
> Do you prefer tracking down committers and letting them finish their
> work, or should I just go ahead and sync sets of commits as I did last
> time?

As you prefer.  I'd rather see a list of commits before giving you green 
light though. :-)

Paolo

Re: toplevel out of sync

[Ralf Wildenhues]

* Paolo Bonzini wrote on Tue, May 25, 2010 at 07:10:33PM CEST:
> On 05/25/2010 07:09 PM, Ralf Wildenhues wrote:
> >>... the last date when the tree was synchronized ...
> >
> >It looked fairly good 3 months ago[1].

Toplevel and config/ went out of sync with commit 6c8aa2aa884d of the
GCC infradead git mirror, aka. r157945, on April 2.  Since then, there
have been no commits on src that were not synced to GCC.

> >Do you prefer tracking down committers and letting them finish their
> >work, or should I just go ahead and sync sets of commits as I did last
> >time?
> 
> As you prefer.  I'd rather see a list of commits before giving you
> green light though. :-)

commit id of infradead mirror, GCC SVN revision number:

17281d1ee17f204064cfcbcc82089aefa19e3779   159527
401f30d69e280e18a9581b819376d18786595d3b   159173
decab1d0d6db331f662d42679eb1a8d473f72920   159134
bcd70fb06d56d9316d49019f5c0a3109def08d39   158763
a9ed67d000f285282e61aa9b87cc8d992a8731df   158762
22c56f6f70e07d6d9991a294439613dbf8eb60e0   158550
8b6a3525690f368dc965cd1457dc128d1925c995   158459
7da77e3b5958bf72909a3d238b2be0aa0820cb41   158423
82cf45c792250d333911ae6d2719fea77b520f0d   158285
d1d17d418a5c66a792e9988a945ca25e89692632   157946
6c8aa2aa884de79314b9b16a374518f4fd6624aa   157945

There are no changes in intl, libiberty.  The sourceware git mirror
doesn't seem to carry libdecnumber.  Which files in include/ were
part of libiberty again?

Thanks,
Ralf

Re: toplevel out of sync

[Ralf Wildenhues]

* Ralf Wildenhues wrote on Tue, May 25, 2010 at 07:33:53PM CEST:
> * Paolo Bonzini wrote on Tue, May 25, 2010 at 07:10:33PM CEST:
> > As you prefer.  I'd rather see a list of commits before giving you
> > green light though. :-)
> 
> commit id of infradead mirror, GCC SVN revision number:

One more missing in config/:
f299d473920cb31abfc07842575b43bbf08383d6   155648

Re: toplevel out of sync

[DJ Delorie]

> Also, I would like to make a new policy that from now on patches to
> the toplevel cannot be committed by anyone who doesn't have write
> access to both gcc and src.  Is there any agreement on this?

Our current policy certainly doesn't work, either we come up with
something that will, or abandon the whole idea and let chaos reign.

> In particular, if DJ could provide with the last date when the tree
> was synchronized that would help.

I don't recall.  It's stricly a manual process.

Re: toplevel out of sync

[DJ Delorie]

> There are no changes in intl, libiberty.  The sourceware git mirror
> doesn't seem to carry libdecnumber.  Which files in include/ were
> part of libiberty again?

Libiberty is kept in sync because gcc is the master and src is the
copy, so it can be mostly automated.  The libiberty sync includes
libiberty/, intl/, libdecnumber/, and those files in include/ that
exist in both repositories (src has more files therein which are
src-specific).

Re: toplevel out of sync

[NightStrike]

On Tue, May 25, 2010 at 4:38 PM, DJ Delorie <dj@redhat.com> wrote:
>
>> Also, I would like to make a new policy that from now on patches to
>> the toplevel cannot be committed by anyone who doesn't have write
>> access to both gcc and src.  Is there any agreement on this?
>
> Our current policy certainly doesn't work, either we come up with
> something that will, or abandon the whole idea and let chaos reign.

Ideas:
Switch to svn and use svn:externals to link the two repos
Make binutils be part of the gcc repository to begin with
Lock the files on the binutils side and only allow a specific user to
commit; Make that user a bot that's hooked onto the gcc commit

Re: toplevel out of sync

[Dave Korn]

On 25/05/2010 17:06, Paolo Bonzini wrote:

> Unfortunately I don't have much time to devote to bringing the trees
> back in shape, and not even to chase down committers of patches placed
> only on one side.  Can anybody help with this?  

  Augh.  I forgot to copy over this one:

> 	PR lto/42776
> 	* configure.ac (--enable-lto): Refactor handling so libelf tests
> 	are only performed inside then-clause of ACX_ELF_TARGET_IFELSE,
> 	and allow LTO to be explicitly enabled on non-ELF platforms that
> 	are known to support it inside else-clause.
> 	* configure: Regenerate.

  I'll do that right away.

    cheers,
      DaveK

Re: toplevel out of sync

[Dave Korn]

On 25/05/2010 18:33, Ralf Wildenhues wrote:

> bcd70fb06d56d9316d49019f5c0a3109def08d39   158763
> a9ed67d000f285282e61aa9b87cc8d992a8731df   158762

  I'm responsible for those two, and I'm copying them across right now; sorry
for forgetting.

    cheers,
      DaveK

Re: toplevel out of sync

[Dave Korn]

On 26/05/2010 05:58, Dave Korn wrote:
> On 25/05/2010 18:33, Ralf Wildenhues wrote:
> 
>> bcd70fb06d56d9316d49019f5c0a3109def08d39   158763
>> a9ed67d000f285282e61aa9b87cc8d992a8731df   158762
> 
>   I'm responsible for those two, and I'm copying them across right now; sorry
> for forgetting.

  And while I'm at it, I'll take care of these two as well:

> 17281d1ee17f204064cfcbcc82089aefa19e3779   159527
> 401f30d69e280e18a9581b819376d18786595d3b   159173

... since they're one-liner additions to the section I'm synching.

    cheers,
      DaveK

[PATCH, committed] Re: toplevel out of sync

[Dave Korn]

[-- Attachment #1: Type: text/plain, Size: 1594 bytes --]

On 26/05/2010 06:09, Dave Korn wrote:
> On 26/05/2010 05:58, Dave Korn wrote:
>> On 25/05/2010 18:33, Ralf Wildenhues wrote:
>>
>>> bcd70fb06d56d9316d49019f5c0a3109def08d39   158763
>>> a9ed67d000f285282e61aa9b87cc8d992a8731df   158762
>>   I'm responsible for those two, and I'm copying them across right now; sorry
>> for forgetting.
> 
>   And while I'm at it, I'll take care of these two as well:
> 
>> 17281d1ee17f204064cfcbcc82089aefa19e3779   159527
>> 401f30d69e280e18a9581b819376d18786595d3b   159173
> 
> ... since they're one-liner additions to the section I'm synching.

  I've synched across the above-mentioned GCC revisions to the top-level
configure.ac script in /src, with the following ChangeLog:

2010-05-26  Dave Korn  <dave.korn.cygwin AT gmail.com>

	Merge from gcc:

	2010-05-18  Steven Bosscher  <steven AT gcc.gnu.org>
	* configure.ac (--enable-lto): All *-apple-darwin* now support LTO.
	* configure: Regenerate.

	2010-05-07  Steven Bosscher  <steven AT gcc.gnu.org>
	* configure.ac (--enable-lto): Add x86_64-apple-darwin* as
	a platform that supports LTO.
	* configure: Regenerate.

	2010-04-27  Dave Korn  <dave.korn.cygwin AT gmail.com>
	PR lto/42776
	* configure.ac (--enable-lto): Refactor handling so libelf tests
	are only performed inside then-clause of ACX_ELF_TARGET_IFELSE,
	and allow LTO to be explicitly enabled on non-ELF platforms that
	are known to support it inside else-clause.
	* configure: Regenerate.

  Committed after building and testing binutils on i686-pc-cygwin just to make
sure nothing went wrong in the merge.

    cheers,
      DaveK


[-- Attachment #2: sync.diff --]
[-- Type: text/x-c, Size: 1876 bytes --]

Index: configure.ac
===================================================================
RCS file: /cvs/src/src/configure.ac,v
retrieving revision 1.102
diff -p -u -r1.102 configure.ac
--- configure.ac	27 Apr 2010 14:24:37 -0000	1.102
+++ configure.ac	26 May 2010 04:54:16 -0000
@@ -1651,17 +1651,8 @@ AC_ARG_ENABLE(lto,
 enable_lto=$enableval,
 enable_lto=yes; default_enable_lto=yes)
 
-ACX_ELF_TARGET_IFELSE([],
-if test x"$default_enable_lto" = x"yes" ; then
-  enable_lto=no
-else
-  if test x"$enable_lto" = x"yes"; then
-    AC_MSG_ERROR([LTO support requires an ELF target.])
-  fi
-fi
-default_enable_lto=no)
 
-if test x"$enable_lto" = x"yes" ; then
+ACX_ELF_TARGET_IFELSE([if test x"$enable_lto" = x"yes" ; then
   # Make sure that libelf.h and gelf.h are available.
   AC_ARG_WITH(libelf, [  --with-libelf=PATH       Specify prefix directory for the installed libelf package
                           Equivalent to --with-libelf-include=PATH/include
@@ -1777,7 +1768,25 @@ to specify its location.])
   # Flags needed for libelf.
   AC_SUBST(libelflibs)
   AC_SUBST(libelfinc)
-fi
+fi],[if test x"$default_enable_lto" = x"yes" ; then
+    # On non-ELF platforms, LTO must be explicitly enabled.
+    enable_lto=no
+  else
+  # Apart from ELF platforms, only Windows supports LTO so far.  It
+  # would also be nice to check the binutils support, but we don't
+  # have gcc_GAS_CHECK_FEATURE available here.  For now, we'll just
+  # warn during gcc/ subconfigure; unless you're bootstrapping with
+  # -flto it won't be needed until after installation anyway.
+    case $target in
+      *-cygwin*|*-mingw*) ;;
+      *-apple-darwin*) ;;
+      *) if test x"$enable_lto" = x"yes"; then
+	AC_MSG_ERROR([LTO support is not enabled for this target.])
+        fi
+      ;;
+    esac
+  fi
+  default_enable_lto=no])
 
 
 # By default, C is the only stage 1 language.

Re: [PATCH, committed] Re: toplevel out of sync

[Ralf Wildenhues]

* Dave Korn wrote on Wed, May 26, 2010 at 07:36:26AM CEST:
> >>> bcd70fb06d56d9316d49019f5c0a3109def08d39   158763
> >>> a9ed67d000f285282e61aa9b87cc8d992a8731df   158762
> >> 17281d1ee17f204064cfcbcc82089aefa19e3779   159527
> >> 401f30d69e280e18a9581b819376d18786595d3b   159173

>   I've synched across the above-mentioned GCC revisions to the top-level
> configure.ac script in /src, with the following ChangeLog:

Remainders, in reverse chronological order:

2010-05-05  Sebastian Pop  <sebastian.pop@amd.com>

       * configure.ac: Allow all the versions greater than 0.10 of PPL.
       * configure: Regenerated.


2010-04-16  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

       * configure.ac: Check for elf_getshdrstrndx or elf_getshstrndx
       separately.
       * configure: Regenerate.


2010-04-13  Steve Ellcey  <sje@cup.hp.com>

       * configure: Regenerate after change to elf.m4.

config/
2010-04-13  Steve Ellcey  <sje@cup.hp.com>

       * elf.m4: Add hppa[12]*-*-hpux* to list of non-elf platforms.


2010-04-02  Sebastian Pop  <sebastian.pop@amd.com>

       * configure.ac: Add brackets around AC_TRY_COMPILE alternative.
       * configure: Regenerated.


2010-04-02  Sebastian Pop  <sebastian.pop@amd.com>

       * configure.ac: Print "buggy but acceptable" when CLooG
       revision is less than 9.
       * configure: Regenerated.


config/
2010-01-05  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

       * stdint.m4 (GCC_HEADER_STDINT): Don't typedef uint8_t etc. if
       corresponding macros already exist.

Re: [PATCH, committed] Re: toplevel out of sync

[Paolo Bonzini]

> Remainders, in reverse chronological order:

Thanks Ralf. I'm CCing the people.

Paolo

> 2010-05-05  Sebastian Pop  <sebastian.pop@amd.com>
>
>       * configure.ac: Allow all the versions greater than 0.10 of PPL.
>       * configure: Regenerated.
>
>
> 2010-04-16  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
>
>       * configure.ac: Check for elf_getshdrstrndx or elf_getshstrndx
>       separately.
>       * configure: Regenerate.
>
>
> 2010-04-13  Steve Ellcey  <sje@cup.hp.com>
>
>       * configure: Regenerate after change to elf.m4.
>
> config/
> 2010-04-13  Steve Ellcey  <sje@cup.hp.com>
>
>       * elf.m4: Add hppa[12]*-*-hpux* to list of non-elf platforms.
>
>
> 2010-04-02  Sebastian Pop  <sebastian.pop@amd.com>
>
>       * configure.ac: Add brackets around AC_TRY_COMPILE alternative.
>       * configure: Regenerated.
>
>
> 2010-04-02  Sebastian Pop  <sebastian.pop@amd.com>
>
>       * configure.ac: Print "buggy but acceptable" when CLooG
>       revision is less than 9.
>       * configure: Regenerated.
>
>
> config/
> 2010-01-05  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
>
>       * stdint.m4 (GCC_HEADER_STDINT): Don't typedef uint8_t etc. if
>       corresponding macros already exist.