* who can & want to review gengtype patches?
@ 2010-09-07 8:42 Basile Starynkevitch
2010-09-07 8:47 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Basile Starynkevitch @ 2010-09-07 8:42 UTC (permalink / raw)
To: gcc
Cc: jeremie.salvucci, dnovillo, iant, bonzini, laurynas.biveinis,
Ralf.Wildenhues
Hello All,
We (= Basile Starynkevitch + Jeremie Salvucci) have worked on improving gengtype, notably for plugins (the state of gengtype after having parsed all the files is persisted and may be re-used by plugins using GTY without requiring availability of GCC source & build tree.). We also added some other improvements into gengtype.
Laurynas Beveinis kindly took time to review our first set of patches. http://gcc.gnu.org/ml/gcc-patches/2010-09/msg00421.html http://gcc.gnu.org/ml/gcc-patches/2010-09/msg00420.html etc. Some other people, in particular Paolo Bonzini & Ralf Wildenhues, kindly gave comments on minor points (e.g. Makefile.in).
However, I cannot understand who is officially able to OK our patch to gengtype & is willing to take some time to review our patch (I will send an improved & completed version of our patch set very soon, addressing every comment we got so far).
The words gengtype, GTY, garbage do not seem to appear the MAINTAINERS file, so it seems that gengtype & GTY don't have any specialized reviewers.
And gengtype is not a very well written and easy to maintain piece of code, at least in our opinion.
Do we have any chance to have our patch set reviewed (by a person authorised to OK it) and accepted before end of the stage 1 of current trunk 4.6?
With whom should I interact about our gengtype work, and who is authorized to OK it (and have sufficient time to help)?
Cheers!
--
Basile STARYNKEVITCH http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: who can & want to review gengtype patches?
2010-09-07 8:42 who can & want to review gengtype patches? Basile Starynkevitch
@ 2010-09-07 8:47 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2010-09-07 8:47 UTC (permalink / raw)
To: Basile Starynkevitch
Cc: gcc, jeremie.salvucci, dnovillo, iant, laurynas.biveinis,
Ralf.Wildenhues
On 09/07/2010 10:41 AM, Basile Starynkevitch wrote:
> The words gengtype, GTY, garbage do not seem to appear the
> MAINTAINERS file, so it seems that gengtype& GTY don't have any
> specialized reviewers.
>
> And gengtype is not a very well written and easy to maintain piece of
> code, at least in our opinion.
>
> Do we have any chance to have our patch set reviewed (by a person
> authorised to OK it) and accepted before end of the stage 1 of
> current trunk 4.6?
Definitely yes, otherwise that would be a major problem.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-07 8:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-07 8:42 who can & want to review gengtype patches? Basile Starynkevitch
2010-09-07 8:47 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).