From: Richard Henderson <rth@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: gcc@gcc.gnu.org
Subject: Re: VIS2 pattern review
Date: Thu, 13 Oct 2011 22:53:00 -0000 [thread overview]
Message-ID: <4E9744BB.1060903@redhat.com> (raw)
In-Reply-To: <20111013.155559.1663153362558602407.davem@davemloft.net>
On 10/13/2011 12:55 PM, David Miller wrote:
> -(define_insn "<vis3_addsub_ss_insn><vbits>_vis"
> +(define_insn "<vis3_addsub_ss_patname><mode>"
Missing a "3" on the end. Otherwise these look ok.
> Unfortunately, that would involve some ABI changes for the VIS
> builtins. I'm trending towards considering just changing things
> anyways since the VIS intrinsics were next to unusable beforehand.
Why? You can do just about anything you like inside the builtin
expander, including frobbing the modes around.
E.g. for x86, we can't create anything TImode at the user level,
and thus can't expose either TImode or V2TImode operands into the
builtins. So we have the builtins use V2DI or V4DImode and do
some gen_lowpart frobbing while expanding the builtins to rtl.
I don't see why you couldn't accept DImode from the builtin and
transform it to V1DImode in the rtl. Etc.
r~
next prev parent reply other threads:[~2011-10-13 20:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 12:29 Richard Henderson
2011-10-13 19:56 ` David Miller
2011-10-13 20:06 ` David Miller
2011-10-13 20:20 ` Richard Henderson
2011-10-13 22:46 ` David Miller
2011-10-13 22:53 ` Richard Henderson [this message]
2011-10-14 1:50 ` David Miller
2011-10-14 4:38 ` Eric Botcazou
2011-10-14 6:06 ` David Miller
2011-10-14 16:40 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9744BB.1060903@redhat.com \
--to=rth@redhat.com \
--cc=davem@davemloft.net \
--cc=gcc@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).