public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
* IRA changes rules of the game
@ 2011-10-20 14:58 Paulo J. Matos
  2011-10-20 16:21 ` Ulrich Weigand
  2011-10-21 17:15 ` Richard Henderson
  0 siblings, 2 replies; 9+ messages in thread
From: Paulo J. Matos @ 2011-10-20 14:58 UTC (permalink / raw)
  To: gcc

Hi,

And by rules of the game, I mean the semantics of the insn chain.

In comes in the sequence of a previous post where I am splitting a neghi 
operation like this:

op0 = negHI(op1)

expands to:
op0 = op1
op0_HIGH = xorQI(op0_HIGH, -1)
parallel(
    op0_LOW = negQI(op0_LOW)
    op0_HIGH = add(op0_HIGH, CARRY_FLAG)
   )

The parallel is then split after reload (due to flag read/write 
constraints).
In the end I expect something like:
xor op0_HIGH, -1
nadd op0_LOW, 0 // returns -(op0_LOW + 0)
addc op0_HIGH, 0 // here the carry is the one generated by nadd

The rules are:
(define_expand "neghi2"
   [(set (match_operand:HI 0 "register_operand")
         (neg:HI (match_operand:HI 1 "general_operand")))
    (clobber (reg:CC RCC))]
   ""
{
      rtx op0_low = gen_lowpart(QImode, operands[0]);
      rtx op0_high = gen_highpart(QImode, operands[0]);

      emit_move_insn(operands[0], operands[1]);
      emit_insn(gen_one_cmplqi2(op0_high, op0_high));
      emit_insn(gen_neghi_internal(op0_low, op0_high));
      DONE;
})

(define_insn_and_split "neghi_internal"
    [(set (match_operand:QI 0 "register_operand" "=c")
          (neg:QI (match_dup 0)))
     (set (match_operand:QI 1 "register_operand" "=c")
          (plus:QI
            (plus:QI
              (ltu:QI (neg:QI (match_dup 0)) (const_int 0))
              (match_dup 1))
            (const_int 0)))
     (clobber (reg:CC RCC))]
   ""
   "#"
   "reload_completed"
   [(const_int 0)]
{
   emit_insn(gen_negqi2(operands[0], operands[0]));
   emit_insn(gen_addc_internal(operands[1], operands[1], const0_rtx));
   DONE;
})


Everything looks ok until IRA:

(insn 11 81 12 3 (parallel [
             (set (reg:QI 81)
                 (xor:QI (reg:QI 73 [ uu ])
                     (const_int -1 [0xffffffff])))
             (clobber (reg:CC 13 CC))
         ]) _divdi3.i:76 37 {xorqi3}
      (expr_list:REG_DEAD (reg:QI 73 [ uu ])
         (expr_list:REG_UNUSED (reg:CC 13 CC)
             (nil))))

(insn 12 11 82 3 (parallel [
             (set (reg:QI 82 [+1 ])
                 (neg:QI (reg:QI 82 [+1 ])))
             (set (reg:QI 81)
                 (plus:QI (plus:QI (ltu:QI (neg:QI (reg:QI 82 [+1 ]))
                             (const_int 0 [0]))
                         (reg:QI 81))
                     (const_int 0 [0])))
             (clobber (reg:CC 13 CC))
         ]) _divdi3.i:76 46 {neghi_internal}
      (expr_list:REG_UNUSED (reg:CC 13 CC)
         (nil)))

The problem is that after IRA we have something like:
(insn 11 111 112 3 (parallel [
             (set (reg:QI 0 AH)
                 (xor:QI (reg:QI 0 AH)
                     (const_int -1 [0xffffffff])))
             (clobber (reg:CC 13 CC))
         ]) _divdi3.i:76 37 {xorqi3}
      (nil))

(insn 112 11 12 3 (parallel [
             (set (reg:QI 7 @H'fff8 [81])
                 (reg:QI 0 AH))
             (clobber (reg:CC 13 CC))
         ]) _divdi3.i:76 6 {*movqi}
      (nil))

(insn 12 112 82 3 (parallel [
             (set (reg:QI 1 AL [orig:82+1 ] [82])
                 (neg:QI (reg:QI 1 AL [orig:82+1 ] [82])))
             (set (reg:QI 3 X)
                 (plus:QI (plus:QI (ltu:QI (neg:QI (reg:QI 1 AL 
[orig:82+1 ] [82]))
                             (const_int 0 [0]))
                         (reg:QI 3 X))
                     (const_int 0 [0])))
             (clobber (reg:CC 13 CC))
         ]) _divdi3.i:76 46 {neghi_internal}
      (nil))


I actually expected reg 81 to be the same in insn 11 and insn 12. 
Instead IRA, puts reg 81 in AH, then moves it into FFF8 and uses X in 
insn 12 where reg 81 was expected. This is definitely not correct since 
the result of the xor won't be an argument to the add with carry (addc) 
and the final result is incorrect.

Am I missing something or something here is broken?

Cheers,

-- 
PMatos

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-10-21 15:30 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-20 14:58 IRA changes rules of the game Paulo J. Matos
2011-10-20 16:21 ` Ulrich Weigand
2011-10-20 17:50   ` Joern Rennecke
2011-10-20 18:18     ` Paulo J. Matos
2011-10-21 13:11       ` Paolo Bonzini
2011-10-21 14:15         ` Paulo J. Matos
2011-10-21 14:32           ` Joern Rennecke
2011-10-20 18:18   ` Paulo J. Matos
2011-10-21 17:15 ` Richard Henderson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).