From: Jeff Law <law@redhat.com>
To: Richard Biener <rguenther@suse.de>, gcc@gcc.gnu.org
Subject: Re: [RFC] Change PCH "checksum"
Date: Fri, 22 Feb 2019 15:47:00 -0000 [thread overview]
Message-ID: <4e1e43f2-f944-7067-d4ba-71b42ae3f2c8@redhat.com> (raw)
In-Reply-To: <alpine.LSU.2.20.1902221220200.23386@zhemvz.fhfr.qr>
On 2/22/19 4:29 AM, Richard Biener wrote:
>
> GCC builds are currently not reproducible because for one the checksum
> we compute for PCH purposes (by genchecksum) nowaways includes checksums
> of archives (since we switched from checksumming a dummy executable
> to checksumming object files). That includes dates (unless built with
> -D which we don't do).
>
> Then later we switched to do thin archives so for example libbackend.a
> we checksum doesn't contain the actual code anymore...
>
> A pragmatic approach to "fix" things would be to just checksum
> gtype-desc.o which should have enough state to cover PCH dependences
> if I understand the workings correctly (patch below - a single
> checksum would suffice so more simplifications are possible).
>
> Another solution working on ELF systems with build-id support is
> simply forgo checksumming anything and rely on the executable
> build-id instead (pat^whack below as well).
>
> Does anybody think that just checksumming gtype-desc.o is a
> degradation over the current state (which checksums thin archives)?
>
> Thanks,
> Richard.
>
> 2019-02-22 Richard Biener <rguenther@suse.de>
>
> c/
> * Make-lang.in (cc1-checksum.c): Checksum only gtype-desc.o.
>
> cp/
> * Make-lang.in (cc1plus-checksum.c): Checksum only gtype-desc.o.
>
> objc/
> * Make-lang.in (cc1obj-checksum.c): Checksum only gtype-desc.o.
>
> objcp/
> * Make-lang.in (cc1objplus-checksum.c): Checksum only gtype-desc.o.
ISTM that gtype-desc effectively describes the structure of all the GC data.
Given we're summing the thin-archives, we're already missing things like
a change in static data. So I don't think your patch is a degradation
over the current state. I'm not 100% sure the current state is correct
though :-)
jeff
next prev parent reply other threads:[~2019-02-22 15:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 11:29 Richard Biener
2019-02-22 15:47 ` Jeff Law [this message]
2019-02-22 16:03 ` Jakub Jelinek
2019-02-22 17:12 ` Richard Biener
2019-02-25 8:42 ` Mark Wielaard
2019-02-26 8:33 ` Richard Biener
2019-02-26 11:40 ` Mark Wielaard
2019-02-26 14:36 ` Richard Biener
2019-02-26 14:49 ` Richard Biener
2019-02-26 16:18 ` Michael Matz
2019-02-26 17:02 ` Richard Biener
2019-02-27 16:56 ` Nathan Sidwell
2019-02-26 17:03 ` Mark Wielaard
2019-02-26 17:13 ` Richard Biener
2019-02-26 17:35 ` Mark Wielaard
2019-02-27 13:12 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e1e43f2-f944-7067-d4ba-71b42ae3f2c8@redhat.com \
--to=law@redhat.com \
--cc=gcc@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).