From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 59AAE3858D33 for ; Thu, 16 Feb 2023 08:10:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 59AAE3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676535041; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ddj2klAHxzV7c+uxYa6jc8HgK7kHNIoapW0W3lZvbIM=; b=AvNUJP6rIuvBOY5ANxnlABUPdc0f8ToYjRE61rg83MAZxpASa0wvGr7ADGYdIuwBJtTiGp sAhnEKG0ZS2ngleQbg022vPwoKHir+o/0eqEinKxF40TH/FhpBo5BCA8kk/SklwtGizjQa NA8L6Cwwf1203iv8PrttY7JbTBy0vWg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-280-k7Bz4wcCOzG07m6iBreamw-1; Thu, 16 Feb 2023 03:10:38 -0500 X-MC-Unique: k7Bz4wcCOzG07m6iBreamw-1 Received: by mail-wm1-f70.google.com with SMTP id t18-20020a05600c451200b003e1f2de4b2bso2717808wmo.6 for ; Thu, 16 Feb 2023 00:10:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ddj2klAHxzV7c+uxYa6jc8HgK7kHNIoapW0W3lZvbIM=; b=6IUZatl98gE26vKdwubl8p7gkZ8S6sZCrq4jDyBEDI7uP/Xer0MXl3Y6xLEX+640l7 +tGTCm12FHxgJxslfX52l9TmIxPkSX2n58M6XqKInDuS3SSXSAcnLbhflVLXEYe/TvxD ExXszJCpFGakjFW4g2l81sO/QAVYXmrqF3Cdb5RHNZSsNxQstY2kNtYIq7PrNjuOCYab x6DoXLPfNyeeAvQwmSbH7Nwe8OriP8wBt8ysmwLbOnE4WUzzlEkCfLfl/zwbY2NGX1Sc eBjLIw0s6yaLJYPq/AmGbJWGz4pmOAxkaqTNzxNwfEeF01qHY0xAFGiw7yK3s5WL9Fxr cq9A== X-Gm-Message-State: AO0yUKUYT4T9VqZzW9jWPhMGGpEM1fDTboJ0pY1C+WWh6e9VOdvkd4C5 iFfkXJdaK1egqjx11248w/HfHQeUdu6364DibSB+lfbenJsjfUKT4UPEgWnivr4AzaryfeFLpve 8WwIu3B0= X-Received: by 2002:a05:6000:1152:b0:2c5:52f5:c63b with SMTP id d18-20020a056000115200b002c552f5c63bmr4103748wrx.11.1676535037890; Thu, 16 Feb 2023 00:10:37 -0800 (PST) X-Google-Smtp-Source: AK7set8U3ceZ8rPunqPp5tuG2qz0kOovKDPv/2wfgMNIa3TwEzpdd1Doa09QC6C6ZOPRJj1nXhUmsQ== X-Received: by 2002:a05:6000:1152:b0:2c5:52f5:c63b with SMTP id d18-20020a056000115200b002c552f5c63bmr4103729wrx.11.1676535037571; Thu, 16 Feb 2023 00:10:37 -0800 (PST) Received: from [192.168.1.201] ([139.47.42.170]) by smtp.gmail.com with ESMTPSA id d3-20020adff2c3000000b002c56046a3b5sm832087wrp.53.2023.02.16.00.10.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Feb 2023 00:10:37 -0800 (PST) Message-ID: <4f6718af-e17a-41ef-a886-f45e4ac3d7a4@redhat.com> Date: Thu, 16 Feb 2023 09:10:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: get_range_query vs NULL argument To: Richard Biener , Andrew MacLeod Cc: Andrew Pinski , GCC Mailing List References: <009a0ac2-0626-c21c-c0f9-4d2e8daa66b3@redhat.com> From: Aldy Hernandez In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/16/23 08:57, Richard Biener wrote: > On Wed, Feb 15, 2023 at 11:31 PM Andrew MacLeod via Gcc wrote: >> >> >> On 2/15/23 14:50, Andrew Pinski wrote: >>> Hi, >>> While fixing PR 108354, I came across that >>> ssa_name_has_boolean_range calls get_range_query with cfun as the >>> argument but sometimes while in IPA passes cfun is currently nullptr. >>> The question should we check the argument before calling >>> get_range_query or is it a valid thing to call it with a nullptr (and >>> have it return global_ranges in that case)? >> >> That might be ok... personally I see nothing wrong with: >> >> diff --git a/gcc/value-query.h b/gcc/value-query.h >> index 63878968118..2d7bf8fcf33 100644 >> --- a/gcc/value-query.h >> +++ b/gcc/value-query.h >> @@ -140,7 +140,7 @@ get_global_range_query () >> ATTRIBUTE_RETURNS_NONNULL inline range_query * >> get_range_query (const struct function *fun) >> { >> - return fun->x_range_query ? fun->x_range_query : &global_ranges; >> + return (fun && fun->x_range_query) ? fun->x_range_query : &global_ranges; >> } >> >> // Query the global range of NAME in function F. Default to cfun. >> >> >> The client is probably going to do that anyway. > > But if there's no 'fun', what is 'global_ranges' initialized for? Or > is 'global_ranges' > usable in IPA context? If there is no fun, global_ranges will just return what get_range_info() used to return (i.e. SSA_NAME_RANGE_INFO). Aldy