From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id C7F9E3877022 for ; Mon, 21 Jun 2021 06:42:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C7F9E3877022 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: oqoBeYw/pCgCJYDq+yl8rIW9EmEfdcpZx3bQz8HnX5M4ktqtmo3f/Go4YL1U20RZMJJ24xk7B4 fOIMGeq5oOv2LdZau0SKVwNrE96Dgm5IEtKGa7wT3ILnWiLx4spnHtrViHvOqcg1OJqIbbBbyJ djmV1USTrFJZlMzK2naYjDPy4eqh5tSS+mmmZEZWfsx6SvBAXkg8Rq8qREHB5c9lRg5VytSLWp JrB+Duy1fBd1D6xc4jhGjqAxfzYQEsoVxLlXIQ/NPnAQmK7ur166gaKQEGzUS16lYBXQ4gXltS Mp4= X-IronPort-AV: E=Sophos;i="5.83,289,1616486400"; d="scan'208";a="62802230" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 20 Jun 2021 22:42:27 -0800 IronPort-SDR: JBDdT/aJIWJjzTjzDxh0YMR969W1RVxqQmrT7wF5Nm2bGWb5EtuYQRL5bnc9JrESD1xiny0DJT tUzptmWo+fqcNOE9etm2VpwyFqsYVlQ0vynJjmY7gv2SGC+zTQQ3LiMOQ0IO5sGwep9fLl/ePA W8sPB8q9sdMGW3vZp+GtQHfbqVYmsbziLiuWvYGl/OJZQpqhDcFrBVPa968gXkOecXmI+lj+T8 M9vou27BMmRxnt3aRzry9QMS4y1OXJ53dB5ChNGPNALEj+Q/XArXDnQTofFzmIQC4PsJzrrhFZ 4us= Subject: Re: [Patch] contrib/mklog.py: Improve PR handling (was: git gcc-commit-mklog doesn't extract PR number to ChangeLog) To: Jason Merrill CC: Richard Earnshaw , Jakub Jelinek , Joseph Myers , =?UTF-8?Q?Martin_Li=c5=a1ka?= , gcc Mailing List , Jonathan Wakely References: <71b4a023-efb2-6c6a-9ced-93cce7c96540@gmail.com> <013d6727-4008-b4b5-b793-c782a5ba8e10@redhat.com> <916af0f3-0877-e977-6b6c-899edec8e706@foss.arm.com> <20210617172129.GH7746@tucnak> <16f70de7-8324-e249-dbd8-605022066d12@foss.arm.com> <070f57d5-1496-50f4-1144-3ff2e75a4460@codesourcery.com> From: Tobias Burnus Message-ID: <501b0e4f-c184-899b-701b-e370e377c347@codesourcery.com> Date: Mon, 21 Jun 2021 08:42:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-05.mgc.mentorg.com (139.181.222.5) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jun 2021 06:42:30 -0000 On 18.06.21 16:41, Jason Merrill wrote: > > * Being able to specify the PR numbers on the command line in additio= n > (currently, they are only extracted from the testsuite patches) > > > This bit seems unnecessary to me, since we want the commit to include > tests that identify the PR. I full hearty disagree! > Martin Sebor's patch to extract the PR number from the testcase > filename, as an alternative to a comment, should be enough. Regarding the PR from the filename, are we only talking about new files =E2=80=93 or about modifications to old files? For new files, together with -p it seems to be useful; for old files, I think there will be more spurious/false PRs than useful/right PRs. Looking through the last few commits, in all of the following cases the -b would be useful =E2=80=94 and I do regard the commits messages are sensible: * cc9c94d43dcfa98436152af9c00f011e9dab25f6 PR libstdc++/100387 added testsuite/25_algorithms/minmax/constrained.cc (etc.) but file neither has a pr... name nor contains a PR line (BTW: The fix is not primarily for the PR but fixes it as, a side effect; hence, not having a PR line makes sense) * 870b674f72d4894b94efa61764fd87ecec29ffde 'ranger' - removes a datastructure (no testcase but also does not make sense here) * 17a4bee01c3b29c5ccdd39f34384521e5d44135b Fixes an ICE for one testcase (but of course does not add a new testcase or modify an existing one.) * 76e990fd211cbb20bf74ce074eb8b2d7b096d3b7 fix a bootstrap issue (found with the GCC 11 backport). Those are all commits between last Friday and today. Hence, I do believe it makes sense to be able to specify the PR on the command line =E2=80=94 besides obtaining it from file names. Tobias ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 M=C3=BCnchen R= egistergericht M=C3=BCnchen HRB 106955, Gesch=C3=A4ftsf=C3=BChrer: Thomas H= eurung, Frank Th=C3=BCrauf