From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailrelay4-3.pub.mailoutpod1-cph3.one.com (mailrelay4-3.pub.mailoutpod1-cph3.one.com [46.30.212.13]) by sourceware.org (Postfix) with ESMTPS id AA52B3858D37 for ; Fri, 27 Nov 2020 11:08:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AA52B3858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=carewolf.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=linux@carewolf.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=carewolf.com; s=20191106; h=content-type:content-transfer-encoding:mime-version:references:in-reply-to: message-id:date:subject:cc:to:from:from; bh=iEtME4c+NAx3vLQvere1n6ORv4FbRCPgdFIUSzfTEh8=; b=WeON0e1QewXSPWOM+wqaoVD4yWyrfoLmkD26ZZsNHpTrG6ul+tfrJyqt8jtVt0ujTmea/PDnMdL1o TUxksoMLBv+a1GbNjH1ygpKqQfHKWkkePbWopDhmnX4WVlpG1AY8lkLXVsTDJnvJkFC5C63PW1phwi /La1Qt7kIaKZekfAYNB0PmSkIMAHYUpC7T209E8EOc9fFFrz/z+OZvkdldTFMMIJ5EGyqNp74Fcqhx NFYUtWSt6n1IV/3U5qEOynpHUQN4FBVAW0Hz4NuH8zVqudZSKypzVgVVIPcghKkXpSYPYtemS7BicL yTtdrzl2I80ohnTrwqbkOmTRsEZtNQA== X-HalOne-Cookie: f19db73d0f2dd17f3f81d2ea4e4abe4f6206ff6d X-HalOne-ID: de32f793-30a0-11eb-a8de-d0431ea8bb10 Received: from twilight.localnet (unknown [158.181.74.204]) by mailrelay4.pub.mailoutpod1-cph3.one.com (Halon) with ESMTPSA id de32f793-30a0-11eb-a8de-d0431ea8bb10; Fri, 27 Nov 2020 11:08:25 +0000 (UTC) From: Allan Sandfeld Jensen To: libstdc++@gcc.gnu.org, gcc@gcc.gnu.org Cc: gcc@gcc.gnu.org, Jonathan Wakely Subject: Re: [RFC] Increase libstdc++ line length to 100(?) columns Date: Fri, 27 Nov 2020 12:08:24 +0100 Message-ID: <5416783.DvuYhMxLoT@twilight> In-Reply-To: <20201126235057.GQ1312820@redhat.com> References: <20201126235057.GQ1312820@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2020 11:08:29 -0000 On Freitag, 27. November 2020 00:50:57 CET Jonathan Wakely via Gcc wrote: > I've touched on the subject a few times, e.g. > https://gcc.gnu.org/pipermail/gcc/2019-December/230993.html > and https://gcc.gnu.org/pipermail/gcc/2019-December/231013.html > > Libstdc++ code is indented by 2 columns for the enclosing namespace, > usually another two for being in a template, and is full of __ > prefixes for reserved names. On top of that, modern C++ declarations > are *noisy* (template head, requires-clause, noexcept-specifier, often > 'constexpr' or 'inline' and 'explicit', and maybe some attributes. > > All that gets hard to fit in 80 columns without compromising > readability with line breaks in unnatural places. > > Does anybody object to raising the line length for libstdc++ code > (not the rest of GCC) to 100 columns? > If you _do_ change it. I would suggest changing it to 120, which is next common step for a lot of C++ projects. Often also with an allowance for overruns if that makes the code cleaner. 'Allan