From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.hazardy.de (mail.hazardy.de [78.94.181.132]) by sourceware.org (Postfix) with ESMTPS id 411363858D33; Mon, 20 Nov 2023 19:56:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 411363858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hazardy.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hazardy.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 411363858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=78.94.181.132 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700510207; cv=none; b=X5yhQGzvuVDfuYBI5ElUuqLday9wP8PnEtucv8Qtl5YvQ5je1ZRqQfHl6k+3fpv/3dVuNjO9B+azN0XW2/tvnHjgu5C+I398qHnL3lL3KhpliZZeyzIKXFDnwm5mCCyt1nkI3Kd+akRQ6Q3wyCBFSyMfPuBPPMZipRKUI0vGVtw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700510207; c=relaxed/simple; bh=c8PEkDTFabuyf0EFsUhAYl2EPR13v497G2XxrOso14U=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=xkmGvz87xugZ7SuffILiPk6BlrGR1SNTYIGn/0FE7yHOAvX7ojqn9+UqsAuoBvSUa3Q9njIMp/v5neWzOB6bK0dXfoEkf7yf6u6KR1irzDsjn7gWrDj3YMepUzkdrtQJLbS/1swIkGZodqyZnlXu87wmYgGWI039tEfSx57VHWY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.0.1.129] (hades.hazardy.de [10.0.1.129]) by mail.hazardy.de (Postfix) with ESMTPSA id DCDEA7001EB; Mon, 20 Nov 2023 20:56:43 +0100 (CET) Content-Type: multipart/mixed; boundary="------------UUB9009ZTpNBzdySEdTyHLyX" Message-ID: <542460b4-0647-1f1e-a160-9f81d03279cb@hazardy.de> Date: Mon, 20 Nov 2023 20:56:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 2/4] libbacktrace: detect executable path on windows Content-Language: de-DE, en-US To: Ian Lance Taylor Cc: Eli Zaretskii , gcc-patches@gcc.gnu.org, gcc@gcc.gnu.org References: <20230120105409.54949-1-gcc@hazardy.de> <20230120105409.54949-2-gcc@hazardy.de> <83tu0ggjro.fsf@gnu.org> <83o7qnho2o.fsf@gnu.org> <83edrjhkfa.fsf@gnu.org> <1e335b3d-6e49-1d00-57cc-76e941b2819d@hazardy.de> From: =?UTF-8?Q?Bj=c3=b6rn_Sch=c3=a4pers?= In-Reply-To: X-Spam-Status: No, score=-14.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------UUB9009ZTpNBzdySEdTyHLyX Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, this is what I'm using with GCC 12 and 13 on my windows machines, rebased onto the current HEAD. Kind regards, Björn. Am 06.02.2023 um 01:22 schrieb Ian Lance Taylor: > On Sun, Feb 5, 2023 at 1:21 AM Björn Schäpers wrote: >> >> Am 24.01.2023 um 19:32 schrieb Ian Lance Taylor: >>> On Tue, Jan 24, 2023 at 10:12 AM Eli Zaretskii via Gcc-patches >>> wrote: >>>> >>>>> From: Ian Lance Taylor >>>>> Date: Tue, 24 Jan 2023 09:58:10 -0800 >>>>> Cc: gcc@hazardy.de, gcc-patches@gcc.gnu.org, gcc@gcc.gnu.org >>>>> >>>>> I'd rather that the patch look like the appended. Can someone with a >>>>> Windows system test to see what that builds and passes the tests? >>>> >>>> ENOPATCH >>> >>> Gah. >>> >>> Ian >>> >> That seems to be my original patch, right? That one I have tested (and >> am actually using) on x86 and x64 windows. > > It's very similar but I changed the windows_get_executable_path function. > > Ian --------------UUB9009ZTpNBzdySEdTyHLyX Content-Type: text/plain; charset=UTF-8; name="0001-libbacktrace-detect-executable-path-on-windows.patch" Content-Disposition: attachment; filename*0="0001-libbacktrace-detect-executable-path-on-windows.patch" Content-Transfer-Encoding: base64 RnJvbSBlMGVlNThiNzFmNzI2NjA2MjA1YWExZjAxNjhhNzI0ODU5MTYyYzIxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Qmo9QzM9QjZybj0yMFNjaD1DMz1B NHBlcnM/PSA8YmpvZXJuQGhhemFyZHkuZGU+CkRhdGU6IFN1biwgMzAgQXByIDIwMjMgMjM6 NDg6MTggKzAyMDAKU3ViamVjdDogW1BBVENIIDEvM10gbGliYmFja3RyYWNlOiBkZXRlY3Qg ZXhlY3V0YWJsZSBwYXRoIG9uIHdpbmRvd3MKTUlNRS1WZXJzaW9uOiAxLjAKQ29udGVudC1U eXBlOiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04CkNvbnRlbnQtVHJhbnNmZXItRW5jb2Rp bmc6IDhiaXQKClRlc3RlZCBvbiB4ODZfNjQtbGludXggd2l0aCBHQ0MgMTIsIGk2ODYtdzY0 LW1pbmd3MzIgYW5kCng4Nl82NC13NjQtbWluZ3czMiB3aXRoIEdDQyAxMiAmIDEzLiBUaGlz IHBhdGNoIGlzIHJlYmFzZWQgb250byB0aGUKY3VycmVudCBIRUFELgoKLS0gPjggLS0KCgkq IGNvbmZpZ3VyZS5hYzogQWRkIGEgY2hlY2sgZm9yIHdpbmRvd3MuaC4KCSogY29uZmlndXJl LCBjb25maWcuaC5pbjogUmVnZW5lcmF0ZS4KCSogZmlsZWxpbmUuYzogQWRkIHdpbmRvd3Nf Z2V0X2V4ZWN1dGFibGVfcGF0aC4KCSogZmlsZWxpbmUuYyAoZmlsZWxpbmVfaW5pdGlhbGl6 ZSk6IEFkZCBhIHBhc3MgdXNpbmcKCXdpbmRvd3NfZ2V0X2V4ZWN1dGFibGVfcGF0aC4KClNp Z25lZC1vZmYtYnk6IEJqw7ZybiBTY2jDpHBlcnMgPGJqb2VybkBoYXphcmR5LmRlPgotLS0K IGxpYmJhY2t0cmFjZS9jb25maWcuaC5pbiAgfCAgMyArKysKIGxpYmJhY2t0cmFjZS9jb25m aWd1cmUgICAgfCAxMyArKysrKysrKysrKwogbGliYmFja3RyYWNlL2NvbmZpZ3VyZS5hYyB8 ICAyICsrCiBsaWJiYWNrdHJhY2UvZmlsZWxpbmUuYyAgIHwgNDkgKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKystCiA0IGZpbGVzIGNoYW5nZWQsIDY2IGluc2VydGlv bnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9saWJiYWNrdHJhY2UvY29uZmln LmguaW4gYi9saWJiYWNrdHJhY2UvY29uZmlnLmguaW4KaW5kZXggYTRmNWJkZGRkZjYuLmVl MjYxNjMzNWM3IDEwMDY0NAotLS0gYS9saWJiYWNrdHJhY2UvY29uZmlnLmguaW4KKysrIGIv bGliYmFja3RyYWNlL2NvbmZpZy5oLmluCkBAIC0xMDQsNiArMTA0LDkgQEAKIC8qIERlZmlu ZSB0byAxIGlmIHlvdSBoYXZlIHRoZSA8dW5pc3RkLmg+IGhlYWRlciBmaWxlLiAqLwogI3Vu ZGVmIEhBVkVfVU5JU1REX0gKIAorLyogRGVmaW5lIHRvIDEgaWYgeW91IGhhdmUgdGhlIDx3 aW5kb3dzLmg+IGhlYWRlciBmaWxlLiAqLworI3VuZGVmIEhBVkVfV0lORE9XU19ICisKIC8q IERlZmluZSBpZiAtbHogaXMgYXZhaWxhYmxlLiAqLwogI3VuZGVmIEhBVkVfWkxJQgogCmRp ZmYgLS1naXQgYS9saWJiYWNrdHJhY2UvY29uZmlndXJlIGIvbGliYmFja3RyYWNlL2NvbmZp Z3VyZQppbmRleCAwY2NjMDYwOTAxZC4uN2FkZTk2NmI1NGQgMTAwNzU1Ci0tLSBhL2xpYmJh Y2t0cmFjZS9jb25maWd1cmUKKysrIGIvbGliYmFja3RyYWNlL2NvbmZpZ3VyZQpAQCAtMTM1 MDksNiArMTM1MDksMTkgQEAgJGFzX2VjaG8gIiNkZWZpbmUgSEFWRV9MT0FEUVVFUlkgMSIg Pj5jb25mZGVmcy5oCiAKIGZpCiAKK2ZvciBhY19oZWFkZXIgaW4gd2luZG93cy5oCitkbyA6 CisgIGFjX2ZuX2NfY2hlY2tfaGVhZGVyX21vbmdyZWwgIiRMSU5FTk8iICJ3aW5kb3dzLmgi ICJhY19jdl9oZWFkZXJfd2luZG93c19oIiAiJGFjX2luY2x1ZGVzX2RlZmF1bHQiCitpZiB0 ZXN0ICJ4JGFjX2N2X2hlYWRlcl93aW5kb3dzX2giID0geHllczsgdGhlbiA6CisgIGNhdCA+ PmNvbmZkZWZzLmggPDxfQUNFT0YKKyNkZWZpbmUgSEFWRV9XSU5ET1dTX0ggMQorX0FDRU9G CisKK2ZpCisKK2RvbmUKKworCiAjIENoZWNrIGZvciB0aGUgZmNudGwgZnVuY3Rpb24uCiBp ZiB0ZXN0IC1uICIke3dpdGhfdGFyZ2V0X3N1YmRpcn0iOyB0aGVuCiAgICBjYXNlICIke2hv c3R9IiBpbgpkaWZmIC0tZ2l0IGEvbGliYmFja3RyYWNlL2NvbmZpZ3VyZS5hYyBiL2xpYmJh Y2t0cmFjZS9jb25maWd1cmUuYWMKaW5kZXggNzFjZDUwZjhjZGYuLjAwYWNiNDJlYjZkIDEw MDY0NAotLS0gYS9saWJiYWNrdHJhY2UvY29uZmlndXJlLmFjCisrKyBiL2xpYmJhY2t0cmFj ZS9jb25maWd1cmUuYWMKQEAgLTM3OSw2ICszNzksOCBAQCBpZiB0ZXN0ICIkaGF2ZV9sb2Fk cXVlcnkiID0gInllcyI7IHRoZW4KICAgQUNfREVGSU5FKEhBVkVfTE9BRFFVRVJZLCAxLCBb RGVmaW5lIGlmIEFJWCBsb2FkcXVlcnkgaXMgYXZhaWxhYmxlLl0pCiBmaQogCitBQ19DSEVD S19IRUFERVJTKHdpbmRvd3MuaCkKKwogIyBDaGVjayBmb3IgdGhlIGZjbnRsIGZ1bmN0aW9u LgogaWYgdGVzdCAtbiAiJHt3aXRoX3RhcmdldF9zdWJkaXJ9IjsgdGhlbgogICAgY2FzZSAi JHtob3N0fSIgaW4KZGlmZiAtLWdpdCBhL2xpYmJhY2t0cmFjZS9maWxlbGluZS5jIGIvbGli YmFja3RyYWNlL2ZpbGVsaW5lLmMKaW5kZXggMGU1NjBiNDRlN2EuLjI4ZDc1MmUyNjI1IDEw MDY0NAotLS0gYS9saWJiYWNrdHJhY2UvZmlsZWxpbmUuYworKysgYi9saWJiYWNrdHJhY2Uv ZmlsZWxpbmUuYwpAQCAtNDcsNiArNDcsMTggQEAgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1B R0UuICAqLwogI2luY2x1ZGUgPG1hY2gtby9keWxkLmg+CiAjZW5kaWYKIAorI2lmZGVmIEhB VkVfV0lORE9XU19ICisjaWZuZGVmIFdJTjMyX01FQU5fQU5EX0xFQU4KKyNkZWZpbmUgV0lO MzJfTUVBTl9BTkRfTEVBTgorI2VuZGlmCisKKyNpZm5kZWYgTk9NSU5NQVgKKyNkZWZpbmUg Tk9NSU5NQVgKKyNlbmRpZgorCisjaW5jbHVkZSA8d2luZG93cy5oPgorI2VuZGlmCisKICNp bmNsdWRlICJiYWNrdHJhY2UuaCIKICNpbmNsdWRlICJpbnRlcm5hbC5oIgogCkBAIC0xNjUs NiArMTc3LDM0IEBAIG1hY2hvX2dldF9leGVjdXRhYmxlX3BhdGggKHN0cnVjdCBiYWNrdHJh Y2Vfc3RhdGUgKnN0YXRlLAogCiAjZW5kaWYgLyogIUhBVkVfREVDTF9fUEdNUFRSICovCiAK KyNpZmRlZiBIQVZFX1dJTkRPV1NfSAorCitzdGF0aWMgY2hhciAqCit3aW5kb3dzX2dldF9l eGVjdXRhYmxlX3BhdGggKGNoYXIgKmJ1ZiwgYmFja3RyYWNlX2Vycm9yX2NhbGxiYWNrIGVy cm9yX2NhbGxiYWNrLAorCQkJICAgICB2b2lkICpkYXRhKQoreworICBzaXplX3QgZ290Owor ICBpbnQgZXJyb3I7CisKKyAgZ290ID0gR2V0TW9kdWxlRmlsZU5hbWVBIChOVUxMLCBidWYs IE1BWF9QQVRIIC0gMSk7CisgIGVycm9yID0gR2V0TGFzdEVycm9yICgpOworICBpZiAoZ290 ID09IDAKKyAgICAgIHx8IChnb3QgPT0gTUFYX1BBVEggLSAxICYmIGVycm9yID09IEVSUk9S X0lOU1VGRklDSUVOVF9CVUZGRVIpKQorICAgIHsKKyAgICAgIGVycm9yX2NhbGxiYWNrIChk YXRhLAorCQkgICAgICAiY291bGQgbm90IGdldCB0aGUgZmlsZW5hbWUgb2YgdGhlIGN1cnJl bnQgZXhlY3V0YWJsZSIsCisJCSAgICAgIGVycm9yKTsKKyAgICAgIHJldHVybiBOVUxMOwor ICAgIH0KKyAgcmV0dXJuIGJ1ZjsKK30KKworI2Vsc2UgLyogIWRlZmluZWQgKEhBVkVfV0lO RE9XU19IKSAqLworCisjZGVmaW5lIHdpbmRvd3NfZ2V0X2V4ZWN1dGFibGVfcGF0aChidWYs IGVycm9yX2NhbGxiYWNrLCBkYXRhKSBOVUxMCisKKyNlbmRpZiAvKiAhZGVmaW5lZCAoSEFW RV9XSU5ET1dTX0gpICovCisKIC8qIEluaXRpYWxpemUgdGhlIGZpbGVsaW5lIGluZm9ybWF0 aW9uIGZyb20gdGhlIGV4ZWN1dGFibGUuICBSZXR1cm5zIDEKICAgIG9uIHN1Y2Nlc3MsIDAg b24gZmFpbHVyZS4gICovCiAKQEAgLTE3OCw3ICsyMTgsMTEgQEAgZmlsZWxpbmVfaW5pdGlh bGl6ZSAoc3RydWN0IGJhY2t0cmFjZV9zdGF0ZSAqc3RhdGUsCiAgIGludCBjYWxsZWRfZXJy b3JfY2FsbGJhY2s7CiAgIGludCBkZXNjcmlwdG9yOwogICBjb25zdCBjaGFyICpmaWxlbmFt ZTsKKyNpZmRlZiBIQVZFX1dJTkRPV1NfSAorICBjaGFyIGJ1ZltNQVhfUEFUSF07CisjZWxz ZQogICBjaGFyIGJ1Zls2NF07CisjZW5kaWYKIAogICBpZiAoIXN0YXRlLT50aHJlYWRlZCkK ICAgICBmYWlsZWQgPSBzdGF0ZS0+ZmlsZWxpbmVfaW5pdGlhbGl6YXRpb25fZmFpbGVkOwpA QCAtMjAyLDcgKzI0Niw3IEBAIGZpbGVsaW5lX2luaXRpYWxpemUgKHN0cnVjdCBiYWNrdHJh Y2Vfc3RhdGUgKnN0YXRlLAogCiAgIGRlc2NyaXB0b3IgPSAtMTsKICAgY2FsbGVkX2Vycm9y X2NhbGxiYWNrID0gMDsKLSAgZm9yIChwYXNzID0gMDsgcGFzcyA8IDk7ICsrcGFzcykKKyAg Zm9yIChwYXNzID0gMDsgcGFzcyA8IDEwOyArK3Bhc3MpCiAgICAgewogICAgICAgaW50IGRv ZXNfbm90X2V4aXN0OwogCkBAIC0yMzksNiArMjgzLDkgQEAgZmlsZWxpbmVfaW5pdGlhbGl6 ZSAoc3RydWN0IGJhY2t0cmFjZV9zdGF0ZSAqc3RhdGUsCiAJY2FzZSA4OgogCSAgZmlsZW5h bWUgPSBtYWNob19nZXRfZXhlY3V0YWJsZV9wYXRoIChzdGF0ZSwgZXJyb3JfY2FsbGJhY2ss IGRhdGEpOwogCSAgYnJlYWs7CisJY2FzZSA5OgorCSAgZmlsZW5hbWUgPSB3aW5kb3dzX2dl dF9leGVjdXRhYmxlX3BhdGggKGJ1ZiwgZXJyb3JfY2FsbGJhY2ssIGRhdGEpOworCSAgYnJl YWs7CiAJZGVmYXVsdDoKIAkgIGFib3J0ICgpOwogCX0KLS0gCjIuNDIuMQoK --------------UUB9009ZTpNBzdySEdTyHLyX--