From: Iain Sandoe <idsandoe@googlemail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: gcc@gcc.gnu.org, libc-alpha@sourceware.org, qemu-devel@nongnu.org
Subject: Re: Disabling TLS address caching to help QEMU on GNU/Linux
Date: Tue, 20 Jul 2021 16:31:36 +0100 [thread overview]
Message-ID: <55F007B1-A82C-44CB-8427-750AE5FD963E@googlemail.com> (raw)
In-Reply-To: <87im15qbp3.fsf@oldenburg.str.redhat.com>
Hi Florian,
This also affects fibres implementations (both C++ and D ones at least from
discussion with both communities).
> On 20 Jul 2021, at 15:52, Florian Weimer via Gcc <gcc@gcc.gnu.org> wrote:
>
> Currently, the GNU/Linux ABI does not really specify whether the thread
> pointer (the address of the TCB) may change at a function boundary.
>
> Traditionally, GCC assumes that the ABI allows caching addresses of
> thread-local variables across function calls. Such caching varies in
> aggressiveness between targets, probably due to differences in the
> choice of -mtls-dialect=gnu and -mtls-dialect=gnu2 as the default for
> the targets. (Caching with -mtls-dialect=gnu2 appears to be more
> aggressive.)
>
> In addition to that, glibc defines errno as this:
>
> extern int *__errno_location (void) __attribute__ ((__const__));
> #define errno (*__errno_location ())
>
> And the const attribute has the side effect of caching the address of
> errno within the same stack frame.
>
> With stackful coroutines, such address caching is only valid if
> coroutines are only ever resumed on the same thread on which they were
> suspended. (The C++ coroutine implementation is not stackful and is not
> affected by this at the ABI level.)
There are C++20 coroutine library writers who want to switch threads in
symmetric transfers [ I am not entirely convinced about this at present and it
certainly would be suspect with TLS address caching enabled - since a TLS
pointer could equally be cached in the coroutine frame ].
The C++20 coroutine ABI is silent on such matters (it only describes the
visible part of the coroutine frame and the builtins used by the std library).
> Historically, I think we took the
> position that cross-thread resumption is undefined. But the ABIs aren't
> crystal-clear on this matter.
> One important piece of software for GNU is QEMU (not just for GNU/Linux,
> Hurd development also benefits from virtualization). QEMU uses stackful
> coroutines extensively. There are some hard-to-change code areas where
> resumption happens across threads unfortunately. These increasingly
> cause problems with more inlining, inter-procedural analysis, and a
> general push towards LTO (which is also needed for some security
> hardening features).
>
> Should the GNU toolchain offer something to help out the QEMU
> developers? Maybe GCC could offer an option to disable the caching for
> all TLS models. glibc could detect that mode based on a new
> preprocessor macro and adjust its __errno_location declaration and
> similar function declarations. There will be a performance impact of
> this, of course, but it would make the QEMU usage well-defined (at the
> lowest levels).
>
> If this is a programming model that should be supported, then restoring
> some of the optimizations would be possible, by annotating
> context-switching functions and TLS-address-dependent functions. But I
> think QEMU would immediately benefit from just the simple approach that
> disables address caching of TLS variables.
IMO the general cases you note above are enough reason to want some
mechanism to control this,
thanks
Iain
>
> Thanks,
> Florian
>
next prev parent reply other threads:[~2021-07-20 15:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 14:52 Florian Weimer
2021-07-20 15:31 ` Iain Sandoe [this message]
2021-07-21 7:22 ` Thomas Huth
2021-07-22 12:12 ` Richard Biener
2021-07-22 16:01 ` Michael Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F007B1-A82C-44CB-8427-750AE5FD963E@googlemail.com \
--to=idsandoe@googlemail.com \
--cc=fweimer@redhat.com \
--cc=gcc@gcc.gnu.org \
--cc=libc-alpha@sourceware.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).