From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 8C66E385841D for ; Wed, 27 Jul 2022 01:41:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8C66E385841D Received: by mail-pl1-x632.google.com with SMTP id p8so14858177plq.13 for ; Tue, 26 Jul 2022 18:41:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :from:to:references:in-reply-to:content-transfer-encoding; bh=150uvscepOc8wwqhoRFi4svpE22AR2U4DjoEKe6JDGI=; b=aFQLmio59l+CXESKjVi8agawu2fjZiHsxOZkUSlx7KyA7PJ0PfTX7adTh/fVIWWgLO NTjHIMNrib4zHXRfl+GQiPX5o6UUoYMTkB1Xq2OiI9fi688BzE/rbrW1UWHQ6vED3kyz aXeVfiylWsKwMBygdlvq8TOcZPy/0OCKAm4w8y0VkkPTJiFjUkt20U4izRFXwcv6G+BL CoftrdbfEPwSF5PSqJKmhm8CYO3DnaPnCDSBePQA1X+YHQ7rbiOZIoN0uTwMitxOvZ1M +SXvGnOCaza//i7XLQNUooMjd7g0jQTq5oJr9AUPHpezLebF9AmWSenwlqZ80kV0T1kW ZgKQ== X-Gm-Message-State: AJIora9EE70YDvnnYXnWn5CtQi3Aqas30x2mH8JZtGAGGNgOBKfppaYh qbWgW01ZYPxUb1S1//CrDcw= X-Google-Smtp-Source: AGRyM1t0TOTFWIeg24KovTFl0V1BVFn+Jf1poxwESSJEHD0q3+3HrgSFUgL3ZrcFMaVsf3SfpyZtJA== X-Received: by 2002:a17:90b:3c11:b0:1f2:fa68:31b6 with SMTP id pb17-20020a17090b3c1100b001f2fa6831b6mr1902871pjb.93.1658886098616; Tue, 26 Jul 2022 18:41:38 -0700 (PDT) Received: from [192.168.255.10] ([103.7.29.32]) by smtp.gmail.com with ESMTPSA id j1-20020a654d41000000b003fadd680908sm10876047pgt.83.2022.07.26.18.41.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Jul 2022 18:41:37 -0700 (PDT) Message-ID: <5660725f-1b1d-99d7-e0ae-be9e5d782128@gmail.com> Date: Wed, 27 Jul 2022 09:41:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: State of AutoFDO in GCC From: Xionghu Luo To: Eugene Rozenfeld , Andi Kleen , Joseph Myers , Jan Hubicka , gcc References: <20210429054025.GB4032392@tassilo.jf.intel.com> <4d005159.55ea.1791e171ab9.Coremail.172060045@hdu.edu.cn> <875z0378j1.fsf@linux.intel.com> <67df7dbb.5eae.1794bba0ca3.Coremail.172060045@hdu.edu.cn> <7c802b11-857e-78eb-c2e8-0a3044817793@linux.intel.com> <20210509170121.GE25641@kam.mff.cuni.cz> <20210510172121.GT4032392@tassilo.jf.intel.com> <79c0b451-c716-7e1b-9179-1562e97411af@gmail.com> In-Reply-To: <79c0b451-c716-7e1b-9179-1562e97411af@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_LOTSOFHASH, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jul 2022 01:41:41 -0000 On 2022/7/27 09:31, Xionghu Luo wrote: > > > On 2022/7/27 04:12, Eugene Rozenfeld via Gcc wrote: >> Hello GCC community. >> >> I started this thread on the state of AutoFDO in GCC more than a year >> ago. Here is the first message in the thread: >> https://gcc.gnu.org/pipermail/gcc/2021-April/235860.html >> >> Since then I committed a number of patches to revive AutoFDO in GCC: >> >> Fix a typo in an AutoFDO error >> string >> >> Update gen_autofdo_event.py and >> gcc-auto-profile. >> >> Fixes for AutoFDO >> tests >> >> Fix indir-call-prof-2.c with >> AutoFDO >> >> Fixes for AutoFDO >> testing >> >> Fix indirect call inlining with >> AutoFDO >> > > This "indirect call inlining with AutoFDO" patch need to be backported > to at least gcc-10 as it will caused stack overflow for some cases I've > met... Sorry, should be this: AutoFDO: Don't try to promote indirect calls that result in recursive direct calls, Though the "indirect call inlining with AutoFDO" also need verify on old branches. indirect call format is updated with Martin's dynamic topn patch. > > Xionghu