public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Steven Bosscher <stevenb.gcc@gmail.com>
To: ramana.radhakrishnan@arm.com
Cc: gcc@gcc.gnu.org
Subject: Re: ifcvt.c question.
Date: Mon, 10 Aug 2009 13:25:00 -0000	[thread overview]
Message-ID: <571f6b510908100609p3211d20fl68698e6d9e406df8@mail.gmail.com> (raw)
In-Reply-To: <1249902983.25908.44.camel@e200593-lin.cambridge.arm.com>

On Mon, Aug 10, 2009 at 1:16 PM, Ramana
Radhakrishnan<ramana.radhakrishnan@arm.com> wrote:
> I wonder if the best way to fix this is to teach ifcvt.c to handle
> conditional returns.

Yes. This is a bug in the middle-end.  I can only guess why you are
the first to run into this (the ia64 return instruction is not
predicable?) but clearly the assert is bogus if the conditional branch
of the IF-block is actually a conditional return.

> Should I be fixing this inside ifcvt.c by handling
> conditional returns specially

I think you should fix this inside ifcvt.c, but try to make the
handing of cond_return not too specially ;-)

Alternatively, you could add a conditional call pattern and a
post-reload splitter to the ARM backend, and disallow the
EXIT_BLOCK_PTR as the JOIN-block in ifcvt.c.

Ciao!
Steven

  reply	other threads:[~2009-08-10 13:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-10 12:53 Ramana Radhakrishnan
2009-08-10 13:25 ` Steven Bosscher [this message]
2009-08-10 15:49   ` Ramana Radhakrishnan
  -- strict thread matches above, loose matches on Subject: below --
2005-05-30 17:26 Steven Bosscher
2005-05-30 18:38 ` Roger Sayle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=571f6b510908100609p3211d20fl68698e6d9e406df8@mail.gmail.com \
    --to=stevenb.gcc@gmail.com \
    --cc=gcc@gcc.gnu.org \
    --cc=ramana.radhakrishnan@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).