From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by sourceware.org (Postfix) with ESMTPS id 8CE6C3851C11 for ; Wed, 10 Jun 2020 04:18:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8CE6C3851C11 Received: by mail-oi1-x22b.google.com with SMTP id d67so893262oig.6 for ; Tue, 09 Jun 2020 21:18:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:from:reply-to:user-agent :mime-version:to:cc:subject:references:in-reply-to :content-transfer-encoding; bh=XyKI8Dhro+uKa/+deVMchtfd/gD9BwQ8ZWmPA8GUA2o=; b=affqjCZhYYlZwvLUV7J4FdnOFyHdDZGKdGk6LHKAjjfCDX3pYH3+7z7Hb3rrbcxcPC +q9JXCbNLTNeOpmwz3+RTo5HfYpXyXeloylQIQlsY9EBmSLv3anr/PCA1RaOCBiIKRse 50Hmwf/hASccozEGrFRWwVccSuGpgJl40vhhSqmslw4n+8KexPXBEx60b3NhippS1suj 8jQKdLXYFAduDBLLJ6NJhMhVLc2OlefY/TBrVTj9NaD2Yy5Itwl7B7PgDTxZyWErHxwA HuiFHRkxDnC6UfkhQe6P/Bb3A9giKteNAwbDaeJt720xaq/ZuvLrozAHuYOc6Kscthth ONcQ== X-Gm-Message-State: AOAM531duIsiN3PZXIWzgvr3y22uLuCj6nApw3PG03zUyo/9KyEyo8OW bhvPd6JfK6YaoBrIlwGuJUk= X-Google-Smtp-Source: ABdhPJx0BQ2cX+LI26w458ZIts/09w58WZYeX7lbymscX1HpmH+q2q1WG/QbvSsNhiVBReUWQqfVsA== X-Received: by 2002:aca:1308:: with SMTP id e8mr1092913oii.119.1591762712919; Tue, 09 Jun 2020 21:18:32 -0700 (PDT) Received: from [192.168.2.42] (adsl-70-133-146-38.dsl.ablntx.sbcglobal.net. [70.133.146.38]) by smtp.gmail.com with ESMTPSA id y16sm3508512oot.11.2020.06.09.21.18.31 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 09 Jun 2020 21:18:32 -0700 (PDT) Message-ID: <5EE05F15.4070408@gmail.com> Date: Tue, 09 Jun 2020 23:18:29 -0500 From: Jacob Bachmeyer Reply-To: jcb62281@gmail.com User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.22) Gecko/20090807 MultiZilla/1.8.3.4e SeaMonkey/1.1.17 Mnenhy/0.7.6.0 MIME-Version: 1.0 To: jcb62281@gmail.com CC: "Maciej W. Rozycki" , Rob Savoye , Jacob Bachmeyer , Siddhesh Poyarekar , Rainer Orth , gcc@gcc.gnu.org, Mike Stump , Thomas Schwinge Subject: Re: dejagnu version update? [CORRECTION: not a regression in DejaGnu; GDB testsuite bug] References: <87zhac871g.fsf@euler.schwinge.homeip.net> <274e2a71-ddb0-18cc-70c1-4ca9ccf8bd29@welcomehome.org> <9a017568-911d-9352-859a-8721b2f47c53@welcomehome.org> <29b3fe32-b3c9-653e-2ef3-6e89083188f6@welcomehome.org> <3e294014-8205-c99c-ecc7-3e9d383e5587@welcomehome.org> <5EE04696.8090209@gmail.com> In-Reply-To: <5EE04696.8090209@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, FREEMAIL_REPLYTO_END_DIGIT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jun 2020 04:18:34 -0000 Jacob Bachmeyer wrote: > Maciej W. Rozycki wrote: >> [...] >> >> I ran a quick bisection and the culprit turned out to be: >> >> ba60272a5ac6f6a7012acca03f596a6ed003f044 is the first bad commit >> commit ba60272a5ac6f6a7012acca03f596a6ed003f044 >> Author: Jacob Bachmeyer >> Date: Mon May 25 08:40:46 2020 -0600 >> >> Establish a default C compiler by evaluating [find_gcc] if no >> other compiler is given. >> >> So this regression has to be fixed before any new release is made. > > I will look into this. So far, I have confirmed that the problem does > occur and that setting the "compiler" board_info key in > baseboards/unix.exp seems to avoid it. It looks like the default is > not being selected in all cases where it should be used. I still need > to find the exact problem to write a regression test to isolate this > bug and make it stay squashed. After further efforts, and a few hours wasted trying to figure out why additional tracing code added to default_target_compile was not producing output, I eventually decided to just make default_target_compile throw a Tcl error -- and I did not get a Tcl error when running the tests... That is "very interesting" and a quick grep -R reveals the culprit: the GDB testsuite is overriding default_target_compile in gdb/testsuite/lib/future.exp. Comments indicate that that file was intended to temporarily bundle certain features with the GDB testsuite that had not yet been merged into upstream DejaGnu -- in 2004. Now DejaGnu core is continuing to develop, leaving the old code copied into the GDB testsuite broken, and making this NOTOURBUG. In short, this is not a regression in DejaGnu; this is code duplicated into the GDB testsuite that was slated for removal from that location years ago and needs to be removed from the GDB testsuite, or at least made conditional on running under a version of DejaGnu old enough to require it, if such versions are still supported for running the GDB testsuite. If that code has added features not present in upstream DejaGnu over the years, now is the time to get those patches in. -- Jacob