From: Paulo Matos <pmatos@linki.tools>
To: David Malcolm <dmalcolm@redhat.com>, "gcc@gcc.gnu.org" <gcc@gcc.gnu.org>
Subject: Re: jamais-vu can now ignore renumbering of source lines in dg output (Re: GCC Buildbot Update)
Date: Mon, 29 Jan 2018 13:55:00 -0000 [thread overview]
Message-ID: <5a698304-34bc-019c-7197-6386a5320bbb@linki.tools> (raw)
In-Reply-To: <1516821601.26503.8.camel@redhat.com>
On 24/01/18 20:20, David Malcolm wrote:
>
> I've added a new feature to jamais-vu (as of
> 77849e2809ca9a049d5683571e27ebe190977fa8): it can now ignore test
> results that merely changed line number.
>
> For example, if the old .sum file has a:
>
> PASS: g++.dg/diagnostic/param-type-mismatch.C -std=gnu++11 (test for errors, line 106)
>
> and the new .sum file has a:
>
> PASS: g++.dg/diagnostic/param-type-mismatch.C -std=gnu++11 (test for errors, line 103)
>
> and diffing the source trees reveals that line 106 became line 103, the
> change won't be reported by "jv compare".
>
> It also does it for dg-{begin|end}-multiline-output.
>
> It will report them if the outcome changed (e.g. from PASS to FAIL).
>
> To do this filtering, jv needs access to the old and new source trees,
> so it can diff the pertinent source files, so "jv compare" has gained
> the optional arguments
> --old-source-path=
> and
> --new-source-path=
> See the example in the jv Makefile for more info. If they're not
> present, it should work as before (without being able to do the above
> filtering).
Hi,
I am looking at this today and I noticed that having the source file for
all recent GCC revisions is costly in terms of time (if we wish to
compress them) and space (for storage). I was instead thinking that jv
could calculate the differences offline using pysvn and the old and new
revision numbers.
I have started implementing this in my port. Would you consider merging it?
--
Paulo Matos
next prev parent reply other threads:[~2018-01-29 13:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 8:56 GCC Buildbot Update Paulo Matos
2017-12-14 11:39 ` David Malcolm
2017-12-15 9:16 ` Paulo Matos
2017-12-15 14:29 ` David Malcolm
2017-12-16 11:07 ` Paulo Matos
2018-01-24 19:20 ` jamais-vu can now ignore renumbering of source lines in dg output (Re: GCC Buildbot Update) David Malcolm
2018-01-25 7:25 ` Paulo Matos
2018-01-29 13:55 ` Paulo Matos [this message]
2018-01-29 14:19 ` David Malcolm
2018-01-29 14:27 ` Paulo Matos
2017-12-14 20:32 ` GCC Buildbot Update Christophe Lyon
2017-12-15 7:42 ` Markus Trippelsdorf
2017-12-15 9:21 ` Paulo Matos
2017-12-15 11:10 ` Markus Trippelsdorf
2017-12-15 17:05 ` Segher Boessenkool
2017-12-16 11:54 ` Paulo Matos
2017-12-15 9:19 ` Paulo Matos
2017-12-15 9:21 ` Christophe Lyon
2017-12-15 9:29 ` Paulo Matos
2017-12-20 8:32 ` Paulo Matos
2017-12-20 9:52 ` Christophe Lyon
2017-12-20 10:02 ` Paulo Matos
2017-12-20 10:09 ` Christophe Lyon
2017-12-20 11:49 ` James Greenhalgh
2017-12-20 14:01 ` Paulo Matos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a698304-34bc-019c-7197-6386a5320bbb@linki.tools \
--to=pmatos@linki.tools \
--cc=dmalcolm@redhat.com \
--cc=gcc@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).