From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2881 invoked by alias); 29 Jan 2018 13:55:55 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 2872 invoked by uid 89); 29 Jan 2018 13:55:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=H*M:tools, compress, pertinent, wish X-HELO: box.linki.tools Received: from box.linki.tools (HELO box.linki.tools) (88.198.125.222) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 29 Jan 2018 13:55:53 +0000 Received: from authenticated-user (box.linki.tools [88.198.125.222]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by box.linki.tools (Postfix) with ESMTPSA id 72DAD40A49; Mon, 29 Jan 2018 14:55:40 +0100 (CET) Subject: Re: jamais-vu can now ignore renumbering of source lines in dg output (Re: GCC Buildbot Update) To: David Malcolm , "gcc@gcc.gnu.org" References: <1513251583.27881.199.camel@redhat.com> <1513348171.27881.230.camel@redhat.com> <306f5617-e62a-b828-c075-ba821cd2e361@linki.tools> <1516821601.26503.8.camel@redhat.com> From: Paulo Matos Message-ID: <5a698304-34bc-019c-7197-6386a5320bbb@linki.tools> Date: Mon, 29 Jan 2018 13:55:00 -0000 MIME-Version: 1.0 In-Reply-To: <1516821601.26503.8.camel@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00244.txt.bz2 On 24/01/18 20:20, David Malcolm wrote: > > I've added a new feature to jamais-vu (as of > 77849e2809ca9a049d5683571e27ebe190977fa8): it can now ignore test > results that merely changed line number. > > For example, if the old .sum file has a: > > PASS: g++.dg/diagnostic/param-type-mismatch.C -std=gnu++11 (test for errors, line 106) > > and the new .sum file has a: > > PASS: g++.dg/diagnostic/param-type-mismatch.C -std=gnu++11 (test for errors, line 103) > > and diffing the source trees reveals that line 106 became line 103, the > change won't be reported by "jv compare". > > It also does it for dg-{begin|end}-multiline-output. > > It will report them if the outcome changed (e.g. from PASS to FAIL). > > To do this filtering, jv needs access to the old and new source trees, > so it can diff the pertinent source files, so "jv compare" has gained > the optional arguments > --old-source-path= > and > --new-source-path= > See the example in the jv Makefile for more info. If they're not > present, it should work as before (without being able to do the above > filtering). Hi, I am looking at this today and I noticed that having the source file for all recent GCC revisions is costly in terms of time (if we wish to compress them) and space (for storage). I was instead thinking that jv could calculate the differences offline using pysvn and the old and new revision numbers. I have started implementing this in my port. Would you consider merging it? -- Paulo Matos