public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Steve Ellcey " <sellcey@mips.com>
To: <rdsandiford@googlemail.com>, <law@redhat.com>
Cc: <gcc@gcc.gnu.org>
Subject: MIPS GCC test failure: gcc.dg/tree-ssa/ssa-dom-thread-4.c
Date: Sat, 01 Feb 2014 00:32:00 -0000	[thread overview]
Message-ID: <5c24a8c6-2af6-4098-a64c-4760751aeef0@BAMAIL02.ba.imgtec.org> (raw)

Jeff and Richard,

I was looking at the test failure of gcc.dg/tree-ssa/ssa-dom-thread-4.c
on MIPS.  The failure is in the scan of how many jumps are threaded
which has changed from 6 to 4 on MIPS.  I tracked down the change to
this patch:

2013-11-19  Jeff Law  <law@redhat.com>

        * tree-ssa-threadedge.c (thread_across_edge): After threading
        through a joiner, allow threading a normal block requiring
        duplication.

        * tree-ssa-threadupdate.c (thread_block_1): Improve code to detect
        jump threading requests that would muck up the loop structures.

        * tree-ssa-threadupdate.c: Fix trailing whitespace.
        * tree-ssa-threadupdate.h: Likewise.

Now my initial thought is to just change the mips scan to look for
4 'Threaded' lines instead of 6 and be done with it, but the test has
a long explanation of why 6 is the right answer on MIPS and I don't know
what to do with this.  Even after looking at the new and old dom1 dump
files I can't really explain why 4 is the right number now instead of 6.

I am not sure if this is broken on arc or avr now either, I didn't see
any test results from these platforms in gcc-testsuite mailing list
so I am not sure if they were affected or not.

I also noticed that while the dom1 dump is different the final code
generation for MIPS has not changed for this test.

So my question is, can either of you help me with the MIPS explanation
of why 4 is the right number now and/or can I just remove the explanation
and change the MIPS scan?  Should I leave avr and arc alone (split them
off from mips) since I have no evidence that they are failing?

Steve Ellcey
sellcey@mips.com

             reply	other threads:[~2014-02-01  0:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-01  0:32 Steve Ellcey  [this message]
2014-02-01 11:52 ` Richard Sandiford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5c24a8c6-2af6-4098-a64c-4760751aeef0@BAMAIL02.ba.imgtec.org \
    --to=sellcey@mips.com \
    --cc=gcc@gcc.gnu.org \
    --cc=law@redhat.com \
    --cc=rdsandiford@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).