From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31575 invoked by alias); 1 Feb 2014 00:32:44 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 31560 invoked by uid 89); 1 Feb 2014 00:32:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: multi.imgtec.com Received: from multi.imgtec.com (HELO multi.imgtec.com) (194.200.65.239) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 01 Feb 2014 00:32:41 +0000 From: "Steve Ellcey " Date: Sat, 01 Feb 2014 00:32:00 -0000 To: , CC: Subject: MIPS GCC test failure: gcc.dg/tree-ssa/ssa-dom-thread-4.c User-Agent: Heirloom mailx 12.5 6/20/10 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-ID: <5c24a8c6-2af6-4098-a64c-4760751aeef0@BAMAIL02.ba.imgtec.org> X-SEF-Processed: 7_3_0_01192__2014_02_01_00_32_38 X-SW-Source: 2014-02/txt/msg00001.txt.bz2 Jeff and Richard, I was looking at the test failure of gcc.dg/tree-ssa/ssa-dom-thread-4.c on MIPS. The failure is in the scan of how many jumps are threaded which has changed from 6 to 4 on MIPS. I tracked down the change to this patch: 2013-11-19 Jeff Law * tree-ssa-threadedge.c (thread_across_edge): After threading through a joiner, allow threading a normal block requiring duplication. * tree-ssa-threadupdate.c (thread_block_1): Improve code to detect jump threading requests that would muck up the loop structures. * tree-ssa-threadupdate.c: Fix trailing whitespace. * tree-ssa-threadupdate.h: Likewise. Now my initial thought is to just change the mips scan to look for 4 'Threaded' lines instead of 6 and be done with it, but the test has a long explanation of why 6 is the right answer on MIPS and I don't know what to do with this. Even after looking at the new and old dom1 dump files I can't really explain why 4 is the right number now instead of 6. I am not sure if this is broken on arc or avr now either, I didn't see any test results from these platforms in gcc-testsuite mailing list so I am not sure if they were affected or not. I also noticed that while the dom1 dump is different the final code generation for MIPS has not changed for this test. So my question is, can either of you help me with the MIPS explanation of why 4 is the right number now and/or can I just remove the explanation and change the MIPS scan? Should I leave avr and arc alone (split them off from mips) since I have no evidence that they are failing? Steve Ellcey sellcey@mips.com