From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark@klomp.org>
Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112])
 by sourceware.org (Postfix) with ESMTPS id B82653857830
 for <gcc@gcc.gnu.org>; Wed, 15 Sep 2021 14:10:52 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B82653857830
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org
Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl
 [83.87.18.245])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by gnu.wildebeest.org (Postfix) with ESMTPSA id D7D3430002C0;
 Wed, 15 Sep 2021 16:10:50 +0200 (CEST)
Received: by tarox.wildebeest.org (Postfix, from userid 1000)
 id 4601D413CE02; Wed, 15 Sep 2021 16:10:50 +0200 (CEST)
Message-ID: <6162616e4f65918c17509b3afacfd24b23532ce8.camel@klomp.org>
Subject: Re: Error when accessing git read-only archive
From: Mark Wielaard <mark@klomp.org>
To: Jonathan Wakely <jwakely.gcc@gmail.com>, Jan-Benedict Glaw
 <jbglaw@lug-owl.de>
Cc: Thomas Koenig <tkoenig@netcologne.de>, gcc mailing list <gcc@gcc.gnu.org>
Date: Wed, 15 Sep 2021 16:10:50 +0200
In-Reply-To: <CAH6eHdQH_Csm4n045bmAXh8S2JyQCQM-=1FPOdh0gw3Y_JD3gw@mail.gmail.com>
References: <8fe140f6-804b-0180-e4d3-5293ee11905c@netcologne.de>
 <CAH6eHdQPppiZmtPqrfWgJ3wLzFm2_deYDegx7y4G89D7oKe6iw@mail.gmail.com>
 <CAH6eHdRFKEdha2W50UbaJMSWHXHHqyUn6iynLPxk-rAw-uPCKQ@mail.gmail.com>
 <3d642e058b5fde27ec3dd955183a3b2de934174c.camel@redhat.com>
 <20210915133710.agtw4l4vwjo6myhm@lug-owl.de>
 <CAH6eHdQH_Csm4n045bmAXh8S2JyQCQM-=1FPOdh0gw3Y_JD3gw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) 
Mime-Version: 1.0
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc mailing list <gcc.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc>,
 <mailto:gcc-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc/>
List-Post: <mailto:gcc@gcc.gnu.org>
List-Help: <mailto:gcc-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc>,
 <mailto:gcc-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Sep 2021 14:10:54 -0000

Hi,

On Wed, 2021-09-15 at 14:43 +0100, Jonathan Wakely via Gcc wrote:
> On Wed, 15 Sept 2021 at 14:37, Jan-Benedict Glaw <jbglaw@lug-owl.de>
> wrote:
> > On Wed, 2021-09-15 09:21:04 -0400, David Malcolm via Gcc <
> > gcc@gcc.gnu.org> wrote:
> > > It appears to be due to the "=C5=82" character in the email address o=
f
> > > the
> > > Author, in that:
> > >=20
> > > commit c012297c9d5dfb177adf1423bdd05e5f4b87e5ec
> > > Author: Jan-Benedict Glaw <jbglaw@lug-owl.de>
> > >=20
> > > works, whereas:
> > >=20
> > > commit f42e95a830ab48e59389065ce79a013a519646f1
> > > Author: Jan-Benedict Glaw <jbglaw@=C5=82ug-owl.de>
> >=20
> > That was indeed me, after moving my GCC repo to a different machine
> > and adding an explicit user.email (as this wasn't automatically
> > picking up a proper domain.) The "=C5=82" was a typo (AltGr key still
> > pressed while typing the "l" after having entered the "@" which
> > requires it on a German keyboard layout.)
> >=20
> >   So I broke it. Any way to make sure something like this doesn't
> > occur again?
>=20
> We could add a check to the git hooks (and gcc-verify alias) to
> reject
> non-ASCII email addresses, since they're probably mistakes.
>=20
> And we should report it to Gitweb (if it isn't already fixed
> upstream)
> and get a fix into the version used on gcc.gnu.org.

The issue is the gravatar support, which calls md5_hex($email).
For now I disabled gravatar support on sourceware.org/gcc.gnu.org in
/etc/gitweb.conf

Cheers,

Mark