From: Bill Schmidt <wschmidt@linux.vnet.ibm.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Maxim Ostapenko <m.ostapenko@samsung.com>, gcc@gcc.gnu.org
Subject: Re: -fsanitize=thread support on ppc64
Date: Mon, 23 Jan 2017 14:48:00 -0000 [thread overview]
Message-ID: <65175501-69B9-4D42-9661-29E5C01EE947@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170123144712.GO1867@tucnak>
> On Jan 23, 2017, at 8:47 AM, Jakub Jelinek <jakub@redhat.com> wrote:
>
> On Mon, Jan 23, 2017 at 08:45:16AM -0600, Bill Schmidt wrote:
>>> 2017-01-23 Jakub Jelinek <jakub@redhat.com>
>>>
>>> * configure.tgt: Enable tsan and lsan on powerpc64{,le}-*-linux*.
>>>
>>> --- libsanitizer/configure.tgt.jj 2016-11-09 15:22:50.000000000 +0100
>>> +++ libsanitizer/configure.tgt 2017-01-23 15:25:21.059399613 +0100
>>> @@ -1,5 +1,5 @@
>>> # -*- shell-script -*-
>>> -# Copyright (C) 2012 Free Software Foundation, Inc.
>>> +# Copyright (C) 2012-2017 Free Software Foundation, Inc.
>>>
>>> # This program is free software; you can redistribute it and/or modify
>>> # it under the terms of the GNU General Public License as published by
>>> @@ -31,6 +31,11 @@ case "${target}" in
>>> fi
>>> ;;
>>> powerpc*-*-linux*)
>>
>> I think you want a separate entry for powerpc64*-*-linux* -- IIRC, the
>> existing code will definitely not work for 32-bit due to TLS differences.
>> Thus be sure we don't enable TSAN for powerpc-*-linux.
>
> That is handled by the
>
>>> + if test x$ac_cv_sizeof_void_p = x8; then
>
> test (similarly how for both i?86-*-linux* and x86_64-*-linux* it is enabled
> only for LP64 multilib and not others). We want to enable it only for the
> 64-bit multilib, not 32-bit.
Ah, quite right. Sorry for the sloppy reading.
Bill
>
>>> + TSAN_SUPPORTED=yes
>>> + LSAN_SUPPORTED=yes
>>> + TSAN_TARGET_DEPENDENT_OBJECTS=tsan_rtl_ppc64.lo
>>> + fi
>>> ;;
>>> sparc*-*-linux*)
>>> ;;
>
> Jakub
>
prev parent reply other threads:[~2017-01-23 14:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170123113432epcas1p2951bfbb1968a143a14b9c54475ff3527@epcas1p2.samsung.com>
2017-01-23 11:34 ` Jakub Jelinek
2017-01-23 12:54 ` Maxim Ostapenko
2017-01-23 14:22 ` Bill Schmidt
2017-01-23 14:32 ` Jakub Jelinek
2017-01-23 14:41 ` Bill Schmidt
2017-01-23 15:10 ` Ulrich Weigand
2017-01-23 15:27 ` Jakub Jelinek
2017-01-23 14:44 ` Bill Schmidt
2017-01-23 14:47 ` Jakub Jelinek
2017-01-23 14:48 ` Bill Schmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65175501-69B9-4D42-9661-29E5C01EE947@linux.vnet.ibm.com \
--to=wschmidt@linux.vnet.ibm.com \
--cc=gcc@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=m.ostapenko@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).