From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27518 invoked by alias); 24 Sep 2004 06:17:45 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 27510 invoked from network); 24 Sep 2004 06:17:43 -0000 Received: from unknown (HELO mail-out4.apple.com) (17.254.13.23) by sourceware.org with SMTP; 24 Sep 2004 06:17:43 -0000 Received: from mailgate1.apple.com (a17-128-100-225.apple.com [17.128.100.225]) by mail-out4.apple.com (8.12.11/8.12.11) with ESMTP id i8O6Kuj8004370 for ; Thu, 23 Sep 2004 23:20:56 -0700 (PDT) Received: from relay2.apple.com (relay2.apple.com) by mailgate1.apple.com (Content Technologies SMTPRS 4.3.14) with ESMTP id ; Thu, 23 Sep 2004 23:17:42 -0700 Received: from [17.112.107.112] ([17.112.107.112]) by relay2.apple.com (8.12.11/8.12.11) with ESMTP id i8O6HPZd006439; Thu, 23 Sep 2004 23:17:25 -0700 (PDT) In-Reply-To: <7CCA5E88-0DBD-11D9-921D-000A95D692F4@physics.uc.edu> References: <7CCA5E88-0DBD-11D9-921D-000A95D692F4@physics.uc.edu> Mime-Version: 1.0 (Apple Message framework v619) Content-Type: multipart/signed; micalg=sha1; boundary=Apple-Mail-1--412154367; protocol="application/pkcs7-signature" Message-Id: <67B26B10-0DF1-11D9-B012-000A95B1F520@apple.com> Cc: gcc List From: Geoffrey Keating Subject: Re: attribute data structure rewrite Date: Fri, 24 Sep 2004 06:52:00 -0000 To: Andrew Pinski X-SW-Source: 2004-09/txt/msg01404.txt.bz2 --Apple-Mail-1--412154367 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Content-length: 1261 On 23/09/2004, at 5:05 PM, Andrew Pinski wrote: > > On Sep 23, 2004, at 7:54 PM, Geoffrey Keating wrote: > >> As a precondition for other compile speed improvements, I've been >> rewriting the way that GCC represents attributes. The result is a >> medium-size patch that touches every language and many targets (a >> surprising number of targets don't define any special attributes at >> all). >> >> The basic principle is that DECL_ATTRIBUTES and TREE_ATTRIBUTES now >> point to an attribute_list: >> >> /* A structure representing 'attributes' on a DECL or TYPE node. >> Each attribute has a NAME (an IDENTIFIER_NODE) and possibly a >> VALUE. */ >> struct one_attribute GTY(()) >> { >> tree name; >> tree value; >> }; > > Shouldn't name be redefined as char* as you don't really need a full > IDENTIFIER_NODE? > Yes I know that correctly it is not but I would suspect that it would > give a good > speedup as you don't need to allocate as many trees as before. I thought of that, but I suspect it's better to go the other way: make 'name' always be the *same* IDENTIFIER_NODE for a particular kind of attribute, so you can just compare pointers. You do always have to allocate one, because 'name' will come from a token in user code. --Apple-Mail-1--412154367 Content-Transfer-Encoding: base64 Content-Type: application/pkcs7-signature; name=smime.p7s Content-Disposition: attachment; filename=smime.p7s Content-length: 3266 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEH AQAAoIIGQzCCAvwwggJloAMCAQICAwykzzANBgkqhkiG9w0BAQQFADBiMQsw CQYDVQQGEwJaQTElMCMGA1UEChMcVGhhd3RlIENvbnN1bHRpbmcgKFB0eSkg THRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIElzc3Vp bmcgQ0EwHhcNMDQwNzA3MjEwNTI1WhcNMDUwNzA3MjEwNTI1WjBxMRAwDgYD VQQEEwdLZWF0aW5nMRkwFwYDVQQqExBHZW9mZnJleSBGcmFuY2lzMSEwHwYD VQQDExhHZW9mZnJleSBGcmFuY2lzIEtlYXRpbmcxHzAdBgkqhkiG9w0BCQEW EGdlb2Zma0BhcHBsZS5jb20wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEK AoIBAQCk+DpeD1oRuwCyKEyWI1+V9N7wt58WtqjfjF2oVb7OCh3Oq34nHQAT 76qdibJabSf213HPwAU/D3BnLtWldIiKy46xPvmUzbhfwZbq7DXGjQ1ishvo H5jzI4YMKmVf3ggSAtVTyd8WU0xvhFe3iOMfnyPGoPdbjQFkVaLlhJ7Xv2hu IK6ZYHdCsQ4B2u3V4ObkgZIg+CkwGuZb/l1JIc4tjixMNk81Pp4GtG8pWU5y SbP3LpHUDLQyK8Kg3+WfqKqdcZPJJpilaEZtS+mysgFymB0mKruAMmLfs0mT FflblEqacY7W/Zkr9yn5xTNsLEk6nhXYAccAuK2HDx4n+pIhAgMBAAGjLTAr MBsGA1UdEQQUMBKBEGdlb2Zma0BhcHBsZS5jb20wDAYDVR0TAQH/BAIwADAN BgkqhkiG9w0BAQQFAAOBgQBJ1U1y72DgkFZGAeUHwnIGD5+97AYpgTsY0GpF j8gEx09sFQ5Ay+9glApR0kFuC+4wEqCVfXhxqlBrEWXA0+j9Gq6O4uLchtW4 y40TUYaQCP8H4t0FUWdueXfe8KtCwXZlrExqrWQeIv5YIiUqYmsyctg1tex+ m74ZI0u8gorLITCCAz8wggKooAMCAQICAQ0wDQYJKoZIhvcNAQEFBQAwgdEx CzAJBgNVBAYTAlpBMRUwEwYDVQQIEwxXZXN0ZXJuIENhcGUxEjAQBgNVBAcT CUNhcGUgVG93bjEaMBgGA1UEChMRVGhhd3RlIENvbnN1bHRpbmcxKDAmBgNV BAsTH0NlcnRpZmljYXRpb24gU2VydmljZXMgRGl2aXNpb24xJDAiBgNVBAMT G1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBDQTErMCkGCSqGSIb3DQEJARYc cGVyc29uYWwtZnJlZW1haWxAdGhhd3RlLmNvbTAeFw0wMzA3MTcwMDAwMDBa Fw0xMzA3MTYyMzU5NTlaMGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3 dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUgUGVy c29uYWwgRnJlZW1haWwgSXNzdWluZyBDQTCBnzANBgkqhkiG9w0BAQEFAAOB jQAwgYkCgYEAxKY8VXNV+065yplaHmjAdQRwnd/p/6Me7L3N9VvyGna9fww6 YfK/Uc4B1OVQCjDXAmNaLIkVcI7dyfArhVqqP3FWy688Cwfn8R+RNiQqE88r 1fOCdz0Dviv+uxg+B79AgAJk16emu59l0cUqVIUPSAR/p7bRPGEEQB5kGXJg t/sCAwEAAaOBlDCBkTASBgNVHRMBAf8ECDAGAQH/AgEAMEMGA1UdHwQ8MDow OKA2oDSGMmh0dHA6Ly9jcmwudGhhd3RlLmNvbS9UaGF3dGVQZXJzb25hbEZy ZWVtYWlsQ0EuY3JsMAsGA1UdDwQEAwIBBjApBgNVHREEIjAgpB4wHDEaMBgG A1UEAxMRUHJpdmF0ZUxhYmVsMi0xMzgwDQYJKoZIhvcNAQEFBQADgYEASIzR UIPqCy7MDaNmrGcPf6+svsIXoUOWlJ1/TCG4+DYfqi2fNi/A9BxQIJNwPP2t 4WFiw9k6GX6EsZkbAMUaC4J0niVQlGLH2ydxVyWN3amcOY6MIE9lX5Xa9/eH 1sYITq726jTlEBpbNU1341YheILcIRk13iSx0x1G/11fZU8xggLnMIIC4wIB ATBpMGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGlu ZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUgUGVyc29uYWwgRnJlZW1h aWwgSXNzdWluZyBDQQIDDKTPMAkGBSsOAwIaBQCgggFTMBgGCSqGSIb3DQEJ AzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTA0MDkyNDA2MTcyNlow IwYJKoZIhvcNAQkEMRYEFPQYqCpHpgqNzgUDgUZrlXN95Ay9MHgGCSsGAQQB gjcQBDFrMGkwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25z dWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBG cmVlbWFpbCBJc3N1aW5nIENBAgMMpM8wegYLKoZIhvcNAQkQAgsxa6BpMGIx CzAJBgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5 KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUgUGVyc29uYWwgRnJlZW1haWwgSXNz dWluZyBDQQIDDKTPMA0GCSqGSIb3DQEBAQUABIIBADaDYC+HuRddhGBFfduI SxxdgcCfecDAvu6/m1/blpWpJpoUxeIDiR+VjUTiepDhwZN4GFbdgGLOxOBa mE2pPqms+BwKPU7zCjG62RgWpggZcf11sT0DUcJ92guUQN4Vm3rAMeZllFL8 JU8F6DVTGkmv+Y40CEFInyuYjJZav2+QCWLyxq+NQWD09CWbTQGJqa4NkyjW U+k+3hoSdxBwcHlyTC3LeWJg6fvXHXHqCXoZq0sssWf7wRf+5np2xIMYuWlp S61aXnN22YKjl+o0PftZOCzsNsmrtHzamb13WzwjhKtjA5x8Q437CL8uFOAT f+ProdIHQ1G+nCxaejJ4BPkAAAAAAAA= --Apple-Mail-1--412154367--