From: Ramana Radhakrishnan <ramana.r@gmail.com>
To: Michael Matz <matz@suse.de>, gcc@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: [Patch]fix new reg-alloc-branch crash in final.c
Date: Fri, 10 Sep 2004 06:01:00 -0000 [thread overview]
Message-ID: <67ea2eb0409092227df87bf3@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0409092105250.1173@wotan.suse.de>
Hi Michael,
<snip>
> No. Except for seeing where it crashes, and fixing the bug. Do you want
> to?
Tracked to final.c : profile_function which I have fixed based on the
patches suggested at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12315
. The patch below fixes it for the ra-branch .
There are still a couple of other libstdc++ errors that I am looking at .
cheers
Ramana
--
Ramana Radhakrishnan
ChangeLog
* 20040906: Ramana Radhakrishnan <ramana.r@gmail.com>
final.c : backport of a profiling patch from gcc3.4 head to
reg-alloc-branch to fix a crash while building the regalloc branch
with profiling. Based on patches suggested by Alan Modra and DJ
Delorie for fix to Bug #12315.
Index: final.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/final.c,v
retrieving revision 1.155.2.8
diff -a -u -r1.155.2.8 final.c
--- final.c 10 Oct 2003 14:18:31 -0000 1.155.2.8
+++ final.c 10 Sep 2004 05:21:11 -0000
@@ -1437,7 +1437,7 @@
function_section (current_function_decl);
#if defined(ASM_OUTPUT_REG_PUSH)
- if (sval && GET_CODE (svrtx) == REG)
+ if (sval && svrtx != NULL_RTX && GET_CODE (svrtx) == REG)
ASM_OUTPUT_REG_PUSH (file, REGNO (svrtx));
#endif
@@ -1468,7 +1468,7 @@
#endif
#if defined(ASM_OUTPUT_REG_PUSH)
- if (sval && GET_CODE (svrtx) == REG)
+ if (sval && svrtx != NULL_RTX && GET_CODE (svrtx) == REG)
ASM_OUTPUT_REG_POP (file, REGNO (svrtx));
#endif
}
prev parent reply other threads:[~2004-09-10 5:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <67ea2eb040905020128b03316@mail.gmail.com>
[not found] ` <Pine.LNX.4.58.0409060926360.20630@wotan.suse.de>
[not found] ` <67ea2eb040906011154bb737b@mail.gmail.com>
[not found] ` <Pine.LNX.4.58.0409061752050.20630@wotan.suse.de>
2004-09-09 19:13 ` ra.c todo list Ramana Radhakrishnan
2004-09-09 19:17 ` Michael Matz
2004-09-10 6:01 ` Ramana Radhakrishnan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67ea2eb0409092227df87bf3@mail.gmail.com \
--to=ramana.r@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
--cc=matz@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).