From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-return-102386-listarch-gcc=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 31587 invoked by alias); 10 Sep 2004 05:27:41 -0000
Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Archive: <http://gcc.gnu.org/ml/gcc/>
List-Post: <mailto:gcc@gcc.gnu.org>
List-Help: <http://gcc.gnu.org/ml/>
Sender: gcc-owner@gcc.gnu.org
Received: (qmail 31548 invoked from network); 10 Sep 2004 05:27:31 -0000
Received: from unknown (HELO mproxy.gmail.com) (64.233.170.203)
  by sourceware.org with SMTP; 10 Sep 2004 05:27:31 -0000
Received: by mproxy.gmail.com with SMTP id 74so515149rnl
        for <gcc@gcc.gnu.org>; Thu, 09 Sep 2004 22:27:31 -0700 (PDT)
Received: by 10.38.22.67 with SMTP id 67mr1714395rnv;
        Thu, 09 Sep 2004 22:27:31 -0700 (PDT)
Received: by 10.38.24.56 with HTTP; Thu, 9 Sep 2004 22:27:31 -0700 (PDT)
Message-ID: <67ea2eb0409092227df87bf3@mail.gmail.com>
Date: Fri, 10 Sep 2004 06:01:00 -0000
From: Ramana Radhakrishnan <ramana.r@gmail.com>
Reply-To: Ramana Radhakrishnan <ramana.r@gmail.com>
To: Michael Matz <matz@suse.de>, gcc@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: [Patch]fix new reg-alloc-branch crash in final.c
In-Reply-To: <Pine.LNX.4.58.0409092105250.1173@wotan.suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
References: <67ea2eb040905020128b03316@mail.gmail.com>
	 <Pine.LNX.4.58.0409060926360.20630@wotan.suse.de>
	 <67ea2eb040906011154bb737b@mail.gmail.com>
	 <Pine.LNX.4.58.0409061752050.20630@wotan.suse.de>
	 <67ea2eb04090912034440bc2a@mail.gmail.com>
	 <Pine.LNX.4.58.0409092105250.1173@wotan.suse.de>
X-SW-Source: 2004-09/txt/msg00573.txt.bz2

Hi Michael,

<snip> 
> No.  Except for seeing where it crashes, and fixing the bug.  Do you want
> to?

Tracked to  final.c : profile_function which I have fixed based on the
patches suggested at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12315
. The patch below fixes it for the ra-branch .

There are still a couple of other libstdc++ errors that I am looking at . 

cheers
Ramana

-- 
Ramana Radhakrishnan

ChangeLog
* 20040906: Ramana Radhakrishnan <ramana.r@gmail.com>

final.c : backport of a profiling patch from gcc3.4 head to
reg-alloc-branch to fix a crash while building the regalloc branch
with profiling. Based on patches suggested by Alan Modra and DJ
Delorie for fix to Bug #12315.

Index: final.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/final.c,v
retrieving revision 1.155.2.8
diff -a -u -r1.155.2.8 final.c
--- final.c     10 Oct 2003 14:18:31 -0000      1.155.2.8
+++ final.c     10 Sep 2004 05:21:11 -0000
@@ -1437,7 +1437,7 @@
   function_section (current_function_decl);
  
 #if defined(ASM_OUTPUT_REG_PUSH)
-  if (sval && GET_CODE (svrtx) == REG)
+  if (sval && svrtx != NULL_RTX && GET_CODE (svrtx) == REG)
     ASM_OUTPUT_REG_PUSH (file, REGNO (svrtx));
 #endif
  
@@ -1468,7 +1468,7 @@
 #endif
  
 #if defined(ASM_OUTPUT_REG_PUSH)
-  if (sval && GET_CODE (svrtx) == REG)
+  if (sval && svrtx != NULL_RTX && GET_CODE (svrtx) == REG)
     ASM_OUTPUT_REG_POP (file, REGNO (svrtx));
 #endif
 }