From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-return-154145-listarch-gcc=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 5748 invoked by alias); 20 May 2009 14:39:08 -0000
Received: (qmail 5732 invoked by uid 22791); 20 May 2009 14:39:07 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail-fx0-f165.google.com (HELO mail-fx0-f165.google.com) (209.85.220.165)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 May 2009 14:39:03 +0000
Received: by fxm9 with SMTP id 9so521452fxm.8         for <gcc@gcc.gnu.org>; Wed, 20 May 2009 07:39:00 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.204.121.131 with SMTP id h3mr1284643bkr.172.1242830340666;  	Wed, 20 May 2009 07:39:00 -0700 (PDT)
In-Reply-To: <20090520142305.GA14937@redhat.com>
References: <20090520142305.GA14937@redhat.com>
Date: Wed, 20 May 2009 15:11:00 -0000
Message-ID: <6c33472e0905200739x54647acdgac2d7909fc192790@mail.gmail.com>
Subject: Re: [RFC] enabling -fshow-column by default
From: =?ISO-8859-1?Q?Manuel_L=F3pez=2DIb=E1=F1ez?= <lopezibanez@gmail.com>
To: Aldy Hernandez <aldyh@redhat.com>
Cc: gcc@gcc.gnu.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc/>
List-Post: <mailto:gcc@gcc.gnu.org>
List-Help: <http://gcc.gnu.org/ml/>
Sender: gcc-owner@gcc.gnu.org
X-SW-Source: 2009-05/txt/msg00512.txt.bz2

2009/5/20 Aldy Hernandez <aldyh@redhat.com>:
> Hi folks.
>
> Before I merge the diagnostics branch I'd like to enable it on the
> testsuite to get us all in the habit of at least being aware of columns.
>
> Joseph Myers suggested enabling it in the compiler instead of the
> testsuite. =A0Are there any big objections to this?

My only worry is that the testsuite may confuse column and line
numbers and pass/fail tests because of it.

Index: gcc/testsuite/gcc.dg/bogus-column.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- gcc/testsuite/gcc.dg/bogus-column.c	(revision 0)
+++ gcc/testsuite/gcc.dg/bogus-column.c	(revision 0)
@@ -0,0 +1,11 @@
+/* This testcase checks that line numbers are not confused with column
+   numbers.  */
+/* { dg-do compile } */
+/* { dg-options "-fshow-column -fms-extensions -pedantic" } */
+
+/* { dg-bogus "ISO C doesn't support unnamed" "bogus" { target *-*-* } 22 =
} */
+
+struct {
+  struct a { int x; }; /* { dg-warning "22:ISO C doesn't support unnamed" =
} */
+  int bar;
+} hot;


Cheers,

Manuel.