From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14661 invoked by alias); 22 Nov 2009 09:39:16 -0000 Received: (qmail 14652 invoked by uid 22791); 22 Nov 2009 09:39:15 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-ew0-f227.google.com (HELO mail-ew0-f227.google.com) (209.85.219.227) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 22 Nov 2009 09:38:12 +0000 Received: by ewy27 with SMTP id 27so911943ewy.16 for ; Sun, 22 Nov 2009 01:38:09 -0800 (PST) MIME-Version: 1.0 Received: by 10.216.88.75 with SMTP id z53mr1072220wee.46.1258882689639; Sun, 22 Nov 2009 01:38:09 -0800 (PST) In-Reply-To: <4B06EF6F.2050507@redhat.com> References: <20091119072040.GA23579@elte.hu> <1258694593.22249.1012.camel@gandalf.stny.rr.com> <1258736456.22249.1032.camel@gandalf.stny.rr.com> <4B06EF6F.2050507@redhat.com> Date: Sun, 22 Nov 2009 09:39:00 -0000 Message-ID: <6dc9ffc80911220138y15bfa91agccf5c29f1c30e09a@mail.gmail.com> Subject: Re: [PATCH][GIT PULL][v2.6.32] tracing/x86: Add check to detect GCC messing with mcount prologue From: "H.J. Lu" To: Andrew Haley Cc: rostedt@goodmis.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , LKML , Andrew Morton , Heiko Carstens , feng.tang@intel.com, Peter Zijlstra , Frederic Weisbecker , David Daney , Richard Guenther , jakub@redhat.com, gcc , Linus Torvalds Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2009-11/txt/msg00606.txt.bz2 On Fri, Nov 20, 2009 at 11:35 AM, Andrew Haley wrote: > Steven Rostedt wrote: >> Ingo, Thomas and Linus, >> >> I know Thomas did a patch to force the -mtune=3Dgeneric, but just in case >> gcc decides to do something crazy again, this patch will catch it. >> >> Should we try to get this in now? > > I'm sure this makes sense, but a gcc test case would be even better. > If this can be detected in the gcc test suite it'll be found and > fixed long before y'all in kernel land get to see it. =A0That's the > only way to guarantee this never bothers you again. > > H.J., who wrote the code in question, is hopefully looking at why > this odd code is being generated. =A0Once he's done I can put a > suitable test case in the gcc test suite. > See: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D42109#c7 --=20 H.J.