From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2078.outbound.protection.outlook.com [40.107.15.78]) by sourceware.org (Postfix) with ESMTPS id 50DA23857C42 for ; Wed, 6 Mar 2024 15:04:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 50DA23857C42 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 50DA23857C42 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.15.78 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1709737492; cv=pass; b=ZCDNqAg4owntmwefqJrl84Kh/S8S35IDdzwp20C+oEpdlfNArea52riwXUXYhMGtEnnyi9wV5/Qwu8W794XYFA26kr4O4eicuR+6XWTUocA9nOoG65GVw41D7V22oqJarPy05BQXaPz/67snMZMTI0mlocPx09gDe9Fa/MTg1f4= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1709737492; c=relaxed/simple; bh=KQwfkQymySeXjTLg65dCizQKLCAmOPYBsMG0MY+gczg=; h=DKIM-Signature:DKIM-Signature:Date:From:To:Subject:Message-ID: MIME-Version; b=eh88QL5iLjNcDJNRI7EcUGOxUyuTG6cs4qkj3JpTPPN2h8jUYq9B9NwwbbCgv8Rjub4SGfXisFIRGJso0X4/LE4rGqj67dPOCI1bdXRrwTHbWas+vPlLg9GWFZiTergNK1GoAU9puErw3jzY0554Ns0PbxcChiFKHP8SEqewsZY= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=AvgtvwaydDhODvqfM1GIHlsc0Xy3GsqGAXLSRKzuvk/djITlebCXEWKjesQ2r1HRuT+iRgo6TLrjXUZ7YLSnaCPI1mjENrKMT9o2W4+QAeF7ncLEHIgjO41yPEOAszymL3sSMgs3Buycr1LcDaDTuT4GDrEyMlsqZTnHkr4qBPYzRckbkni3aS1btaNmFA61bY0i/6ACxP/5+fIPXJVRpgaozUTwwIRuBYfIUUOhRVwL6dc8IBAv38ICcb94pVOSV+cScgZJJSGoSc+dcoHOr5l2+nzqalhucV+D/sqN6sNsrG393VYYXyZFt3HZ8j5vv/cPunopSUB65Jz+2iIkZA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U3E66vog0ci56NuEqeX0nmSRi1GCq3EgdUDqHcRmUkg=; b=JH4h5NE+zPw5PZ/Y01idrbv8Vr/jQzUPHsZH9WZImnyqBVop7JL4eqDVrMNh+L1WvrbgGbj9tIShkIW7iRIrQLu2PtLhSk2UrWe7rTw057IrAjlcmMTYy/SXnBOO3TRb2okhkd/eA1IsKVErC9AkovUGpFNLyUqFH/avcNycIt4S7V5VaPxD4ZRX2ziBjE8KeEvTz9iXAIhdxQc0+PSWmacDBoUBuiUH/7HTzb+acPEc8RdfJTI7MP+aTJg0SlRx87HwBfmG/BsIkiaGlMFIskOx6FZ8BDVOr5GK/azgqiagLD+ryeYVVLzfN/FBLsg6TAe90Tm/8nqf5V/4SrPPfA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U3E66vog0ci56NuEqeX0nmSRi1GCq3EgdUDqHcRmUkg=; b=kXQulIRlD/RVrNhuY4fDMBR3kotVN6dtVESomgZG48jpiSu+OjnYCotDRH1lkrhN0odlZQZtjv1f7S8Hq0JPS/3xhFyp/DgDOGdnmrbJ0pgbkMpRyofgrLZJvwcmtap5POHfHPAatMJ32BeSnMk9mdunambnypZYf5GAxWO5yvk= Received: from AM6PR05CA0009.eurprd05.prod.outlook.com (2603:10a6:20b:2e::22) by GV2PR08MB8463.eurprd08.prod.outlook.com (2603:10a6:150:b4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.38; Wed, 6 Mar 2024 15:04:35 +0000 Received: from AMS1EPF0000004E.eurprd04.prod.outlook.com (2603:10a6:20b:2e:cafe::82) by AM6PR05CA0009.outlook.office365.com (2603:10a6:20b:2e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.24 via Frontend Transport; Wed, 6 Mar 2024 15:04:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AMS1EPF0000004E.mail.protection.outlook.com (10.167.16.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.11 via Frontend Transport; Wed, 6 Mar 2024 15:04:35 +0000 Received: ("Tessian outbound 6a48a1f51a3c:v276"); Wed, 06 Mar 2024 15:04:34 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4f1388466e7f6c19 X-CR-MTA-TID: 64aa7808 Received: from b2fee845e838.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 66078EA1-484C-43BD-9EED-A8C09B45F9E7.1; Wed, 06 Mar 2024 15:04:28 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b2fee845e838.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Mar 2024 15:04:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PUbG8cx+dz7GptE3pqXXuDVilOIpP9gpCGJcblbCkoF23hd12h6NyuXuSykN+vUwrTvZTic4TS9560Mx7gBgA96pmdFp5BYqULlAyoeRjVudJuodUHMVchGJ39wZZeSi3dnGZnMWDwiBg0IHJgoaJj9IPl8qMP4NQGRAvl3sFGqXkPOyp2nXcu0xspdCVM53BhQGJVkW6KgCYR8mW6JAw026czaG7UsncpAmdLPp8ZkF66Ckwu4pYaF4aEsWkltGW9gU4FGJle6wqgdF9AVPabbX3ATufBQnMJqujWQazJn5bz69vyOt5UFuqGkGmE+GRXZm9Rj8yNn4AjS/CqMM6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U3E66vog0ci56NuEqeX0nmSRi1GCq3EgdUDqHcRmUkg=; b=dYQkgY5f8QsktSS/8HF3w06mdEQQDgktdWyOVV0ODZ9xV5bEVkyAngLY3KcTJwiy4YmzMcZmfVSB7D2f41xbjRwsk3vWihGDldfovfR+iSZnakoIcI5M/q5oZ7J1Mnrdrj9Ie4R5pj+sQpU1qdJdiRVcsemGOX22Fd+dOiQMf5CX2j15pWN+6ilSJJkpYXdGWVTXIE03BywN51TbUdvu3GxM0LsgWKeu2Ji0F9LTmSZJf/wTWDpAfhcjIxOrKnnDsPQSRysn/rRV4zXWnNeZDH82osXRHTCXWtEWu6JLWbTrDfEC+oG0FCHBkYKDvFjol0CXXcZ/ABOPWcUUOClyow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U3E66vog0ci56NuEqeX0nmSRi1GCq3EgdUDqHcRmUkg=; b=kXQulIRlD/RVrNhuY4fDMBR3kotVN6dtVESomgZG48jpiSu+OjnYCotDRH1lkrhN0odlZQZtjv1f7S8Hq0JPS/3xhFyp/DgDOGdnmrbJ0pgbkMpRyofgrLZJvwcmtap5POHfHPAatMJ32BeSnMk9mdunambnypZYf5GAxWO5yvk= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6678.eurprd08.prod.outlook.com (2603:10a6:20b:398::8) by DU0PR08MB8042.eurprd08.prod.outlook.com (2603:10a6:10:3e6::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.39; Wed, 6 Mar 2024 15:04:24 +0000 Received: from AS8PR08MB6678.eurprd08.prod.outlook.com ([fe80::1fe3:601e:cf90:c88c]) by AS8PR08MB6678.eurprd08.prod.outlook.com ([fe80::1fe3:601e:cf90:c88c%3]) with mapi id 15.20.7339.035; Wed, 6 Mar 2024 15:04:24 +0000 Date: Wed, 6 Mar 2024 15:04:21 +0000 From: Andrew Carlotti To: Christophe Lyon Cc: Mark Wielaard , binutils@sourceware.org, GCC Mailing List , gdb-patches@sourceware.org Subject: Re: Help needed with maintainer-mode Message-ID: <70455fee-b67a-2f85-b93e-76c735564796@e124511.cambridge.arm.com> References: <20240229110039.GB18580@gnu.wildebeest.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO6P123CA0046.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:310::8) To AS8PR08MB6678.eurprd08.prod.outlook.com (2603:10a6:20b:398::8) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6678:EE_|DU0PR08MB8042:EE_|AMS1EPF0000004E:EE_|GV2PR08MB8463:EE_ X-MS-Office365-Filtering-Correlation-Id: 25614a34-24c9-43b3-d2a3-08dc3deebc50 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4Q1ntGRuJuZw0lkw9TUuBP4Hga1iYhbzq9YA5OCGO66AHuWg1cCB7pnBEoRfZSXKpXaE9xXZ8TQDw5H6XEcNrEDLLbi6Dl7NS975i91p0fYePDfvrIHq9M2AC9sxAzmYHM8c1CHQLe2XDSMOhgZ77Z6yAUTh8VKcJfXloQloeO9nmLiW7oNqIEOX/ZLyAimG1EPcW4Uho3qa3Z6l5Hd9HVFTCty/zM5sNHt91jLMX0OHIepAikZeonPba+zDDspEiqzGBPA6h4HiRjcFN/4uVf6QvNQEpaXosyagLpU6rL6d6CxtQ6y8c91H/g6WnbgROiNMiMwahxtVR/9haVGbV2rmCvemOZL5m8JBUkpYQCEcynsI51ZFy0Ums21NfgExYuTgYV6b43uEADn2yYxUnrTzGHiG7kA7R8K+Hz7xWGmYIkll8FxuhqARFGF7Cf/CYEHppYfrmK0RxOf+NbRJeu5sGCQfu1H+qoVpjFd3iKpJLL4YwwgiLIwZz0y8g52FvzcWIvRgPRBfWNVCiCDx5+viGTqPErt19u/we8QWfN/qJZpzX08NEGFYtpzZNcaRwwuXMpYflu3i0jv+cqvv5+6FVooVZ4PE8nomjPE5KdWNdcHWXaaH7vjOKjrwvTxH X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6678.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8042 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS1EPF0000004E.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: bae5fbf6-7b31-4f9b-9771-08dc3deeb5c0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o9LI7w9JL9nUrGLXkBU9EQyYDs7lySZJvaoFev17E10YRYARq1WOz0+pG8ws3rJ9kk5Y6C2L8IHw8QgsK2mtuSdjsSmgwB8+OXvqBXwJUUp2akWsQmk2ONiEXkIqQ+CsrDlaMKonrU+mp+QxUb9/VkuOmSaKi7AjChOi1AoJYIRvjgaCA9wKJ0EeN4qaLctGbRjhbi1HD3fvIfzW73aNInjY9mMVGERANoxYMdSKMWonUp21PE8wzTStrmStVSYVW3SvOLiNiGtAY3TFx6+ZB3HRgKcPXJi071bal+plDwxzzFcTQJCcNg74J182XzoeRwDeesIv+2Pvm/W5F8C75KLoepJh8glrJW9vnXzEa9R9nJbFer+HWu5z5nPzXaGDR+LZTpRxxXAW4u12xIBCu61fyACLzA154YOs6469KfjbEi4IAVsTV/dlOIG0zS3uDy8GR9bLkp0dSSnvdK95r3FkSI5Uu8MtA9GE3fKC3BwFP34mBVcuGEsrFe7jUt9vJ1f2KmUXoO+8MNh58/ND979mDeoopc/uTTgW9n3ZU9s9hDbpybqEhwAMI0oZ6KJApD8U6cnvBv/0eZPbPvWRhf2gBctGGKyci9KHu0hUGEWvJBV7YIVHLH9sekHPW+JJpbNlD8YS7sRI9fm4pd+ehU8P+FbNIRcAtT7TAcJhOBV/sBoN6ntV8zNI11+Nku1A5SAcxV3Jqye4XUhtND16GQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(376005)(82310400014)(36860700004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2024 15:04:35.0223 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 25614a34-24c9-43b3-d2a3-08dc3deebc50 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF0000004E.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8463 X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Feb 29, 2024 at 06:39:54PM +0100, Christophe Lyon via Gcc wrote: > On Thu, 29 Feb 2024 at 12:00, Mark Wielaard wrote: > > > > Hi Christophe, > > > > On Thu, Feb 29, 2024 at 11:22:33AM +0100, Christophe Lyon via Gcc wrote: > > > I've noticed that sourceware's buildbot has a small script > > > "autoregen.py" which does not use the project's build system, but > > > rather calls aclocal/autoheader/automake/autoconf in an ad-hoc way. > > > Should we replicate that? > > > > That python script works across gcc/binutils/gdb: > > https://sourceware.org/cgit/builder/tree/builder/containers/autoregen.py > > > > It is installed into a container file that has the exact autoconf and > > automake version needed to regenerate the autotool files: > > https://sourceware.org/cgit/builder/tree/builder/containers/Containerfile-autotools > > > > And it was indeed done this way because that way the files are > > regenerated in a reproducible way. Which wasn't the case when using --enable-maintainer-mode (and autoreconfig also doesn't work). > > I see. So it is possibly incomplete, in the sense that it may lack > some of the steps that maintainer-mode would perform? > For instance, gas for aarch64 has some *opcodes*.c files that need > regenerating before committing. The regeneration step is enabled in > maintainer-mode, so I guess the autoregen bots on Sourceware would > miss a problem with these files? > > Thanks, > > Christophe Speaking of opcodes/aarch64-{asm|dis|opc}-2.c - why are these in the source directory in the first place? For a similar situation in GCC (gimple-match, generic-match, insn-emit, etc.) we write the generated files to the build directory, and generation is always enabled. I see no reason not to do the same thing for aarch64-{asm|dis|opc}-2.c. Andrew > > > > It is run on all commits and warns if it detects a change in the > > (checked in) generated files. > > https://builder.sourceware.org/buildbot/#/builders/gcc-autoregen > > https://builder.sourceware.org/buildbot/#/builders/binutils-gdb-autoregen > > > > Cheers, > > > > Mark