public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrew Pinski <pinskia@physics.uc.edu>
To: GCC ML <gcc@gcc.gnu.org>, Andrew Pinski <pinskia@physics.uc.edu>
Cc: fortran@gcc.gnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [rfc] towards a defined abi for libgfortran
Date: Sat, 11 Dec 2004 03:55:00 -0000	[thread overview]
Message-ID: <72BE8881-4B28-11D9-8186-000A95D692F4@physics.uc.edu> (raw)
In-Reply-To: <DA243E46-47ED-11D9-840F-000A95D692F4@physics.uc.edu>


On Dec 6, 2004, at 8:18 PM, Andrew Pinski wrote:

>
> On Dec 6, 2004, at 7:41 PM, Richard Henderson wrote:
>
>> A prerequisite for being able to point to an ABI is symbol access 
>> control.
>> Namely, you don't want to expose any symbols that you don't mean to 
>> expose.
>>
>> The following patch replaces the prefix macro with a set of fine-grain
>> macros that do allow us to control which symbols are seen by user 
>> apps.
>>
>> On elf systems, it will use __attribute__((visibility("hidden"))) to
>> prevent specific symbols from escaping the library.  It will also use
>> __attribute__((alias(...))) to reduce the number of PLT entries needed
>> when calling routines that we do intend to export.
>> Comments?
>
> I will test this on darwin which has visibility("hidden") but not 
> alias.

This failed but due to a compiler bug.
The following code is not able to compile on darwin because
the target says options is defined when it is not because it is
a common symbol.

int options  __attribute__((__visibility__("hidden")));

void f(void)
{
   options = 0;
}

I will look into fixing this and test the patch again.  This is a
regression from when Mark rewrote part of the darwin backend.

Thanks,
Andrew Pinski

       reply	other threads:[~2004-12-11  3:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20041207004150.GA5856@twiddle.net>
     [not found] ` <DA243E46-47ED-11D9-840F-000A95D692F4@physics.uc.edu>
2004-12-11  3:55   ` Andrew Pinski [this message]
2004-12-11  6:57     ` Andrew Pinski
2004-12-14  0:58       ` Mike Stump
2004-12-14  1:14         ` Mike Stump

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72BE8881-4B28-11D9-8186-000A95D692F4@physics.uc.edu \
    --to=pinskia@physics.uc.edu \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc@gcc.gnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).