From: "Martin Liška" <mliska@suse.cz>
To: Dmitry Vyukov <dvyukov@google.com>, gcc <gcc@gcc.gnu.org>
Cc: ro@gcc.gnu.org, "Jakub Jelinek" <jakub@redhat.com>,
"Martin Liška" <marxin@gcc.gnu.org>,
"Marco Elver" <elver@google.com>,
"Alexander Potapenko" <glider@google.com>
Subject: Re: New ThreadSanitizer runtime (v3)
Date: Mon, 22 Nov 2021 19:38:17 +0100 [thread overview]
Message-ID: <7506afec-035a-bf4f-1dd7-f022423f4627@suse.cz> (raw)
In-Reply-To: <CACT4Y+bvVooxDChy120qBz2jaT6=HVw+e+ZtGeaxUut4ND+FNg@mail.gmail.com>
On 11/22/21 16:22, Dmitry Vyukov wrote:
> I wanted to give heads up regarding a significant re-design of the
> ThreadSanitizer runtime:
> https://reviews.llvm.org/D112603
> Currently it's submitted:
> https://github.com/llvm/llvm-project/commit/1784fe0532a69ead17793bced060a9bf9d232027
And I noticed the following new warnings:
libsanitizer/tsan/tsan_shadow.h:93:32: warning: enumerated and non-enumerated type in conditional expression [-Wextra]
libsanitizer/tsan/tsan_shadow.h:94:44: warning: enumerated and non-enumerated type in conditional expression [-Wextra]
*typ = (part_.is_read_ ? kAccessRead : kAccessWrite) |
(part_.is_atomic_ ? kAccessAtomic : 0) |
(part_.access_ == kFreeAccess ? kAccessFree : 0);
I think 0 should be replaced with kAccessWrite, am I right? Should I create a pull request for it?
Cheers,
Martin
next prev parent reply other threads:[~2021-11-22 18:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 15:22 Dmitry Vyukov
2021-11-22 18:30 ` Martin Liška
2021-11-22 19:00 ` Dmitry Vyukov
2021-11-22 19:07 ` Martin Liška
2021-11-22 19:54 ` Marco Elver
2021-11-22 19:20 ` Jakub Jelinek
2021-11-22 18:38 ` Martin Liška [this message]
2021-11-22 19:01 ` Dmitry Vyukov
2021-11-29 18:16 ` Martin Liška
2021-11-30 4:17 ` Dmitry Vyukov
2021-12-23 12:10 ` Martin Liška
2021-12-23 12:21 ` Dmitry Vyukov
2021-11-23 13:49 ` Florian Weimer
2021-11-23 13:51 ` Dmitry Vyukov
2021-11-23 13:59 ` Florian Weimer
2021-11-23 15:37 ` Dmitry Vyukov
2021-11-23 16:16 ` Florian Weimer
2021-11-23 16:52 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7506afec-035a-bf4f-1dd7-f022423f4627@suse.cz \
--to=mliska@suse.cz \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=gcc@gcc.gnu.org \
--cc=glider@google.com \
--cc=jakub@redhat.com \
--cc=marxin@gcc.gnu.org \
--cc=ro@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).