From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 118473858400; Mon, 22 Nov 2021 18:38:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 118473858400 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A3428218EF; Mon, 22 Nov 2021 18:38:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1637606297; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bvjMaOGkr6j/aC9fwIdJPNnbEThWvFUDIEri0OAgWz0=; b=pTa7YAm4APw4+VfvVGvVPVaey0z9Gwv/35kO36GaVKBvcb/Niithy5KJX5WgNPkbKITDwI sIQe9CzSjjtRdUksut8PK4NcIH0rbLE1yTLQtpprwuFLHLI6d6v4thX6zR+qyIR5tfZBbo 6tGRTHZhY7cojNZ+wKr7mdmZign5PV4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1637606297; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bvjMaOGkr6j/aC9fwIdJPNnbEThWvFUDIEri0OAgWz0=; b=JVcHU+mgIhlXJjpSODNq+ZJejfpred8krvXPCQu+Fn5h4aSb6mlwPP0ooQOFkIR2B3lQQ1 T9lWDavM2hOrQMCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7733F13B0A; Mon, 22 Nov 2021 18:38:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JsCxG5njm2GRZwAAMHmgww (envelope-from ); Mon, 22 Nov 2021 18:38:17 +0000 Message-ID: <7506afec-035a-bf4f-1dd7-f022423f4627@suse.cz> Date: Mon, 22 Nov 2021 19:38:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: New ThreadSanitizer runtime (v3) Content-Language: en-US To: Dmitry Vyukov , gcc Cc: ro@gcc.gnu.org, Jakub Jelinek , =?UTF-8?Q?Martin_Li=c5=a1ka?= , Marco Elver , Alexander Potapenko References: From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Nov 2021 18:38:20 -0000 On 11/22/21 16:22, Dmitry Vyukov wrote: > I wanted to give heads up regarding a significant re-design of the > ThreadSanitizer runtime: > https://reviews.llvm.org/D112603 > Currently it's submitted: > https://github.com/llvm/llvm-project/commit/1784fe0532a69ead17793bced060a9bf9d232027 And I noticed the following new warnings: libsanitizer/tsan/tsan_shadow.h:93:32: warning: enumerated and non-enumerated type in conditional expression [-Wextra] libsanitizer/tsan/tsan_shadow.h:94:44: warning: enumerated and non-enumerated type in conditional expression [-Wextra] *typ = (part_.is_read_ ? kAccessRead : kAccessWrite) | (part_.is_atomic_ ? kAccessAtomic : 0) | (part_.access_ == kFreeAccess ? kAccessFree : 0); I think 0 should be replaced with kAccessWrite, am I right? Should I create a pull request for it? Cheers, Martin