From: Jeffrey A Law <law@hurl.cygnus.com>
To: hjl@lucon.org (H.J. Lu)
Cc: martin@mira.isdn.cs.tu-berlin.de (Martin v. Loewis),
egcs@egcs.cygnus.com, egcs-patches@egcs.cygnus.com
Subject: Re: multiple definitions of 'xxx keyed to...' in egcs-1.1.1
Date: Sun, 21 Feb 1999 15:15:00 -0000 [thread overview]
Message-ID: <7774.919638865@hurl.cygnus.com> (raw)
In-Reply-To: Your message of Sat, 20 Feb 1999 16:11:03 MST. < m10EMUB-000392C@ocean.lucon.org >
In message < m10EMUB-000392C@ocean.lucon.org >you write:
> >
> > > * decl2.c (start_objects): Make file scope constructors and
> > > destructors local to the file if ASM_OUTPUT_CONSTRUCTOR and
> > > ASM_OUTPUT_DESTRUCTOR are defined.
> >
> > This is incorrect. Please look at config/aoutos.h. It always defines
> > ASM_OUTPUT_CONSTRUCTOR, but then decides, at runtime, whether to use
> > GNU binutils. If GNU ld is not used, no __CTOR_LIST__ is constructed,
> > and collect2 would have to find constructors. Now that you made them
> > static, this would fail.
> >
>
> That is bogus. Please take a look at how ASM_OUTPUT_CONSTRUCTOR is
> used. If ASM_OUTPUT_CONSTRUCTOR is not defined, egcs will check whether
> to use the gnu linker. Why does config/aoutos.h to have duplicate
> what is in the egcs backend?
I think you missed the most critical point behind Martin's objection.
Your change, as-is will break a port.
You need to address this problem in some manner (I think there have been
suggestions posted to the list).
There's still the issue of breaking NT, VMS and a variety of COFF systems
too with your patch.
jeff
WARNING: multiple messages have this Message-ID
From: Jeffrey A Law <law@hurl.cygnus.com>
To: hjl@lucon.org (H.J. Lu)
Cc: martin@mira.isdn.cs.tu-berlin.de (Martin v. Loewis),
egcs@egcs.cygnus.com, egcs-patches@egcs.cygnus.com
Subject: Re: multiple definitions of 'xxx keyed to...' in egcs-1.1.1
Date: Sun, 28 Feb 1999 22:53:00 -0000 [thread overview]
Message-ID: <7774.919638865@hurl.cygnus.com> (raw)
Message-ID: <19990228225300.mhKXqh8EgRHTHYxHltadgrve6aMVxaK-IFQji_ekqaw@z> (raw)
In-Reply-To: <m10EMUB-000392C@ocean.lucon.org>
In message < m10EMUB-000392C@ocean.lucon.org >you write:
> >
> > > * decl2.c (start_objects): Make file scope constructors and
> > > destructors local to the file if ASM_OUTPUT_CONSTRUCTOR and
> > > ASM_OUTPUT_DESTRUCTOR are defined.
> >
> > This is incorrect. Please look at config/aoutos.h. It always defines
> > ASM_OUTPUT_CONSTRUCTOR, but then decides, at runtime, whether to use
> > GNU binutils. If GNU ld is not used, no __CTOR_LIST__ is constructed,
> > and collect2 would have to find constructors. Now that you made them
> > static, this would fail.
> >
>
> That is bogus. Please take a look at how ASM_OUTPUT_CONSTRUCTOR is
> used. If ASM_OUTPUT_CONSTRUCTOR is not defined, egcs will check whether
> to use the gnu linker. Why does config/aoutos.h to have duplicate
> what is in the egcs backend?
I think you missed the most critical point behind Martin's objection.
Your change, as-is will break a port.
You need to address this problem in some manner (I think there have been
suggestions posted to the list).
There's still the issue of breaking NT, VMS and a variety of COFF systems
too with your patch.
jeff
next prev parent reply other threads:[~1999-02-21 15:15 UTC|newest]
Thread overview: 255+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-01-29 17:26 H.J. Lu
1999-01-30 12:51 ` Alexandre Oliva
1999-01-30 13:44 ` H.J. Lu
1999-01-30 18:38 ` Jeffrey A Law
1999-01-31 9:28 ` H.J. Lu
1999-01-31 23:58 ` Martin v. Loewis
1999-02-01 7:02 ` H.J. Lu
[not found] ` < m107Krt-00038sC@ocean.lucon.org >
1999-02-01 15:22 ` Martin v. Loewis
[not found] ` < 199902012314.AAA00681@mira.isdn.cs.tu-berlin.de >
1999-02-02 7:12 ` H.J. Lu
[not found] ` < m107hUo-000392C@ocean.lucon.org >
1999-02-02 14:22 ` Martin v. Loewis
[not found] ` < 199902022216.XAA01250@mira.isdn.cs.tu-berlin.de >
1999-02-04 6:36 ` H.J. Lu
[not found] ` < m108PtF-00038sC@ocean.lucon.org >
1999-02-13 11:26 ` Jeffrey A Law
[not found] ` < 12451.918933918@hurl.cygnus.com >
1999-02-13 12:13 ` Martin v. Loewis
[not found] ` < 199902132010.VAA04139@mira.isdn.cs.tu-berlin.de >
1999-02-13 15:16 ` H.J. Lu
[not found] ` < m10BoHn-000392C@ocean.lucon.org >
1999-02-13 15:21 ` Jeffrey A Law
[not found] ` < 13364.918948012@hurl.cygnus.com >
1999-02-13 15:41 ` H.J. Lu
[not found] ` < m10Boh4-000392C@ocean.lucon.org >
1999-02-13 21:42 ` Jeffrey A Law
[not found] ` < 13959.918970867@hurl.cygnus.com >
1999-02-15 17:00 ` H.J. Lu
[not found] ` < m10CYsJ-00038sC@ocean.lucon.org >
1999-02-15 17:46 ` Mark Mitchell
[not found] ` < 199902160149.RAA28975@adsl-206-170-148-33.dsl.pacbell.net >
1999-02-15 17:50 ` H.J. Lu
[not found] ` < m10CZeU-00038sC@ocean.lucon.org >
1999-02-15 18:10 ` Mark Mitchell
[not found] ` < 199902160212.SAA29229@adsl-206-170-148-33.dsl.pacbell.net >
1999-02-17 13:39 ` Kamil Iskra
[not found] ` < Pine.LNX.3.96.990217221633.1697A-100000@jinks.home >
1999-02-17 13:45 ` Zack Weinberg
1999-02-28 22:53 ` Zack Weinberg
1999-02-28 22:53 ` Kamil Iskra
1999-02-28 22:53 ` Mark Mitchell
[not found] ` <199902160212.SAA29229.cygnus.egcs@adsl-206-170-148-33.dsl.pacbell.net>
1999-02-16 10:51 ` Jason Merrill
[not found] ` < u9ww1ii3mw.fsf@yorick.cygnus.com >
1999-02-16 11:29 ` Mark Mitchell
1999-02-17 0:26 ` Steinar Bang
1999-02-28 22:53 ` Steinar Bang
1999-02-28 22:53 ` Mark Mitchell
1999-02-16 23:23 ` Jeffrey A Law
1999-02-16 23:33 ` Jason Merrill
[not found] ` < u9iud1iiwm.fsf@yorick.cygnus.com >
1999-02-17 6:49 ` H.J. Lu
[not found] ` < m10D8I7-00038sC@ocean.lucon.org >
1999-02-17 11:45 ` Jeffrey A Law
1999-02-17 12:38 ` Jason Merrill
[not found] ` < u990dwix4w.fsf@yorick.cygnus.com >
1999-02-18 6:42 ` H.J. Lu
[not found] ` < m10DUeS-00038sC@ocean.lucon.org >
1999-02-20 12:47 ` Jeffrey A Law
[not found] ` < 4798.919543586@hurl.cygnus.com >
1999-02-20 12:55 ` H.J. Lu
[not found] ` < m10EJQj-000392C@ocean.lucon.org >
1999-02-20 12:58 ` Jeffrey A Law
[not found] ` < 4881.919544286@hurl.cygnus.com >
1999-02-20 13:02 ` H.J. Lu
[not found] ` < m10EJXX-000392C@ocean.lucon.org >
1999-02-20 13:09 ` Jeffrey A Law
[not found] ` < 4941.919544939@hurl.cygnus.com >
1999-02-20 13:12 ` H.J. Lu
1999-02-28 22:53 ` Jeffrey A Law
1999-02-20 13:33 ` Robert Lipe
[not found] ` < 19990220153254.A8783@rjlhome.sco.com >
1999-02-20 14:36 ` Jeffrey A Law
1999-02-28 22:53 ` Jeffrey A Law
1999-02-28 22:53 ` Robert Lipe
1999-02-28 22:53 ` H.J. Lu
1999-02-22 0:46 ` Andris Pavenis
1999-02-28 22:53 ` Andris Pavenis
1999-02-28 22:53 ` Jeffrey A Law
1999-02-20 13:17 ` Jeffrey A Law
1999-02-28 22:53 ` Jeffrey A Law
1999-02-20 13:34 ` Mumit Khan
1999-02-28 22:53 ` Mumit Khan
1999-02-20 15:35 ` Martin v. Loewis
[not found] ` < 199902202335.AAA06542@mira.isdn.cs.tu-berlin.de >
1999-02-20 16:11 ` H.J. Lu
[not found] ` < m10EMUB-000392C@ocean.lucon.org >
1999-02-21 15:15 ` Jeffrey A Law [this message]
1999-02-28 22:53 ` Jeffrey A Law
1999-02-28 22:53 ` H.J. Lu
1999-02-28 22:53 ` Martin v. Loewis
1999-02-21 13:59 ` Jason Merrill
[not found] ` < u9vhgvfmfa.fsf@yorick.cygnus.com >
1999-02-21 15:22 ` Jeffrey A Law
[not found] ` < 7817.919639310@hurl.cygnus.com >
1999-02-21 15:28 ` Jeffrey A Law
1999-02-28 22:53 ` Jeffrey A Law
1999-02-21 16:16 ` Jason Merrill
[not found] ` < u9lnhrfg3k.fsf@yorick.cygnus.com >
1999-02-21 16:40 ` Jeffrey A Law
[not found] ` < 8103.919644009@hurl.cygnus.com >
1999-02-21 17:07 ` Richard Henderson
[not found] ` < 19990221170738.A22156@cygnus.com >
1999-02-21 17:16 ` Jeffrey A Law
1999-02-28 22:53 ` Jeffrey A Law
1999-02-28 22:53 ` Richard Henderson
1999-02-28 22:53 ` Jeffrey A Law
1999-02-28 22:53 ` Jason Merrill
1999-02-28 22:53 ` Jeffrey A Law
1999-02-28 22:53 ` Jason Merrill
1999-02-28 22:53 ` H.J. Lu
1999-02-28 22:53 ` Jeffrey A Law
1999-02-28 22:53 ` H.J. Lu
1999-02-20 12:58 ` Zack Weinberg
[not found] ` < 199902202057.PAA22565@blastula.phys.columbia.edu >
1999-02-20 13:28 ` Jeffrey A Law
[not found] ` < 5066.919546022@hurl.cygnus.com >
1999-02-20 13:35 ` Zack Weinberg
[not found] ` < 199902202135.QAA23017@blastula.phys.columbia.edu >
1999-02-20 13:42 ` Jeffrey A Law
1999-02-28 22:53 ` Jeffrey A Law
1999-02-20 15:40 ` Martin v. Loewis
[not found] ` < 199902202338.AAA06546@mira.isdn.cs.tu-berlin.de >
1999-02-21 3:45 ` Kamil Iskra
[not found] ` < Pine.LNX.3.96.990221120241.903C-100000@jinks.home >
1999-02-21 11:20 ` Martin v. Loewis
1999-02-28 22:53 ` Martin v. Loewis
1999-02-28 22:53 ` Kamil Iskra
1999-02-28 22:53 ` Martin v. Loewis
1999-02-28 22:53 ` Zack Weinberg
1999-02-21 18:22 ` the jackal
[not found] ` < 19990221211950.B10271@diwanh.stu.rpi.edu >
1999-02-21 18:47 ` Jeffrey A Law
1999-02-28 22:53 ` Jeffrey A Law
1999-02-28 22:53 ` the jackal
1999-02-28 22:53 ` Jeffrey A Law
1999-02-22 0:40 ` Andris Pavenis
[not found] ` < 99022210384700.00200@hal >
1999-02-22 6:59 ` H.J. Lu
1999-02-24 0:18 ` Andris Pavenis
1999-02-28 22:53 ` Andris Pavenis
1999-02-28 22:53 ` H.J. Lu
1999-02-28 22:53 ` Andris Pavenis
1999-02-28 22:53 ` Zack Weinberg
1999-02-20 12:58 ` H.J. Lu
[not found] ` < m10EJTY-000392C@ocean.lucon.org >
1999-02-20 13:04 ` Jeffrey A Law
[not found] ` < 4923.919544645@hurl.cygnus.com >
1999-02-20 13:15 ` H.J. Lu
[not found] ` < m10EJjp-000392C@ocean.lucon.org >
1999-02-20 15:40 ` Martin v. Loewis
1999-02-28 22:53 ` Martin v. Loewis
1999-02-28 22:53 ` H.J. Lu
1999-02-28 22:53 ` Jeffrey A Law
1999-02-28 22:53 ` H.J. Lu
1999-02-28 22:53 ` Jeffrey A Law
1999-02-28 22:53 ` H.J. Lu
1999-02-28 22:53 ` Jason Merrill
[not found] ` < 26163.919280679@hurl.cygnus.com >
1999-02-17 15:45 ` Martin v. Loewis
[not found] ` < 199902172339.AAA01000@mira.isdn.cs.tu-berlin.de >
1999-02-17 15:48 ` Jeffrey A Law
[not found] ` < 26749.919295221@hurl.cygnus.com >
1999-02-17 16:37 ` Martin v. Loewis
1999-02-28 22:53 ` Martin v. Loewis
1999-02-28 22:53 ` Jeffrey A Law
1999-02-28 22:53 ` Martin v. Loewis
1999-02-28 22:53 ` Jeffrey A Law
1999-02-28 22:53 ` H.J. Lu
1999-02-21 20:30 ` Jeffrey A Law
1999-02-28 22:53 ` Jeffrey A Law
1999-02-28 22:53 ` Jason Merrill
1999-02-28 22:53 ` Jeffrey A Law
1999-02-28 22:53 ` Jason Merrill
1999-02-28 22:53 ` H.J. Lu
1999-02-28 22:53 ` Mark Mitchell
1999-02-28 22:53 ` H.J. Lu
1999-02-28 22:53 ` Jeffrey A Law
1999-02-28 22:53 ` H.J. Lu
1999-02-14 4:39 ` egcs and linux Steinar Bang
[not found] ` < wh1zjtgnwy.fsf@viffer.oslo.metis.no >
1999-02-14 7:06 ` Marc Espie
1999-02-14 7:23 ` Steinar Bang
[not found] ` < whogmxdn6i.fsf@viffer.oslo.metis.no >
1999-02-14 8:01 ` Jeffrey A Law
1999-02-28 22:53 ` Jeffrey A Law
1999-02-28 22:53 ` Steinar Bang
1999-02-28 22:53 ` Marc Espie
1999-02-14 8:00 ` Jeffrey A Law
1999-02-14 8:05 ` Steinar Bang
[not found] ` < whemntdl8m.fsf@viffer.oslo.metis.no >
1999-02-14 8:10 ` Jeffrey A Law
1999-02-28 22:53 ` Jeffrey A Law
1999-02-28 22:53 ` Steinar Bang
1999-02-28 22:53 ` Jeffrey A Law
1999-02-14 9:39 ` Scott McDermott
1999-02-14 10:00 ` Steinar Bang
1999-02-28 22:53 ` Steinar Bang
1999-02-28 22:53 ` Scott McDermott
1999-02-14 22:47 ` Joe Buck
[not found] ` < 199902150645.WAA17085@atrus.synopsys.com >
1999-02-15 17:40 ` H.J. Lu
[not found] ` < m10CZUe-00038sC@ocean.lucon.org >
1999-02-16 9:58 ` Joe Buck
[not found] ` < 199902161756.JAA18794@atrus.synopsys.com >
1999-02-16 20:13 ` H.J. Lu
1999-02-16 20:55 ` Scott Bambrough
1999-02-28 22:53 ` Scott Bambrough
1999-02-28 22:53 ` H.J. Lu
1999-02-18 15:37 ` Horst von Brand
1999-02-28 22:53 ` Horst von Brand
1999-02-28 22:53 ` Joe Buck
1999-02-16 10:06 ` Joe Buck
[not found] ` < 199902161805.KAA18983@atrus.synopsys.com >
1999-02-16 20:02 ` H.J. Lu
1999-02-28 22:53 ` H.J. Lu
1999-02-28 22:53 ` Joe Buck
1999-02-28 22:53 ` H.J. Lu
1999-02-28 22:53 ` Joe Buck
1999-02-28 22:53 ` Steinar Bang
1999-02-28 22:53 ` multiple definitions of 'xxx keyed to...' in egcs-1.1.1 Jeffrey A Law
1999-02-28 22:53 ` H.J. Lu
1999-02-15 22:50 ` Jeffrey A Law
[not found] ` < 20471.919147770@hurl.cygnus.com >
1999-02-16 0:39 ` Martin v. Loewis
[not found] ` < 199902160838.JAA00531@mira.isdn.cs.tu-berlin.de >
1999-02-16 0:45 ` Jeffrey A Law
[not found] ` < 20770.919154653@hurl.cygnus.com >
1999-02-16 14:06 ` Martin v. Loewis
1999-02-28 22:53 ` Martin v. Loewis
1999-02-28 22:53 ` Jeffrey A Law
1999-02-16 1:04 ` Steinar Bang
1999-02-28 22:53 ` Steinar Bang
[not found] ` <20770.919154653.cygnus.egcs@hurl.cygnus.com>
1999-02-16 10:47 ` Jason Merrill
[not found] ` < u9yalyi3t6.fsf@yorick.cygnus.com >
1999-02-16 10:56 ` Joe Buck
1999-02-28 22:53 ` Joe Buck
1999-02-16 11:19 ` Jeffrey A Law
1999-02-28 22:53 ` Jeffrey A Law
1999-02-28 22:53 ` Jason Merrill
1999-02-28 22:53 ` Martin v. Loewis
1999-02-16 6:57 ` H.J. Lu
1999-02-28 22:53 ` H.J. Lu
1999-02-28 22:53 ` Jeffrey A Law
1999-02-28 22:53 ` Martin v. Loewis
[not found] ` <199902132010.VAA04139.cygnus.egcs@mira.isdn.cs.tu-berlin.de>
1999-02-14 21:44 ` Jason Merrill
[not found] ` < u9btiwjk5k.fsf@yorick.cygnus.com >
1999-02-15 17:43 ` H.J. Lu
1999-02-28 22:53 ` H.J. Lu
1999-02-28 22:53 ` Jason Merrill
1999-02-28 22:53 ` Jeffrey A Law
1999-02-28 22:53 ` H.J. Lu
1999-02-28 22:53 ` Martin v. Loewis
1999-02-28 22:53 ` H.J. Lu
1999-02-13 11:25 ` Jeffrey A Law
[not found] ` < 12441.918933847@hurl.cygnus.com >
1999-02-13 12:08 ` Martin v. Loewis
1999-02-28 22:53 ` Martin v. Loewis
1999-02-28 22:53 ` Jeffrey A Law
1999-02-28 22:53 ` Martin v. Loewis
1999-02-28 22:53 ` H.J. Lu
1999-02-01 7:03 ` James Mansion
1999-02-28 22:53 ` James Mansion
1999-01-31 23:58 ` Jeffrey A Law
1999-01-31 23:58 ` H.J. Lu
1999-01-31 23:58 ` Alexandre Oliva
-- strict thread matches above, loose matches on Subject: below --
1999-02-22 16:28 Mike Stump
1999-02-28 22:53 ` Mike Stump
1999-01-29 20:09 H.J. Lu
[not found] <m106Duw-000396C@ocean.lucon.org>
1999-01-29 17:26 ` Steinar Bang
1999-01-21 0:36 Steinar Bang
1999-01-21 2:44 ` Steinar Bang
1999-01-21 23:48 ` Steinar Bang
1999-01-22 0:37 ` H.J. Lu
1999-01-22 0:42 ` Steinar Bang
1999-01-22 0:48 ` H.J. Lu
1999-01-22 1:21 ` Steinar Bang
1999-01-22 8:27 ` H.J. Lu
1999-01-25 1:44 ` Steinar Bang
1999-01-31 23:58 ` Steinar Bang
1999-01-31 23:58 ` H.J. Lu
1999-01-26 10:11 ` Steinar Bang
1999-01-31 23:58 ` Steinar Bang
1999-01-31 23:58 ` Steinar Bang
1999-01-31 23:58 ` H.J. Lu
1999-01-31 23:58 ` Steinar Bang
1999-01-22 7:05 ` Andris Pavenis
1999-01-27 9:04 ` Joe Buck
1999-01-28 0:55 ` Andris Pavenis
1999-01-28 1:16 ` Steinar Bang
1999-01-29 3:54 ` Steinar Bang
1999-01-29 17:30 ` H.J. Lu
1999-01-29 17:30 ` H.J. Lu
1999-01-29 17:58 ` Joe Buck
1999-01-29 18:30 ` Jeffrey A Law
1999-01-30 2:50 ` Andris Pavenis
1999-01-30 17:37 ` Joe Buck
1999-01-31 23:58 ` Joe Buck
1999-01-30 1:50 ` Andris Pavenis
1999-02-01 2:19 ` Steinar Bang
1999-02-28 22:53 ` Steinar Bang
1999-01-31 23:58 ` Steinar Bang
1999-01-31 23:58 ` Andris Pavenis
1999-01-29 17:30 ` H.J. Lu
1999-01-30 15:50 ` craig
1999-01-31 12:21 ` H.J. Lu
1999-02-01 4:48 ` craig
1999-02-28 22:53 ` craig
1999-01-31 23:58 ` craig
1999-01-31 23:58 ` Joe Buck
1999-01-31 23:58 ` Andris Pavenis
1999-01-31 23:58 ` H.J. Lu
1999-01-31 23:58 ` Steinar Bang
1999-01-31 23:58 ` Steinar Bang
1999-01-31 23:58 ` Steinar Bang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7774.919638865@hurl.cygnus.com \
--to=law@hurl.cygnus.com \
--cc=egcs-patches@egcs.cygnus.com \
--cc=egcs@egcs.cygnus.com \
--cc=hjl@lucon.org \
--cc=martin@mira.isdn.cs.tu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).