public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Iain Sandoe <iain@sandoe.co.uk>
To: Jonathan Wakely <jwakely.gcc@gmail.com>
Cc: "gcc@gcc.gnu.org" <gcc@gcc.gnu.org>,
	Nathan Sidwell <nathan@acm.org>, Jason Merrill <jason@redhat.com>
Subject: Re: Function signatures in extern "C".
Date: Mon, 7 Sep 2020 10:38:24 +0100	[thread overview]
Message-ID: <7C8BA6EE-D132-4853-8044-9129664E52D8@sandoe.co.uk> (raw)
In-Reply-To: <CAH6eHdQ9N2ezm8D-SK4zUbVop2sSZX2N+U5ahE9Et=8sf0y-cg@mail.gmail.com>

Jonathan Wakely via Gcc <gcc@gcc.gnu.org> wrote:

> On Mon, 7 Sep 2020 at 09:18, Iain Sandoe wrote:
>> Perhaps the PR should be reopened with “accepts invalid”?
>
> My impression from the PR is that the reporter was using a different
> ABI, where the name isn't reserved. Maybe the testcase should only be
> accepted with -fno-threadsafe-statics or -ffreestanding or something
> to say "I'm doing things differently".
>
> Or we could just say that G++ reserves the Itanium ABI names
> unconditionally, even if it doesn't need to use them, in which case it
> would be accepts-invalid.

Well, it’s a name in the implementation reserved namespace.

The majority of GCC platforms executing this test will cause the compiler
to generate a call to the function (and that call will have mismatched
params).  Not sure how many non-itanium ABI platforms we have at
present.

We say nothing for "-Wall -Wextra -pedantic"

(In the end, I don’t have much of an axe to grind here - this fail came up
  when I added diagnostic code to expand_call to catch cases like this
  emitted accidentally by the Fortran FE).

it seemed worth commenting at least.

cheers
Iain


      parent reply	other threads:[~2020-09-07  9:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-06 15:22 Iain Sandoe
2020-09-06 20:23 ` Jonathan Wakely
2020-09-06 20:43   ` Iain Sandoe
2020-09-06 23:05     ` Nathan Sidwell
2020-09-07  8:16       ` Iain Sandoe
2020-09-07  9:27         ` Jonathan Wakely
2020-09-07  9:34           ` Jakub Jelinek
2020-09-07 10:29             ` Jonathan Wakely
2020-09-10  7:58             ` Florian Weimer
2020-09-07  9:38           ` Iain Sandoe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7C8BA6EE-D132-4853-8044-9129664E52D8@sandoe.co.uk \
    --to=iain@sandoe.co.uk \
    --cc=gcc@gcc.gnu.org \
    --cc=jason@redhat.com \
    --cc=jwakely.gcc@gmail.com \
    --cc=nathan@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).