From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-return-103176-listarch-gcc=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 7682 invoked by alias); 24 Sep 2004 00:05:56 -0000
Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Archive: <http://gcc.gnu.org/ml/gcc/>
List-Post: <mailto:gcc@gcc.gnu.org>
List-Help: <http://gcc.gnu.org/ml/>
Sender: gcc-owner@gcc.gnu.org
Received: (qmail 7665 invoked from network); 24 Sep 2004 00:05:55 -0000
Received: from unknown (HELO smtp1.fuse.net) (216.68.8.174)
  by sourceware.org with SMTP; 24 Sep 2004 00:05:55 -0000
Received: from gx6.fuse.net ([66.42.228.133]) by smtp1.fuse.net
          (InterMail vM.6.01.03.04 201-2131-111-106-20040729) with ESMTP
          id <20040924000554.TQRJ14841.smtp1.fuse.net@gx6.fuse.net>
          for <gcc@gcc.gnu.org>; Thu, 23 Sep 2004 20:05:54 -0400
Received: from dellpi.pinski.fam ([66.42.228.133]) by gx6.fuse.net
          (InterMail vG.1.00.00.00 201-2136-104-20040331) with ESMTP
          id <20040924000554.BKPK5112.gx6.fuse.net@dellpi.pinski.fam>;
          Thu, 23 Sep 2004 20:05:54 -0400
Received: from [10.0.0.80] (zhivago.i.pinski.fam [10.0.0.80])
	by dellpi.pinski.fam (8.12.2/8.12.1) with ESMTP id i8O05mFj006493;
	Thu, 23 Sep 2004 20:05:49 -0400 (EDT)
In-Reply-To: <FA388EC7-0DBB-11D9-8B78-000A95B1F520@apple.com>
References: <FA388EC7-0DBB-11D9-8B78-000A95B1F520@apple.com>
Mime-Version: 1.0 (Apple Message framework v618)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-Id: <7CCA5E88-0DBD-11D9-921D-000A95D692F4@physics.uc.edu>
Content-Transfer-Encoding: 7bit
Cc: gcc List <gcc@gcc.gnu.org>
From: Andrew Pinski <pinskia@physics.uc.edu>
Subject: Re: attribute data structure rewrite
Date: Fri, 24 Sep 2004 00:34:00 -0000
To: Geoffrey Keating <geoffk@apple.com>
X-SW-Source: 2004-09/txt/msg01363.txt.bz2


On Sep 23, 2004, at 7:54 PM, Geoffrey Keating wrote:

> As a precondition for other compile speed improvements, I've been 
> rewriting the way that GCC represents attributes.  The result is a 
> medium-size patch that touches every language and many targets (a 
> surprising number of targets don't define any special attributes at 
> all).
>
> The basic principle is that DECL_ATTRIBUTES and TREE_ATTRIBUTES now 
> point to an attribute_list:
>
> /* A structure representing 'attributes' on a DECL or TYPE node.
>    Each attribute has a NAME (an IDENTIFIER_NODE) and possibly a 
> VALUE.  */
> struct one_attribute GTY(())
> {
>   tree name;
>   tree value;
> };

Shouldn't name be redefined as char* as you don't really need a full 
IDENTIFIER_NODE?
Yes I know that correctly it is not but I would suspect that it would 
give a good
speedup as you don't need to allocate as many trees as before.


Thanks,
Andrew Pinski