From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fencepost.gnu.org (fencepost.gnu.org [IPv6:2001:470:142:3::e]) by sourceware.org (Postfix) with ESMTPS id 83D9C3858C52; Wed, 10 Jan 2024 12:34:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 83D9C3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 83D9C3858C52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704890092; cv=none; b=RmesvcYAX2OJVz0401quPYCMXro9KbtlfcJFrmVCHZgxNz1fMxFvw7Q4vIxx/6DYUFarOarvbOwnEsvxQ3/4GnJjCR8kdnzd3akKKGbTTh5ApipmgQi+UHor8lg/haA2OcYfHttux9ajb9BQfuSmXRYULWLf4V4BqqdOK2MlqWk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704890092; c=relaxed/simple; bh=IMcVk5WwIndtkGAn/1K+rDbzVC7n2k8D+kjuXRlv/qo=; h=DKIM-Signature:Date:Message-Id:From:To:Subject:MIME-version; b=qc54NqjMpUQ3ReaBULgE0JsdGEvyJLSJfFLgX7l4Q2b1HsDbtG4RntigHzCMcAmEYA1Hpy5LRDfmBC+6DG0VXnI+JHn9tdEPtKbG5oWifK6n4SS24aP9Jxnax2RGlVoLxCGFKwyHBmDZOWi/eIOa2YC/ml6EcDbnplqWkDAKmgo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=p9JkHeDdJ2u/24zIPu9xvOnxqzl8CUYVO0NnzqGKqo8=; b=b6XfLmQWvKloUx/Q0ZRv ZzxNqEARIxybdSchRYL7aOcQVgcur7DKFyyCrCtTBvTvU3ALiiAm27PbNBLhOh+TSrtzr0YAyxG9p uvdYbrxDd7REcyTSuOoK1wnc7qIpoJNX72bg9/ilQjlu7wPoK7P25SLc0mFagEVEdTE+x5CIzNlpV rKuPx6B3C+o1IstE6/hOktfspTAbYkECqWPVipBzauYV6luO52qMN0Xfmleptw0bxjw2knH/2ENM/ e355GJDXqBKM5A7aiGV9NiJrB4gMHFQH6N8iZovjYBebrc4HUDM68s7yxJhPuGhi6LSJ3UGXEiCuA BWEixsb0rLhy6w==; Date: Wed, 10 Jan 2024 14:34:26 +0200 Message-Id: <83h6jlnz8t.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?Q?Bj=C3=B6rn_Sch=C3=A4pers?= Cc: iant@google.com, gcc-patches@gcc.gnu.org, gcc@gcc.gnu.org In-Reply-To: (message from =?utf-8?Q?Bj=C3=B6rn_Sch=C3=A4pers?= on Tue, 9 Jan 2024 21:02:44 +0100) Subject: Re: [PATCH 6/4] libbacktrace: Add loaded dlls after initialize References: <20230120105409.54949-1-gcc@hazardy.de> <20230120105409.54949-4-gcc@hazardy.de> <0c08e584-499f-473f-8699-a41c6a967536@hazardy.de> <863fd658-11e9-455e-9def-8a95217bc98f@hazardy.de> <83bk9xsklk.fsf@gnu.org> <4cb3a2a5-c0b3-40c8-b460-f21d65a9aea2@hazardy.de> <83ttnpqk0g.fsf@gnu.org> <4630f8bb-5859-483e-9db3-e09e4cb46ecf@hazardy.de> <83msthqdmx.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Date: Tue, 9 Jan 2024 21:02:44 +0100 > Cc: iant@google.com, gcc-patches@gcc.gnu.org, gcc@gcc.gnu.org > From: Björn Schäpers > > Am 07.01.2024 um 18:03 schrieb Eli Zaretskii: > > In that case, you an call either GetModuleHandeExA or > > GetModuleHandeExW, the difference is minor. > > Here an updated version without relying on TEXT or TCHAR, directly calling > GetModuleHandleExW. Thanks, this LGTM (but I couldn't test it, I just looked at the sour ce code).