From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fencepost.gnu.org (fencepost.gnu.org [IPv6:2001:470:142:3::e]) by sourceware.org (Postfix) with ESMTPS id C92CE3858D33; Mon, 20 Nov 2023 20:07:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C92CE3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C92CE3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700510852; cv=none; b=Kaw29T+pWYxOh6sP7bpY0i9cbgIhtZSfOsux0Bms3kTqDDg4zk6avQTd4QeWXx28qxoiddzoz6JWW9lB2TZwivbgKsahcpYxyzh860BLt8x0k8IUk8Z5dF3vGHVlbl0GascLAajhqRplP7IL57TY8/Rb3gLuuZr24QPDLR8ZjMw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700510852; c=relaxed/simple; bh=bZFpVsVqSfubucMl0rCRvjImDofYhg9esPXk3tmGH4M=; h=DKIM-Signature:Date:Message-Id:From:To:Subject:MIME-version; b=dCTCc17zDXfg7SaVq8MJ+4f2MetnT0BJ6yYJr5shXhaP8lEjsHN3M9tVENnd0rXxHBFuzJDVnxHuKIv+pJHLjZkvWyC6IQ3haLhX9Dm/kNROKHDOZxToHiUqT/V8R5WX9Tdfukp7RmOzR4fFKevaTq0V2TPBRQ3VTPDpY18zueQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=2HfIOeMUUZ4k7lHUTnUyKwtIYwGwViz5SNR9+S9dDEE=; b=iGOZaE1p/S4pyR2zTXrw jK5WCBqSJ22W+qznWhp9NSva36SxrsIfBi+aDGMZizV+36PvCUTKMtYQrckq0ippbvV1agD4Thwvx oo5fOTTsh9NsX0ivF40CGTK1Bxc8Wv1zJksI2Mtjc7IHNvhwEe0N/3yRQd91QSNHAoNzPjz6vVfQY GwpDgHBKiAPrJl3J7dzbXIjb+2B4+b58Gmtrs35tSP53s8uznuztiTyUqIlNRGuT6YZQ7tTFz/25X WWwLpZZVmo6n/Ye9MFu9uHtumOuUJttUr9VPU2HKqnKa1S5BPXAzBMJ7oBOJNCKAnZG6Mv7Ly0QTb Nxx8p1hJhbAgwA==; Date: Mon, 20 Nov 2023 22:07:15 +0200 Message-Id: <83jzqci3yk.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?Q?Bj=C3=B6rn_Sch=C3=A4pers?= Cc: gabravier@gmail.com, gcc-patches@gcc.gnu.org, gcc@gcc.gnu.org In-Reply-To: (message from =?utf-8?Q?Bj=C3=B6rn_Sch=C3=A4pers?= on Mon, 20 Nov 2023 20:57:38 +0100) Subject: Re: [PATCH 3/4] libbacktrace: work with aslr on windows References: <20230120105409.54949-1-gcc@hazardy.de> <20230120105409.54949-3-gcc@hazardy.de> <83zgadmik1.fsf@gnu.org> <83k01hm2sm.fsf@gnu.org> <64148e01-15a1-0331-ad52-bf131403ed76@gmail.com> <83h6wkmt0t.fsf@gnu.org> <83pmb8ktbe.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Date: Mon, 20 Nov 2023 20:57:38 +0100 > Cc: gcc-patches@gcc.gnu.org, gcc@gcc.gnu.org > From: Björn Schäpers > > +#ifndef NOMINMAX > +#define NOMINMAX > +#endif Why is this part needed? Otherwise, LGTM, thanks. (But I'm don't have the approval rights, so please wait for Ian to chime in.)