public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Mike Stump <mrs@apple.com>
To: GCC Development <gcc@gcc.gnu.org>
Subject: defaults.h silliness
Date: Fri, 24 Jun 2005 00:12:00 -0000	[thread overview]
Message-ID: <84A6B9AE-4267-4996-8827-4E4DD48603F3@apple.com> (raw)

In defaults.h, they do:

/* This is how to output an element of a case-vector that is absolute.
    Some targets don't use this, but we have to define it anyway.  */

#ifndef ASM_OUTPUT_ADDR_VEC_ELT
#define ASM_OUTPUT_ADDR_VEC_ELT(FILE, VALUE)  \
do { fputs (integer_asm_op (POINTER_SIZE / BITS_PER_UNIT, TRUE),  
FILE); \
      (*targetm.asm_out.internal_label) (FILE, "L",  
(VALUE));                    \
      fputc ('\n',  
FILE);                                                \
    } while (0)
#endif

but internal_label is used to output a definition of a label, and  
ASM_OUTPUT_ADDR_VEC_ELT is supposed to output a mere use of the label.

s390.h has a more suitable default definition:
/* Output an element of a case-vector that is absolute.  */
#define ASM_OUTPUT_ADDR_VEC_ELT(FILE,  
VALUE)                            \
do  
{                                                                    \
   char buf 
[32];                                                         \
   fputs (integer_asm_op (UNITS_PER_WORD, TRUE),  
(FILE));                \
   ASM_GENERATE_INTERNAL_LABEL (buf, "L",  
(VALUE));                      \
   assemble_name ((FILE),  
buf);                                          \
   fputc ('\n',  
(FILE));                                                 \
} while (0)

:-(  Having defaults that no one can use, is silly?!

             reply	other threads:[~2005-06-24  0:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-24  0:12 Mike Stump [this message]
2005-07-02  2:23 ` James E Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84A6B9AE-4267-4996-8827-4E4DD48603F3@apple.com \
    --to=mrs@apple.com \
    --cc=gcc@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).